2019-04-15 06:17:05 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
2015-02-17 10:59:50 -05:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
|
|
describe Import::BitbucketController do
|
2015-05-21 17:40:13 -04:00
|
|
|
include ImportSpecHelper
|
|
|
|
|
|
2015-08-07 03:06:20 -04:00
|
|
|
let(:user) { create(:user) }
|
|
|
|
|
let(:token) { "asdasd12345" }
|
|
|
|
|
let(:secret) { "sekrettt" }
|
2016-11-21 00:00:02 -05:00
|
|
|
let(:refresh_token) { SecureRandom.hex(15) }
|
2016-11-21 01:29:45 -05:00
|
|
|
let(:access_params) { { token: token, expires_at: nil, expires_in: nil, refresh_token: nil } }
|
2019-01-22 12:38:08 -05:00
|
|
|
let(:code) { SecureRandom.hex(8) }
|
2015-08-07 03:06:20 -04:00
|
|
|
|
|
|
|
|
def assign_session_tokens
|
2016-11-21 00:00:02 -05:00
|
|
|
session[:bitbucket_token] = token
|
2015-08-07 03:06:20 -04:00
|
|
|
end
|
2015-02-17 10:59:50 -05:00
|
|
|
|
|
|
|
|
before do
|
|
|
|
|
sign_in(user)
|
2015-05-21 17:40:13 -04:00
|
|
|
allow(controller).to receive(:bitbucket_import_enabled?).and_return(true)
|
2015-02-17 10:59:50 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
describe "GET callback" do
|
|
|
|
|
before do
|
|
|
|
|
session[:oauth_request_token] = {}
|
|
|
|
|
end
|
2015-06-22 16:00:54 -04:00
|
|
|
|
2015-02-17 10:59:50 -05:00
|
|
|
it "updates access token" do
|
2016-11-21 00:00:02 -05:00
|
|
|
expires_at = Time.now + 1.day
|
|
|
|
|
expires_in = 1.day
|
|
|
|
|
access_token = double(token: token,
|
|
|
|
|
secret: secret,
|
|
|
|
|
expires_at: expires_at,
|
|
|
|
|
expires_in: expires_in,
|
|
|
|
|
refresh_token: refresh_token)
|
2017-06-21 09:48:12 -04:00
|
|
|
allow_any_instance_of(OAuth2::Client)
|
2019-01-22 12:38:08 -05:00
|
|
|
.to receive(:get_token)
|
|
|
|
|
.with(hash_including(
|
|
|
|
|
'grant_type' => 'authorization_code',
|
|
|
|
|
'code' => code,
|
|
|
|
|
redirect_uri: users_import_bitbucket_callback_url),
|
|
|
|
|
{})
|
|
|
|
|
.and_return(access_token)
|
2015-05-21 17:40:13 -04:00
|
|
|
stub_omniauth_provider('bitbucket')
|
2015-02-17 10:59:50 -05:00
|
|
|
|
2019-01-22 12:38:08 -05:00
|
|
|
get :callback, params: { code: code }
|
2015-02-17 10:59:50 -05:00
|
|
|
|
2016-11-21 00:00:02 -05:00
|
|
|
expect(session[:bitbucket_token]).to eq(token)
|
|
|
|
|
expect(session[:bitbucket_refresh_token]).to eq(refresh_token)
|
|
|
|
|
expect(session[:bitbucket_expires_at]).to eq(expires_at)
|
|
|
|
|
expect(session[:bitbucket_expires_in]).to eq(expires_in)
|
2015-02-17 10:59:50 -05:00
|
|
|
expect(controller).to redirect_to(status_import_bitbucket_url)
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
describe "GET status" do
|
|
|
|
|
before do
|
2016-11-21 00:33:06 -05:00
|
|
|
@repo = double(slug: 'vim', owner: 'asd', full_name: 'asd/vim', "valid?" => true)
|
2015-08-07 03:06:20 -04:00
|
|
|
assign_session_tokens
|
2015-02-17 10:59:50 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "assigns variables" do
|
2017-08-02 15:55:11 -04:00
|
|
|
@project = create(:project, import_type: 'bitbucket', creator_id: user.id)
|
2016-11-21 00:33:06 -05:00
|
|
|
allow_any_instance_of(Bitbucket::Client).to receive(:repos).and_return([@repo])
|
2015-02-17 10:59:50 -05:00
|
|
|
|
|
|
|
|
get :status
|
|
|
|
|
|
|
|
|
|
expect(assigns(:already_added_projects)).to eq([@project])
|
|
|
|
|
expect(assigns(:repos)).to eq([@repo])
|
2015-08-07 04:02:01 -04:00
|
|
|
expect(assigns(:incompatible_repos)).to eq([])
|
2015-02-17 10:59:50 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "does not show already added project" do
|
2017-08-02 15:55:11 -04:00
|
|
|
@project = create(:project, import_type: 'bitbucket', creator_id: user.id, import_source: 'asd/vim')
|
2016-11-21 00:33:06 -05:00
|
|
|
allow_any_instance_of(Bitbucket::Client).to receive(:repos).and_return([@repo])
|
2015-02-17 10:59:50 -05:00
|
|
|
|
|
|
|
|
get :status
|
|
|
|
|
|
|
|
|
|
expect(assigns(:already_added_projects)).to eq([@project])
|
|
|
|
|
expect(assigns(:repos)).to eq([])
|
|
|
|
|
end
|
2019-09-26 14:06:29 -04:00
|
|
|
|
|
|
|
|
context 'when filtering' do
|
|
|
|
|
let(:filter) { '<html>test</html>' }
|
|
|
|
|
let(:expected_filter) { 'test' }
|
|
|
|
|
|
|
|
|
|
subject { get :status, params: { filter: filter }, as: :json }
|
|
|
|
|
|
|
|
|
|
it 'passes sanitized filter param to bitbucket client' do
|
|
|
|
|
expect_next_instance_of(Bitbucket::Client) do |client|
|
|
|
|
|
expect(client).to receive(:repos).with(filter: expected_filter).and_return([@repo])
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
subject
|
|
|
|
|
end
|
|
|
|
|
end
|
2015-02-17 10:59:50 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
describe "POST create" do
|
2015-04-01 11:17:18 -04:00
|
|
|
let(:bitbucket_username) { user.username }
|
|
|
|
|
|
2015-06-22 16:00:54 -04:00
|
|
|
let(:bitbucket_user) do
|
2016-11-21 01:29:45 -05:00
|
|
|
double(username: bitbucket_username)
|
2015-06-22 16:00:54 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
let(:bitbucket_repo) do
|
2016-11-21 01:29:45 -05:00
|
|
|
double(slug: "vim", owner: bitbucket_username, name: 'vim')
|
2015-06-22 16:00:54 -04:00
|
|
|
end
|
2015-04-01 11:17:18 -04:00
|
|
|
|
2018-02-09 06:14:48 -05:00
|
|
|
let(:project) { create(:project) }
|
|
|
|
|
|
2015-04-01 11:17:18 -04:00
|
|
|
before do
|
2016-11-21 01:29:45 -05:00
|
|
|
allow_any_instance_of(Bitbucket::Client).to receive(:repo).and_return(bitbucket_repo)
|
|
|
|
|
allow_any_instance_of(Bitbucket::Client).to receive(:user).and_return(bitbucket_user)
|
2015-08-07 03:06:20 -04:00
|
|
|
assign_session_tokens
|
2015-04-01 11:17:18 -04:00
|
|
|
end
|
|
|
|
|
|
2018-02-09 06:14:48 -05:00
|
|
|
it 'returns 200 response when the project is imported successfully' do
|
|
|
|
|
allow(Gitlab::BitbucketImport::ProjectCreator)
|
|
|
|
|
.to receive(:new).with(bitbucket_repo, bitbucket_repo.name, user.namespace, user, access_params)
|
|
|
|
|
.and_return(double(execute: project))
|
|
|
|
|
|
|
|
|
|
post :create, format: :json
|
|
|
|
|
|
2020-02-06 13:08:54 -05:00
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
2018-02-09 06:14:48 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'returns 422 response when the project could not be imported' do
|
|
|
|
|
allow(Gitlab::BitbucketImport::ProjectCreator)
|
|
|
|
|
.to receive(:new).with(bitbucket_repo, bitbucket_repo.name, user.namespace, user, access_params)
|
|
|
|
|
.and_return(double(execute: build(:project)))
|
|
|
|
|
|
|
|
|
|
post :create, format: :json
|
|
|
|
|
|
2020-02-06 13:08:54 -05:00
|
|
|
expect(response).to have_gitlab_http_status(:unprocessable_entity)
|
2018-02-09 06:14:48 -05:00
|
|
|
end
|
|
|
|
|
|
2020-01-23 19:08:51 -05:00
|
|
|
it_behaves_like 'project import rate limiter'
|
|
|
|
|
|
2015-04-01 11:17:18 -04:00
|
|
|
context "when the repository owner is the Bitbucket user" do
|
|
|
|
|
context "when the Bitbucket user and GitLab user's usernames match" do
|
|
|
|
|
it "takes the current user's namespace" do
|
2017-06-21 09:48:12 -04:00
|
|
|
expect(Gitlab::BitbucketImport::ProjectCreator)
|
|
|
|
|
.to receive(:new).with(bitbucket_repo, bitbucket_repo.name, user.namespace, user, access_params)
|
2018-02-09 06:14:48 -05:00
|
|
|
.and_return(double(execute: project))
|
2015-04-01 11:17:18 -04:00
|
|
|
|
2018-02-09 06:14:48 -05:00
|
|
|
post :create, format: :json
|
2015-04-01 11:17:18 -04:00
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context "when the Bitbucket user and GitLab user's usernames don't match" do
|
|
|
|
|
let(:bitbucket_username) { "someone_else" }
|
|
|
|
|
|
|
|
|
|
it "takes the current user's namespace" do
|
2017-06-21 09:48:12 -04:00
|
|
|
expect(Gitlab::BitbucketImport::ProjectCreator)
|
|
|
|
|
.to receive(:new).with(bitbucket_repo, bitbucket_repo.name, user.namespace, user, access_params)
|
2018-02-09 06:14:48 -05:00
|
|
|
.and_return(double(execute: project))
|
2015-04-01 11:17:18 -04:00
|
|
|
|
2018-02-09 06:14:48 -05:00
|
|
|
post :create, format: :json
|
2015-04-01 11:17:18 -04:00
|
|
|
end
|
|
|
|
|
end
|
2017-03-21 01:17:46 -04:00
|
|
|
|
|
|
|
|
context 'when the Bitbucket user is unauthorized' do
|
|
|
|
|
render_views
|
|
|
|
|
|
|
|
|
|
it 'returns unauthorized' do
|
|
|
|
|
allow(controller).to receive(:current_user).and_return(user)
|
|
|
|
|
allow(user).to receive(:can?).and_return(false)
|
|
|
|
|
|
2018-02-09 06:14:48 -05:00
|
|
|
post :create, format: :json
|
2017-03-21 01:17:46 -04:00
|
|
|
end
|
|
|
|
|
end
|
2015-04-01 11:17:18 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context "when the repository owner is not the Bitbucket user" do
|
|
|
|
|
let(:other_username) { "someone_else" }
|
|
|
|
|
|
|
|
|
|
before do
|
2016-11-21 01:29:45 -05:00
|
|
|
allow(bitbucket_repo).to receive(:owner).and_return(other_username)
|
2015-04-01 11:17:18 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context "when a namespace with the Bitbucket user's username already exists" do
|
2017-05-24 16:59:26 -04:00
|
|
|
let!(:existing_namespace) { create(:group, name: other_username) }
|
2015-04-01 11:17:18 -04:00
|
|
|
|
|
|
|
|
context "when the namespace is owned by the GitLab user" do
|
2017-05-24 16:59:26 -04:00
|
|
|
before do
|
|
|
|
|
existing_namespace.add_owner(user)
|
|
|
|
|
end
|
|
|
|
|
|
2015-04-01 11:17:18 -04:00
|
|
|
it "takes the existing namespace" do
|
2017-06-21 09:48:12 -04:00
|
|
|
expect(Gitlab::BitbucketImport::ProjectCreator)
|
|
|
|
|
.to receive(:new).with(bitbucket_repo, bitbucket_repo.name, existing_namespace, user, access_params)
|
2018-02-09 06:14:48 -05:00
|
|
|
.and_return(double(execute: project))
|
2015-04-01 11:17:18 -04:00
|
|
|
|
2018-02-09 06:14:48 -05:00
|
|
|
post :create, format: :json
|
2015-04-01 11:17:18 -04:00
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context "when the namespace is not owned by the GitLab user" do
|
|
|
|
|
it "doesn't create a project" do
|
2017-06-21 09:48:12 -04:00
|
|
|
expect(Gitlab::BitbucketImport::ProjectCreator)
|
|
|
|
|
.not_to receive(:new)
|
2015-04-01 11:17:18 -04:00
|
|
|
|
2018-02-09 06:14:48 -05:00
|
|
|
post :create, format: :json
|
2015-04-01 11:17:18 -04:00
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
context "when a namespace with the Bitbucket user's username doesn't exist" do
|
2016-08-29 17:17:11 -04:00
|
|
|
context "when current user can create namespaces" do
|
|
|
|
|
it "creates the namespace" do
|
2017-06-21 09:48:12 -04:00
|
|
|
expect(Gitlab::BitbucketImport::ProjectCreator)
|
2018-02-09 06:14:48 -05:00
|
|
|
.to receive(:new).and_return(double(execute: project))
|
2015-04-01 11:17:18 -04:00
|
|
|
|
2018-02-09 06:14:48 -05:00
|
|
|
expect { post :create, format: :json }.to change(Namespace, :count).by(1)
|
2016-08-29 17:17:11 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "takes the new namespace" do
|
2017-06-21 09:48:12 -04:00
|
|
|
expect(Gitlab::BitbucketImport::ProjectCreator)
|
|
|
|
|
.to receive(:new).with(bitbucket_repo, bitbucket_repo.name, an_instance_of(Group), user, access_params)
|
2018-02-09 06:14:48 -05:00
|
|
|
.and_return(double(execute: project))
|
2015-04-01 11:17:18 -04:00
|
|
|
|
2018-02-09 06:14:48 -05:00
|
|
|
post :create, format: :json
|
2016-08-29 17:17:11 -04:00
|
|
|
end
|
2015-04-01 11:17:18 -04:00
|
|
|
end
|
|
|
|
|
|
2016-08-29 17:17:11 -04:00
|
|
|
context "when current user can't create namespaces" do
|
|
|
|
|
before do
|
|
|
|
|
user.update_attribute(:can_create_group, false)
|
|
|
|
|
end
|
2015-04-01 11:17:18 -04:00
|
|
|
|
2016-08-29 17:17:11 -04:00
|
|
|
it "doesn't create the namespace" do
|
2017-06-21 09:48:12 -04:00
|
|
|
expect(Gitlab::BitbucketImport::ProjectCreator)
|
2018-02-09 06:14:48 -05:00
|
|
|
.to receive(:new).and_return(double(execute: project))
|
2016-08-29 17:17:11 -04:00
|
|
|
|
2018-02-09 06:14:48 -05:00
|
|
|
expect { post :create, format: :json }.not_to change(Namespace, :count)
|
2016-08-29 17:17:11 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it "takes the current user's namespace" do
|
2017-06-21 09:48:12 -04:00
|
|
|
expect(Gitlab::BitbucketImport::ProjectCreator)
|
|
|
|
|
.to receive(:new).with(bitbucket_repo, bitbucket_repo.name, user.namespace, user, access_params)
|
2018-02-09 06:14:48 -05:00
|
|
|
.and_return(double(execute: project))
|
2016-08-29 17:17:11 -04:00
|
|
|
|
2018-02-09 06:14:48 -05:00
|
|
|
post :create, format: :json
|
2016-08-29 17:17:11 -04:00
|
|
|
end
|
2015-04-01 11:17:18 -04:00
|
|
|
end
|
|
|
|
|
end
|
2015-02-17 10:59:50 -05:00
|
|
|
end
|
2017-04-05 06:09:31 -04:00
|
|
|
|
2019-07-24 05:20:54 -04:00
|
|
|
context 'user has chosen an existing nested namespace and name for the project' do
|
2018-04-23 11:48:26 -04:00
|
|
|
let(:parent_namespace) { create(:group, name: 'foo') }
|
2017-05-24 16:59:26 -04:00
|
|
|
let(:nested_namespace) { create(:group, name: 'bar', parent: parent_namespace) }
|
2017-04-05 06:09:31 -04:00
|
|
|
let(:test_name) { 'test_name' }
|
|
|
|
|
|
2017-05-24 16:59:26 -04:00
|
|
|
before do
|
2018-04-23 11:48:26 -04:00
|
|
|
parent_namespace.add_owner(user)
|
2017-05-24 16:59:26 -04:00
|
|
|
nested_namespace.add_owner(user)
|
|
|
|
|
end
|
|
|
|
|
|
2017-04-05 06:09:31 -04:00
|
|
|
it 'takes the selected namespace and name' do
|
2017-06-21 09:48:12 -04:00
|
|
|
expect(Gitlab::BitbucketImport::ProjectCreator)
|
|
|
|
|
.to receive(:new).with(bitbucket_repo, test_name, nested_namespace, user, access_params)
|
2018-02-09 06:14:48 -05:00
|
|
|
.and_return(double(execute: project))
|
2017-04-05 06:09:31 -04:00
|
|
|
|
2018-12-17 17:52:17 -05:00
|
|
|
post :create, params: { target_namespace: nested_namespace.full_path, new_name: test_name }, format: :json
|
2017-04-05 06:09:31 -04:00
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
2019-07-24 05:20:54 -04:00
|
|
|
context 'user has chosen a non-existent nested namespaces and name for the project' do
|
2017-04-05 06:09:31 -04:00
|
|
|
let(:test_name) { 'test_name' }
|
|
|
|
|
|
|
|
|
|
it 'takes the selected namespace and name' do
|
2017-06-21 09:48:12 -04:00
|
|
|
expect(Gitlab::BitbucketImport::ProjectCreator)
|
|
|
|
|
.to receive(:new).with(bitbucket_repo, test_name, kind_of(Namespace), user, access_params)
|
2018-02-09 06:14:48 -05:00
|
|
|
.and_return(double(execute: project))
|
2017-04-05 06:09:31 -04:00
|
|
|
|
2018-12-17 17:52:17 -05:00
|
|
|
post :create, params: { target_namespace: 'foo/bar', new_name: test_name }, format: :json
|
2017-04-05 06:09:31 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'creates the namespaces' do
|
2017-06-21 09:48:12 -04:00
|
|
|
allow(Gitlab::BitbucketImport::ProjectCreator)
|
|
|
|
|
.to receive(:new).with(bitbucket_repo, test_name, kind_of(Namespace), user, access_params)
|
2018-02-09 06:14:48 -05:00
|
|
|
.and_return(double(execute: project))
|
2017-04-05 06:09:31 -04:00
|
|
|
|
2018-12-17 17:52:17 -05:00
|
|
|
expect { post :create, params: { target_namespace: 'foo/bar', new_name: test_name }, format: :json }
|
2017-04-05 06:09:31 -04:00
|
|
|
.to change { Namespace.count }.by(2)
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'new namespace has the right parent' do
|
2017-06-21 09:48:12 -04:00
|
|
|
allow(Gitlab::BitbucketImport::ProjectCreator)
|
|
|
|
|
.to receive(:new).with(bitbucket_repo, test_name, kind_of(Namespace), user, access_params)
|
2018-02-09 06:14:48 -05:00
|
|
|
.and_return(double(execute: project))
|
2017-04-05 06:09:31 -04:00
|
|
|
|
2018-12-17 17:52:17 -05:00
|
|
|
post :create, params: { target_namespace: 'foo/bar', new_name: test_name }, format: :json
|
2017-04-05 06:09:31 -04:00
|
|
|
|
|
|
|
|
expect(Namespace.find_by_path_or_name('bar').parent.path).to eq('foo')
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
|
2019-07-24 05:20:54 -04:00
|
|
|
context 'user has chosen existent and non-existent nested namespaces and name for the project' do
|
2017-04-05 06:09:31 -04:00
|
|
|
let(:test_name) { 'test_name' }
|
2018-04-23 11:48:26 -04:00
|
|
|
let!(:parent_namespace) { create(:group, name: 'foo') }
|
2017-04-05 06:09:31 -04:00
|
|
|
|
2018-01-26 10:39:10 -05:00
|
|
|
before do
|
|
|
|
|
parent_namespace.add_owner(user)
|
|
|
|
|
end
|
|
|
|
|
|
2017-04-05 06:09:31 -04:00
|
|
|
it 'takes the selected namespace and name' do
|
2017-06-21 09:48:12 -04:00
|
|
|
expect(Gitlab::BitbucketImport::ProjectCreator)
|
|
|
|
|
.to receive(:new).with(bitbucket_repo, test_name, kind_of(Namespace), user, access_params)
|
2018-02-09 06:14:48 -05:00
|
|
|
.and_return(double(execute: project))
|
2017-04-05 06:09:31 -04:00
|
|
|
|
2018-12-17 17:52:17 -05:00
|
|
|
post :create, params: { target_namespace: 'foo/foobar/bar', new_name: test_name }, format: :json
|
2017-04-05 06:09:31 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
it 'creates the namespaces' do
|
2017-06-21 09:48:12 -04:00
|
|
|
allow(Gitlab::BitbucketImport::ProjectCreator)
|
|
|
|
|
.to receive(:new).with(bitbucket_repo, test_name, kind_of(Namespace), user, access_params)
|
2018-02-09 06:14:48 -05:00
|
|
|
.and_return(double(execute: project))
|
2017-04-05 06:09:31 -04:00
|
|
|
|
2018-12-17 17:52:17 -05:00
|
|
|
expect { post :create, params: { target_namespace: 'foo/foobar/bar', new_name: test_name }, format: :json }
|
2017-04-05 06:09:31 -04:00
|
|
|
.to change { Namespace.count }.by(2)
|
|
|
|
|
end
|
|
|
|
|
end
|
2018-02-09 06:14:48 -05:00
|
|
|
|
|
|
|
|
context 'when user can not create projects in the chosen namespace' do
|
|
|
|
|
it 'returns 422 response' do
|
|
|
|
|
other_namespace = create(:group, name: 'other_namespace')
|
|
|
|
|
|
2018-12-17 17:52:17 -05:00
|
|
|
post :create, params: { target_namespace: other_namespace.name }, format: :json
|
2018-02-09 06:14:48 -05:00
|
|
|
|
2020-02-06 13:08:54 -05:00
|
|
|
expect(response).to have_gitlab_http_status(:unprocessable_entity)
|
2018-02-09 06:14:48 -05:00
|
|
|
end
|
|
|
|
|
end
|
2015-02-17 10:59:50 -05:00
|
|
|
end
|
|
|
|
|
end
|
