2015-05-04 23:06:57 -04:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2018-07-05 02:32:05 -04:00
|
|
|
describe 'Task Lists' do
|
2015-05-04 23:06:57 -04:00
|
|
|
include Warden::Test::Helpers
|
|
|
|
|
2017-10-10 10:56:04 -04:00
|
|
|
let(:project) { create(:project, :repository) }
|
2015-05-04 23:06:57 -04:00
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:user2) { create(:user) }
|
|
|
|
|
|
|
|
let(:markdown) do
|
|
|
|
<<-MARKDOWN.strip_heredoc
|
|
|
|
This is a task list:
|
|
|
|
|
|
|
|
- [ ] Incomplete entry 1
|
|
|
|
- [x] Complete entry 1
|
|
|
|
- [ ] Incomplete entry 2
|
|
|
|
- [x] Complete entry 2
|
|
|
|
- [ ] Incomplete entry 3
|
|
|
|
- [ ] Incomplete entry 4
|
|
|
|
MARKDOWN
|
|
|
|
end
|
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
let(:singleIncompleteMarkdown) do
|
|
|
|
<<-MARKDOWN.strip_heredoc
|
|
|
|
This is a task list:
|
|
|
|
|
|
|
|
- [ ] Incomplete entry 1
|
|
|
|
MARKDOWN
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:singleCompleteMarkdown) do
|
|
|
|
<<-MARKDOWN.strip_heredoc
|
|
|
|
This is a task list:
|
|
|
|
|
|
|
|
- [x] Incomplete entry 1
|
|
|
|
MARKDOWN
|
|
|
|
end
|
|
|
|
|
2018-06-14 04:30:16 -04:00
|
|
|
let(:nested_tasks_markdown) do
|
|
|
|
<<-EOT.strip_heredoc
|
|
|
|
- [ ] Task a
|
|
|
|
- [x] Task a.1
|
|
|
|
- [ ] Task a.2
|
|
|
|
- [ ] Task b
|
|
|
|
|
|
|
|
1. [ ] Task 1
|
|
|
|
1. [ ] Task 1.1
|
|
|
|
1. [x] Task 1.2
|
|
|
|
EOT
|
|
|
|
end
|
|
|
|
|
2015-05-04 23:06:57 -04:00
|
|
|
before do
|
|
|
|
Warden.test_mode!
|
|
|
|
|
2018-07-11 10:36:08 -04:00
|
|
|
project.add_maintainer(user)
|
2017-08-09 07:30:07 -04:00
|
|
|
project.add_guest(user2)
|
2015-05-04 23:06:57 -04:00
|
|
|
|
|
|
|
login_as(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
def visit_issue(project, issue)
|
2017-06-29 13:06:35 -04:00
|
|
|
visit project_issue_path(project, issue)
|
2015-05-04 23:06:57 -04:00
|
|
|
end
|
|
|
|
|
2017-06-29 00:13:10 -04:00
|
|
|
describe 'for Issues' do
|
2017-10-03 04:35:01 -04:00
|
|
|
describe 'multiple tasks', :js do
|
2016-08-27 13:36:08 -04:00
|
|
|
let!(:issue) { create(:issue, description: markdown, author: user, project: project) }
|
2015-05-04 23:06:57 -04:00
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
it 'renders' do
|
|
|
|
visit_issue(project, issue)
|
2017-05-17 14:25:13 -04:00
|
|
|
wait_for_requests
|
2017-04-24 17:03:58 -04:00
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
expect(page).to have_selector('ul.task-list', count: 1)
|
|
|
|
expect(page).to have_selector('li.task-list-item', count: 6)
|
|
|
|
expect(page).to have_selector('ul input[checked]', count: 2)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'contains the required selectors' do
|
|
|
|
visit_issue(project, issue)
|
2017-05-17 14:25:13 -04:00
|
|
|
wait_for_requests
|
2016-08-27 13:36:08 -04:00
|
|
|
|
2017-05-03 16:35:54 -04:00
|
|
|
expect(page).to have_selector(".wiki .task-list .task-list-item .task-list-item-checkbox")
|
2016-08-27 13:36:08 -04:00
|
|
|
expect(page).to have_selector('a.btn-close')
|
|
|
|
end
|
2015-05-04 23:06:57 -04:00
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
it 'is only editable by author' do
|
|
|
|
visit_issue(project, issue)
|
2017-05-17 14:25:13 -04:00
|
|
|
wait_for_requests
|
2017-04-24 17:03:58 -04:00
|
|
|
|
2017-05-03 16:35:54 -04:00
|
|
|
expect(page).to have_selector(".wiki .task-list .task-list-item .task-list-item-checkbox")
|
2015-05-04 23:06:57 -04:00
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
logout(:user)
|
|
|
|
login_as(user2)
|
|
|
|
visit current_path
|
2017-05-17 14:25:13 -04:00
|
|
|
wait_for_requests
|
2017-05-03 16:35:54 -04:00
|
|
|
|
|
|
|
expect(page).to have_selector(".wiki .task-list .task-list-item .task-list-item-checkbox")
|
2016-08-27 13:36:08 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'provides a summary on Issues#index' do
|
2017-06-29 13:06:35 -04:00
|
|
|
visit project_issues_path(project)
|
2016-08-27 13:36:08 -04:00
|
|
|
expect(page).to have_content("2 of 6 tasks completed")
|
|
|
|
end
|
2015-05-04 23:06:57 -04:00
|
|
|
end
|
|
|
|
|
2017-10-03 04:35:01 -04:00
|
|
|
describe 'single incomplete task', :js do
|
2016-08-27 13:36:08 -04:00
|
|
|
let!(:issue) { create(:issue, description: singleIncompleteMarkdown, author: user, project: project) }
|
2015-05-04 23:06:57 -04:00
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
it 'renders' do
|
|
|
|
visit_issue(project, issue)
|
2017-05-17 14:25:13 -04:00
|
|
|
wait_for_requests
|
2017-04-24 17:03:58 -04:00
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
expect(page).to have_selector('ul.task-list', count: 1)
|
|
|
|
expect(page).to have_selector('li.task-list-item', count: 1)
|
|
|
|
expect(page).to have_selector('ul input[checked]', count: 0)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'provides a summary on Issues#index' do
|
2017-06-29 13:06:35 -04:00
|
|
|
visit project_issues_path(project)
|
2017-05-03 16:35:54 -04:00
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
expect(page).to have_content("0 of 1 task completed")
|
|
|
|
end
|
2015-05-04 23:06:57 -04:00
|
|
|
end
|
|
|
|
|
2017-10-03 04:35:01 -04:00
|
|
|
describe 'single complete task', :js do
|
2016-08-27 13:36:08 -04:00
|
|
|
let!(:issue) { create(:issue, description: singleCompleteMarkdown, author: user, project: project) }
|
|
|
|
|
|
|
|
it 'renders' do
|
|
|
|
visit_issue(project, issue)
|
2017-05-17 14:25:13 -04:00
|
|
|
wait_for_requests
|
2017-04-24 17:03:58 -04:00
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
expect(page).to have_selector('ul.task-list', count: 1)
|
|
|
|
expect(page).to have_selector('li.task-list-item', count: 1)
|
|
|
|
expect(page).to have_selector('ul input[checked]', count: 1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'provides a summary on Issues#index' do
|
2017-06-29 13:06:35 -04:00
|
|
|
visit project_issues_path(project)
|
2017-05-03 16:35:54 -04:00
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
expect(page).to have_content("1 of 1 task completed")
|
|
|
|
end
|
2015-05-04 23:06:57 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'for Notes' do
|
|
|
|
let!(:issue) { create(:issue, author: user, project: project) }
|
2016-08-27 13:36:08 -04:00
|
|
|
describe 'multiple tasks' do
|
|
|
|
let!(:note) do
|
|
|
|
create(:note, note: markdown, noteable: issue,
|
|
|
|
project: project, author: user)
|
|
|
|
end
|
|
|
|
|
2017-08-12 20:00:22 -04:00
|
|
|
it 'renders for note body', :js do
|
2016-08-27 13:36:08 -04:00
|
|
|
visit_issue(project, issue)
|
|
|
|
|
|
|
|
expect(page).to have_selector('.note ul.task-list', count: 1)
|
|
|
|
expect(page).to have_selector('.note li.task-list-item', count: 6)
|
|
|
|
expect(page).to have_selector('.note ul input[checked]', count: 2)
|
|
|
|
end
|
|
|
|
|
2017-08-12 20:00:22 -04:00
|
|
|
it 'contains the required selectors', :js do
|
2016-08-27 13:36:08 -04:00
|
|
|
visit_issue(project, issue)
|
|
|
|
|
|
|
|
expect(page).to have_selector('.note .js-task-list-container')
|
|
|
|
expect(page).to have_selector('.note .js-task-list-container .task-list .task-list-item .task-list-item-checkbox')
|
|
|
|
end
|
|
|
|
|
2017-08-12 20:00:22 -04:00
|
|
|
it 'is only editable by author', :js do
|
2016-08-27 13:36:08 -04:00
|
|
|
visit_issue(project, issue)
|
|
|
|
expect(page).to have_selector('.js-task-list-container')
|
|
|
|
|
2017-09-04 01:47:56 -04:00
|
|
|
gitlab_sign_out
|
2016-08-27 13:36:08 -04:00
|
|
|
|
2017-09-04 01:47:56 -04:00
|
|
|
gitlab_sign_in(user2)
|
2016-08-27 13:36:08 -04:00
|
|
|
visit current_path
|
|
|
|
expect(page).not_to have_selector('.js-task-list-container')
|
|
|
|
end
|
2016-04-26 07:52:18 -04:00
|
|
|
end
|
2015-05-04 23:06:57 -04:00
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
describe 'single incomplete task' do
|
|
|
|
let!(:note) do
|
|
|
|
create(:note, note: singleIncompleteMarkdown, noteable: issue,
|
|
|
|
project: project, author: user)
|
|
|
|
end
|
2015-05-04 23:06:57 -04:00
|
|
|
|
2017-08-12 20:00:22 -04:00
|
|
|
it 'renders for note body', :js do
|
2016-08-27 13:36:08 -04:00
|
|
|
visit_issue(project, issue)
|
2015-05-04 23:06:57 -04:00
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
expect(page).to have_selector('.note ul.task-list', count: 1)
|
|
|
|
expect(page).to have_selector('.note li.task-list-item', count: 1)
|
|
|
|
expect(page).to have_selector('.note ul input[checked]', count: 0)
|
|
|
|
end
|
2015-05-04 23:06:57 -04:00
|
|
|
end
|
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
describe 'single complete task' do
|
|
|
|
let!(:note) do
|
|
|
|
create(:note, note: singleCompleteMarkdown, noteable: issue,
|
|
|
|
project: project, author: user)
|
|
|
|
end
|
2015-05-04 23:06:57 -04:00
|
|
|
|
2017-08-12 20:00:22 -04:00
|
|
|
it 'renders for note body', :js do
|
2016-08-27 13:36:08 -04:00
|
|
|
visit_issue(project, issue)
|
2015-05-04 23:06:57 -04:00
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
expect(page).to have_selector('.note ul.task-list', count: 1)
|
|
|
|
expect(page).to have_selector('.note li.task-list-item', count: 1)
|
|
|
|
expect(page).to have_selector('.note ul input[checked]', count: 1)
|
|
|
|
end
|
2015-05-04 23:06:57 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'for Merge Requests' do
|
|
|
|
def visit_merge_request(project, merge)
|
2017-06-29 13:06:35 -04:00
|
|
|
visit project_merge_request_path(project, merge)
|
2015-05-04 23:06:57 -04:00
|
|
|
end
|
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
describe 'multiple tasks' do
|
2017-03-28 17:13:16 -04:00
|
|
|
let(:project) { create(:project, :repository) }
|
2016-08-27 13:36:08 -04:00
|
|
|
let!(:merge) { create(:merge_request, :simple, description: markdown, author: user, source_project: project) }
|
2015-05-04 23:06:57 -04:00
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
it 'renders for description' do
|
|
|
|
visit_merge_request(project, merge)
|
2015-05-04 23:06:57 -04:00
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
expect(page).to have_selector('ul.task-list', count: 1)
|
|
|
|
expect(page).to have_selector('li.task-list-item', count: 6)
|
|
|
|
expect(page).to have_selector('ul input[checked]', count: 2)
|
|
|
|
end
|
2015-05-04 23:06:57 -04:00
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
it 'contains the required selectors' do
|
|
|
|
visit_merge_request(project, merge)
|
2015-05-04 23:06:57 -04:00
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
container = '.detail-page-description .description.js-task-list-container'
|
2015-05-04 23:06:57 -04:00
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
expect(page).to have_selector(container)
|
|
|
|
expect(page).to have_selector("#{container} .wiki .task-list .task-list-item .task-list-item-checkbox")
|
2017-08-12 20:00:22 -04:00
|
|
|
expect(page).to have_selector("#{container} .js-task-list-field")
|
2016-08-27 13:36:08 -04:00
|
|
|
expect(page).to have_selector('form.js-issuable-update')
|
|
|
|
expect(page).to have_selector('a.btn-close')
|
|
|
|
end
|
2015-05-04 23:06:57 -04:00
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
it 'is only editable by author' do
|
|
|
|
visit_merge_request(project, merge)
|
|
|
|
expect(page).to have_selector('.js-task-list-container')
|
2015-05-04 23:06:57 -04:00
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
logout(:user)
|
2015-05-04 23:06:57 -04:00
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
login_as(user2)
|
|
|
|
visit current_path
|
|
|
|
expect(page).not_to have_selector('.js-task-list-container')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'provides a summary on MergeRequests#index' do
|
2017-06-29 13:06:35 -04:00
|
|
|
visit project_merge_requests_path(project)
|
2016-08-27 13:36:08 -04:00
|
|
|
expect(page).to have_content("2 of 6 tasks completed")
|
|
|
|
end
|
|
|
|
end
|
2017-01-18 08:33:13 -05:00
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
describe 'single incomplete task' do
|
|
|
|
let!(:merge) { create(:merge_request, :simple, description: singleIncompleteMarkdown, author: user, source_project: project) }
|
|
|
|
|
|
|
|
it 'renders for description' do
|
|
|
|
visit_merge_request(project, merge)
|
|
|
|
|
|
|
|
expect(page).to have_selector('ul.task-list', count: 1)
|
|
|
|
expect(page).to have_selector('li.task-list-item', count: 1)
|
|
|
|
expect(page).to have_selector('ul input[checked]', count: 0)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'provides a summary on MergeRequests#index' do
|
2017-06-29 13:06:35 -04:00
|
|
|
visit project_merge_requests_path(project)
|
2016-08-27 13:36:08 -04:00
|
|
|
expect(page).to have_content("0 of 1 task completed")
|
|
|
|
end
|
2015-05-04 23:06:57 -04:00
|
|
|
end
|
|
|
|
|
2016-08-27 13:36:08 -04:00
|
|
|
describe 'single complete task' do
|
|
|
|
let!(:merge) { create(:merge_request, :simple, description: singleCompleteMarkdown, author: user, source_project: project) }
|
|
|
|
|
|
|
|
it 'renders for description' do
|
|
|
|
visit_merge_request(project, merge)
|
|
|
|
|
|
|
|
expect(page).to have_selector('ul.task-list', count: 1)
|
|
|
|
expect(page).to have_selector('li.task-list-item', count: 1)
|
|
|
|
expect(page).to have_selector('ul input[checked]', count: 1)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'provides a summary on MergeRequests#index' do
|
2017-06-29 13:06:35 -04:00
|
|
|
visit project_merge_requests_path(project)
|
2016-08-27 13:36:08 -04:00
|
|
|
expect(page).to have_content("1 of 1 task completed")
|
|
|
|
end
|
2015-05-04 23:06:57 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|