2011-10-08 21:36:38 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe Note do
|
|
|
|
describe "Associations" do
|
|
|
|
it { should belong_to(:project) }
|
2012-08-29 15:36:02 +00:00
|
|
|
it { should belong_to(:noteable) }
|
|
|
|
it { should belong_to(:author).class_name('User') }
|
2011-10-08 21:36:38 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
describe "Validation" do
|
|
|
|
it { should validate_presence_of(:note) }
|
|
|
|
it { should validate_presence_of(:project) }
|
|
|
|
end
|
|
|
|
|
2011-11-18 06:52:13 +00:00
|
|
|
describe "Scopes" do
|
|
|
|
it "should have a today named scope that returns ..." do
|
|
|
|
Note.today.where_values.should == ["created_at >= '#{Date.today}'"]
|
|
|
|
end
|
|
|
|
end
|
2012-01-21 12:54:32 +00:00
|
|
|
|
2012-03-14 13:31:31 +00:00
|
|
|
describe "Voting score" do
|
|
|
|
let(:project) { Factory(:project) }
|
|
|
|
|
|
|
|
it "recognizes a neutral note" do
|
2012-08-28 11:01:27 +00:00
|
|
|
note = Factory(:note, note: "This is not a +1 note")
|
2012-03-14 13:31:31 +00:00
|
|
|
note.should_not be_upvote
|
|
|
|
end
|
|
|
|
|
|
|
|
it "recognizes a +1 note" do
|
2012-08-28 11:01:27 +00:00
|
|
|
note = Factory(:note, note: "+1 for this")
|
2012-03-14 13:31:31 +00:00
|
|
|
note.should be_upvote
|
|
|
|
end
|
|
|
|
|
|
|
|
it "recognizes a -1 note as no vote" do
|
2012-08-28 11:01:27 +00:00
|
|
|
note = Factory(:note, note: "-1 for this")
|
2012-03-14 13:31:31 +00:00
|
|
|
note.should_not be_upvote
|
|
|
|
end
|
2012-09-06 19:31:25 +00:00
|
|
|
|
|
|
|
it "recognizes a +1 emoji as a vote" do
|
|
|
|
note = build(:note, note: ":+1: for this")
|
|
|
|
note.should be_upvote
|
|
|
|
end
|
|
|
|
|
|
|
|
it "recognizes a neutral emoji note" do
|
|
|
|
note = build(:note, note: "I would :+1: this, but I don't want to")
|
|
|
|
note.should_not be_upvote
|
|
|
|
end
|
2012-03-14 13:31:31 +00:00
|
|
|
end
|
|
|
|
|
2012-08-28 11:01:27 +00:00
|
|
|
let(:project) { create(:project) }
|
|
|
|
let(:commit) { project.commit }
|
2012-03-14 13:31:31 +00:00
|
|
|
|
2012-08-28 11:01:27 +00:00
|
|
|
describe "Commit notes" do
|
2012-03-14 13:31:31 +00:00
|
|
|
before do
|
2012-01-21 12:54:32 +00:00
|
|
|
@note = Factory :note,
|
2012-08-10 22:07:50 +00:00
|
|
|
noteable_id: commit.id,
|
|
|
|
noteable_type: "Commit"
|
2012-01-21 12:54:32 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it "should save a valid note" do
|
|
|
|
@note.noteable_id.should == commit.id
|
|
|
|
@note.target.id.should == commit.id
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2012-03-14 13:31:31 +00:00
|
|
|
describe "Pre-line commit notes" do
|
|
|
|
before do
|
2012-01-21 12:54:32 +00:00
|
|
|
@note = Factory :note,
|
2012-08-10 22:07:50 +00:00
|
|
|
noteable_id: commit.id,
|
|
|
|
noteable_type: "Commit",
|
|
|
|
line_code: "0_16_1"
|
2012-01-21 12:54:32 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it "should save a valid note" do
|
|
|
|
@note.noteable_id.should == commit.id
|
|
|
|
@note.target.id.should == commit.id
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2012-05-20 18:35:03 +00:00
|
|
|
describe '#create_status_change_note' do
|
|
|
|
let(:project) { Factory.create(:project) }
|
2012-08-10 22:07:50 +00:00
|
|
|
let(:thing) { Factory.create(:issue, project: project) }
|
2012-05-20 18:35:03 +00:00
|
|
|
let(:author) { Factory(:user) }
|
|
|
|
let(:status) { 'new_status' }
|
|
|
|
|
|
|
|
subject { Note.create_status_change_note(thing, author, status) }
|
|
|
|
|
|
|
|
it 'creates and saves a Note' do
|
|
|
|
should be_a Note
|
|
|
|
subject.id.should_not be_nil
|
|
|
|
end
|
|
|
|
|
|
|
|
its(:noteable) { should == thing }
|
|
|
|
its(:project) { should == thing.project }
|
|
|
|
its(:author) { should == author }
|
|
|
|
its(:note) { should =~ /Status changed to #{status}/ }
|
|
|
|
end
|
|
|
|
|
2011-10-26 13:46:25 +00:00
|
|
|
describe :authorization do
|
|
|
|
before do
|
2012-08-28 11:01:27 +00:00
|
|
|
@p1 = create(:project)
|
|
|
|
@p2 = Factory :project
|
2011-10-08 21:36:38 +00:00
|
|
|
@u1 = Factory :user
|
|
|
|
@u2 = Factory :user
|
|
|
|
@u3 = Factory :user
|
|
|
|
@abilities = Six.new
|
|
|
|
@abilities << Ability
|
|
|
|
end
|
|
|
|
|
2011-10-26 13:46:25 +00:00
|
|
|
describe :read do
|
|
|
|
before do
|
2012-08-10 22:07:50 +00:00
|
|
|
@p1.users_projects.create(user: @u2, project_access: UsersProject::GUEST)
|
|
|
|
@p2.users_projects.create(user: @u3, project_access: UsersProject::GUEST)
|
2011-10-08 21:36:38 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it { @abilities.allowed?(@u1, :read_note, @p1).should be_false }
|
|
|
|
it { @abilities.allowed?(@u2, :read_note, @p1).should be_true }
|
|
|
|
it { @abilities.allowed?(@u3, :read_note, @p1).should be_false }
|
|
|
|
end
|
|
|
|
|
2011-10-26 13:46:25 +00:00
|
|
|
describe :write do
|
|
|
|
before do
|
2012-08-10 22:07:50 +00:00
|
|
|
@p1.users_projects.create(user: @u2, project_access: UsersProject::DEVELOPER)
|
|
|
|
@p2.users_projects.create(user: @u3, project_access: UsersProject::DEVELOPER)
|
2011-10-08 21:36:38 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it { @abilities.allowed?(@u1, :write_note, @p1).should be_false }
|
|
|
|
it { @abilities.allowed?(@u2, :write_note, @p1).should be_true }
|
|
|
|
it { @abilities.allowed?(@u3, :write_note, @p1).should be_false }
|
|
|
|
end
|
|
|
|
|
2011-10-26 13:46:25 +00:00
|
|
|
describe :admin do
|
|
|
|
before do
|
2012-08-10 22:07:50 +00:00
|
|
|
@p1.users_projects.create(user: @u1, project_access: UsersProject::REPORTER)
|
|
|
|
@p1.users_projects.create(user: @u2, project_access: UsersProject::MASTER)
|
|
|
|
@p2.users_projects.create(user: @u3, project_access: UsersProject::MASTER)
|
2011-10-08 21:36:38 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it { @abilities.allowed?(@u1, :admin_note, @p1).should be_false }
|
|
|
|
it { @abilities.allowed?(@u2, :admin_note, @p1).should be_true }
|
|
|
|
it { @abilities.allowed?(@u3, :admin_note, @p1).should be_false }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|