2016-12-15 14:30:35 -05:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2017-07-10 10:24:02 -04:00
|
|
|
describe GroupPolicy do
|
2019-03-27 09:10:29 -04:00
|
|
|
include_context 'GroupPolicy context'
|
2017-04-06 17:09:58 -04:00
|
|
|
|
2016-12-15 14:30:35 -05:00
|
|
|
context 'with no user' do
|
2018-04-23 12:12:26 -04:00
|
|
|
let(:group) { create(:group, :public) }
|
2016-12-15 14:30:35 -05:00
|
|
|
let(:current_user) { nil }
|
|
|
|
|
|
|
|
it do
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_allowed(:read_group)
|
2017-12-06 06:36:11 -05:00
|
|
|
expect_disallowed(:upload_file)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_disallowed(*reporter_permissions)
|
2017-09-13 16:32:58 -04:00
|
|
|
expect_disallowed(*developer_permissions)
|
2018-07-11 10:36:08 -04:00
|
|
|
expect_disallowed(*maintainer_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_disallowed(*owner_permissions)
|
2017-11-27 15:26:50 -05:00
|
|
|
expect_disallowed(:read_namespace)
|
2016-12-15 14:30:35 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-02-11 06:53:58 -05:00
|
|
|
context 'with no user and public project' do
|
|
|
|
let(:project) { create(:project, :public) }
|
|
|
|
let(:current_user) { nil }
|
|
|
|
|
|
|
|
before do
|
2019-03-13 06:54:06 -04:00
|
|
|
create(:project_group_link, project: project, group: group)
|
2019-02-11 06:53:58 -05:00
|
|
|
end
|
|
|
|
|
2019-03-13 06:54:06 -04:00
|
|
|
it { expect_disallowed(:read_group) }
|
2019-02-11 06:53:58 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'with foreign user and public project' do
|
|
|
|
let(:project) { create(:project, :public) }
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:current_user) { create(:user) }
|
|
|
|
|
|
|
|
before do
|
2019-03-13 06:54:06 -04:00
|
|
|
create(:project_group_link, project: project, group: group)
|
2019-02-11 06:53:58 -05:00
|
|
|
end
|
|
|
|
|
2019-03-13 06:54:06 -04:00
|
|
|
it { expect_disallowed(:read_group) }
|
2019-02-11 06:53:58 -05:00
|
|
|
end
|
|
|
|
|
2018-04-23 12:12:26 -04:00
|
|
|
context 'has projects' do
|
|
|
|
let(:current_user) { create(:user) }
|
|
|
|
let(:project) { create(:project, namespace: group) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
project.add_developer(current_user)
|
|
|
|
end
|
|
|
|
|
2019-03-05 04:38:09 -05:00
|
|
|
it { expect_allowed(:read_label, :read_list) }
|
2018-04-23 12:12:26 -04:00
|
|
|
|
|
|
|
context 'in subgroups', :nested_groups do
|
|
|
|
let(:subgroup) { create(:group, :private, parent: group) }
|
|
|
|
let(:project) { create(:project, namespace: subgroup) }
|
|
|
|
|
2019-03-05 04:38:09 -05:00
|
|
|
it { expect_allowed(:read_label, :read_list) }
|
2018-04-23 12:12:26 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-12-15 14:30:35 -05:00
|
|
|
context 'guests' do
|
|
|
|
let(:current_user) { guest }
|
|
|
|
|
|
|
|
it do
|
2017-12-06 06:36:11 -05:00
|
|
|
expect_allowed(*guest_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_disallowed(*reporter_permissions)
|
2017-09-13 16:32:58 -04:00
|
|
|
expect_disallowed(*developer_permissions)
|
2018-07-11 10:36:08 -04:00
|
|
|
expect_disallowed(*maintainer_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_disallowed(*owner_permissions)
|
2016-12-15 14:30:35 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'reporter' do
|
|
|
|
let(:current_user) { reporter }
|
|
|
|
|
|
|
|
it do
|
2017-12-06 06:36:11 -05:00
|
|
|
expect_allowed(*guest_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_allowed(*reporter_permissions)
|
2017-09-13 16:32:58 -04:00
|
|
|
expect_disallowed(*developer_permissions)
|
2018-07-11 10:36:08 -04:00
|
|
|
expect_disallowed(*maintainer_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_disallowed(*owner_permissions)
|
2016-12-15 14:30:35 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'developer' do
|
|
|
|
let(:current_user) { developer }
|
|
|
|
|
|
|
|
it do
|
2017-12-06 06:36:11 -05:00
|
|
|
expect_allowed(*guest_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_allowed(*reporter_permissions)
|
2017-09-13 16:32:58 -04:00
|
|
|
expect_allowed(*developer_permissions)
|
2018-07-11 10:36:08 -04:00
|
|
|
expect_disallowed(*maintainer_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_disallowed(*owner_permissions)
|
2016-12-15 14:30:35 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-07-11 10:36:08 -04:00
|
|
|
context 'maintainer' do
|
|
|
|
let(:current_user) { maintainer }
|
2016-12-15 14:30:35 -05:00
|
|
|
|
|
|
|
it do
|
2017-12-06 06:36:11 -05:00
|
|
|
expect_allowed(*guest_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_allowed(*reporter_permissions)
|
2017-09-13 16:32:58 -04:00
|
|
|
expect_allowed(*developer_permissions)
|
2018-07-11 10:36:08 -04:00
|
|
|
expect_allowed(*maintainer_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_disallowed(*owner_permissions)
|
2016-12-15 14:30:35 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'owner' do
|
|
|
|
let(:current_user) { owner }
|
|
|
|
|
|
|
|
it do
|
2018-12-18 07:15:51 -05:00
|
|
|
allow(Group).to receive(:supports_nested_objects?).and_return(true)
|
2017-08-22 13:34:27 -04:00
|
|
|
|
2017-12-06 06:36:11 -05:00
|
|
|
expect_allowed(*guest_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_allowed(*reporter_permissions)
|
2017-09-13 16:32:58 -04:00
|
|
|
expect_allowed(*developer_permissions)
|
2018-07-11 10:36:08 -04:00
|
|
|
expect_allowed(*maintainer_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_allowed(*owner_permissions)
|
2016-12-15 14:30:35 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'admin' do
|
|
|
|
let(:current_user) { admin }
|
|
|
|
|
|
|
|
it do
|
2018-12-18 07:15:51 -05:00
|
|
|
allow(Group).to receive(:supports_nested_objects?).and_return(true)
|
2017-08-22 13:34:27 -04:00
|
|
|
|
2017-12-06 06:36:11 -05:00
|
|
|
expect_allowed(*guest_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_allowed(*reporter_permissions)
|
2017-09-13 16:32:58 -04:00
|
|
|
expect_allowed(*developer_permissions)
|
2018-07-11 10:36:08 -04:00
|
|
|
expect_allowed(*maintainer_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_allowed(*owner_permissions)
|
2016-12-15 14:30:35 -05:00
|
|
|
end
|
|
|
|
end
|
2016-12-13 13:59:39 -05:00
|
|
|
|
2017-08-09 06:58:00 -04:00
|
|
|
describe 'when nested group support feature is disabled' do
|
|
|
|
before do
|
2018-12-18 07:15:51 -05:00
|
|
|
allow(Group).to receive(:supports_nested_objects?).and_return(false)
|
2017-08-09 06:58:00 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'admin' do
|
|
|
|
let(:current_user) { admin }
|
|
|
|
|
|
|
|
it 'allows every owner permission except creating subgroups' do
|
|
|
|
create_subgroup_permission = [:create_subgroup]
|
|
|
|
updated_owner_permissions = owner_permissions - create_subgroup_permission
|
|
|
|
|
|
|
|
expect_disallowed(*create_subgroup_permission)
|
|
|
|
expect_allowed(*updated_owner_permissions)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'owner' do
|
|
|
|
let(:current_user) { owner }
|
|
|
|
|
|
|
|
it 'allows every owner permission except creating subgroups' do
|
|
|
|
create_subgroup_permission = [:create_subgroup]
|
|
|
|
updated_owner_permissions = owner_permissions - create_subgroup_permission
|
|
|
|
|
|
|
|
expect_disallowed(*create_subgroup_permission)
|
|
|
|
expect_allowed(*updated_owner_permissions)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-06-02 10:13:10 -04:00
|
|
|
describe 'private nested group use the highest access level from the group and inherited permissions', :nested_groups do
|
2016-12-13 13:59:39 -05:00
|
|
|
let(:nested_group) { create(:group, :private, parent: group) }
|
|
|
|
|
2017-06-02 10:13:10 -04:00
|
|
|
before do
|
|
|
|
nested_group.add_guest(guest)
|
|
|
|
nested_group.add_guest(reporter)
|
|
|
|
nested_group.add_guest(developer)
|
2018-07-11 10:36:08 -04:00
|
|
|
nested_group.add_guest(maintainer)
|
2017-06-02 10:13:10 -04:00
|
|
|
|
2018-08-16 08:46:40 -04:00
|
|
|
group.owners.destroy_all # rubocop: disable DestroyAll
|
2017-06-02 10:13:10 -04:00
|
|
|
|
|
|
|
group.add_guest(owner)
|
|
|
|
nested_group.add_owner(owner)
|
|
|
|
end
|
|
|
|
|
2017-04-06 17:09:58 -04:00
|
|
|
subject { described_class.new(current_user, nested_group) }
|
2016-12-13 13:59:39 -05:00
|
|
|
|
|
|
|
context 'with no user' do
|
|
|
|
let(:current_user) { nil }
|
|
|
|
|
|
|
|
it do
|
2017-12-06 06:36:11 -05:00
|
|
|
expect_disallowed(*guest_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_disallowed(*reporter_permissions)
|
2017-09-13 16:32:58 -04:00
|
|
|
expect_disallowed(*developer_permissions)
|
2018-07-11 10:36:08 -04:00
|
|
|
expect_disallowed(*maintainer_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_disallowed(*owner_permissions)
|
2016-12-13 13:59:39 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'guests' do
|
|
|
|
let(:current_user) { guest }
|
|
|
|
|
|
|
|
it do
|
2017-12-06 06:36:11 -05:00
|
|
|
expect_allowed(*guest_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_disallowed(*reporter_permissions)
|
2017-09-13 16:32:58 -04:00
|
|
|
expect_disallowed(*developer_permissions)
|
2018-07-11 10:36:08 -04:00
|
|
|
expect_disallowed(*maintainer_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_disallowed(*owner_permissions)
|
2016-12-13 13:59:39 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'reporter' do
|
|
|
|
let(:current_user) { reporter }
|
|
|
|
|
|
|
|
it do
|
2017-12-06 06:36:11 -05:00
|
|
|
expect_allowed(*guest_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_allowed(*reporter_permissions)
|
2017-09-13 16:32:58 -04:00
|
|
|
expect_disallowed(*developer_permissions)
|
2018-07-11 10:36:08 -04:00
|
|
|
expect_disallowed(*maintainer_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_disallowed(*owner_permissions)
|
2016-12-13 13:59:39 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'developer' do
|
|
|
|
let(:current_user) { developer }
|
|
|
|
|
|
|
|
it do
|
2017-12-06 06:36:11 -05:00
|
|
|
expect_allowed(*guest_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_allowed(*reporter_permissions)
|
2017-09-13 16:32:58 -04:00
|
|
|
expect_allowed(*developer_permissions)
|
2018-07-11 10:36:08 -04:00
|
|
|
expect_disallowed(*maintainer_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_disallowed(*owner_permissions)
|
2016-12-13 13:59:39 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-07-11 10:36:08 -04:00
|
|
|
context 'maintainer' do
|
|
|
|
let(:current_user) { maintainer }
|
2016-12-13 13:59:39 -05:00
|
|
|
|
|
|
|
it do
|
2017-12-06 06:36:11 -05:00
|
|
|
expect_allowed(*guest_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_allowed(*reporter_permissions)
|
2017-09-13 16:32:58 -04:00
|
|
|
expect_allowed(*developer_permissions)
|
2018-07-11 10:36:08 -04:00
|
|
|
expect_allowed(*maintainer_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_disallowed(*owner_permissions)
|
2016-12-13 13:59:39 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'owner' do
|
|
|
|
let(:current_user) { owner }
|
|
|
|
|
|
|
|
it do
|
2018-12-18 07:15:51 -05:00
|
|
|
allow(Group).to receive(:supports_nested_objects?).and_return(true)
|
2017-08-22 13:34:27 -04:00
|
|
|
|
2017-12-06 06:36:11 -05:00
|
|
|
expect_allowed(*guest_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_allowed(*reporter_permissions)
|
2017-09-13 16:32:58 -04:00
|
|
|
expect_allowed(*developer_permissions)
|
2018-07-11 10:36:08 -04:00
|
|
|
expect_allowed(*maintainer_permissions)
|
2017-04-06 17:09:58 -04:00
|
|
|
expect_allowed(*owner_permissions)
|
2016-12-13 13:59:39 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2017-09-01 21:00:46 -04:00
|
|
|
|
|
|
|
describe 'change_share_with_group_lock' do
|
2017-09-06 02:05:25 -04:00
|
|
|
context 'when the current_user owns the group' do
|
|
|
|
let(:current_user) { owner }
|
2017-09-01 21:00:46 -04:00
|
|
|
|
2017-09-06 02:05:25 -04:00
|
|
|
context 'when the group share_with_group_lock is enabled' do
|
|
|
|
let(:group) { create(:group, share_with_group_lock: true, parent: parent) }
|
2017-09-01 21:00:46 -04:00
|
|
|
|
2017-09-06 02:05:25 -04:00
|
|
|
context 'when the parent group share_with_group_lock is enabled' do
|
|
|
|
context 'when the group has a grandparent' do
|
|
|
|
let(:parent) { create(:group, share_with_group_lock: true, parent: grandparent) }
|
2017-09-01 21:00:46 -04:00
|
|
|
|
2017-09-06 02:05:25 -04:00
|
|
|
context 'when the grandparent share_with_group_lock is enabled' do
|
|
|
|
let(:grandparent) { create(:group, share_with_group_lock: true) }
|
|
|
|
|
|
|
|
context 'when the current_user owns the parent' do
|
|
|
|
before do
|
|
|
|
parent.add_owner(current_user)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the current_user owns the grandparent' do
|
|
|
|
before do
|
|
|
|
grandparent.add_owner(current_user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { expect_allowed(:change_share_with_group_lock) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the current_user does not own the grandparent' do
|
|
|
|
it { expect_disallowed(:change_share_with_group_lock) }
|
|
|
|
end
|
2017-09-05 13:38:24 -04:00
|
|
|
end
|
|
|
|
|
2017-09-06 02:05:25 -04:00
|
|
|
context 'when the current_user does not own the parent' do
|
|
|
|
it { expect_disallowed(:change_share_with_group_lock) }
|
|
|
|
end
|
2017-09-05 13:38:24 -04:00
|
|
|
end
|
|
|
|
|
2017-09-06 02:05:25 -04:00
|
|
|
context 'when the grandparent share_with_group_lock is disabled' do
|
|
|
|
let(:grandparent) { create(:group) }
|
|
|
|
|
|
|
|
context 'when the current_user owns the parent' do
|
|
|
|
before do
|
|
|
|
parent.add_owner(current_user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { expect_allowed(:change_share_with_group_lock) }
|
2017-09-05 13:38:24 -04:00
|
|
|
end
|
|
|
|
|
2017-09-06 02:05:25 -04:00
|
|
|
context 'when the current_user does not own the parent' do
|
|
|
|
it { expect_disallowed(:change_share_with_group_lock) }
|
|
|
|
end
|
2017-09-05 13:38:24 -04:00
|
|
|
end
|
|
|
|
end
|
2017-09-01 21:00:46 -04:00
|
|
|
|
2017-09-06 02:05:25 -04:00
|
|
|
context 'when the group does not have a grandparent' do
|
|
|
|
let(:parent) { create(:group, share_with_group_lock: true) }
|
2017-09-05 13:38:24 -04:00
|
|
|
|
2017-09-06 02:05:25 -04:00
|
|
|
context 'when the current_user owns the parent' do
|
|
|
|
before do
|
|
|
|
parent.add_owner(current_user)
|
|
|
|
end
|
2017-09-05 13:38:24 -04:00
|
|
|
|
2017-09-06 02:05:25 -04:00
|
|
|
it { expect_allowed(:change_share_with_group_lock) }
|
|
|
|
end
|
2017-09-05 13:38:24 -04:00
|
|
|
|
2017-09-06 02:05:25 -04:00
|
|
|
context 'when the current_user does not own the parent' do
|
|
|
|
it { expect_disallowed(:change_share_with_group_lock) }
|
|
|
|
end
|
2017-09-05 13:38:24 -04:00
|
|
|
end
|
2017-09-01 21:00:46 -04:00
|
|
|
end
|
|
|
|
|
2017-09-06 02:05:25 -04:00
|
|
|
context 'when the parent group share_with_group_lock is disabled' do
|
|
|
|
let(:parent) { create(:group) }
|
2017-09-01 21:00:46 -04:00
|
|
|
|
|
|
|
it { expect_allowed(:change_share_with_group_lock) }
|
|
|
|
end
|
2017-09-06 02:05:25 -04:00
|
|
|
end
|
2017-09-01 21:00:46 -04:00
|
|
|
|
2017-09-06 02:05:25 -04:00
|
|
|
context 'when the group share_with_group_lock is disabled' do
|
|
|
|
it { expect_allowed(:change_share_with_group_lock) }
|
2017-09-01 21:00:46 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-09-06 02:05:25 -04:00
|
|
|
context 'when the current_user does not own the group' do
|
|
|
|
let(:current_user) { create(:user) }
|
2017-09-01 21:00:46 -04:00
|
|
|
|
2017-09-06 02:05:25 -04:00
|
|
|
it { expect_disallowed(:change_share_with_group_lock) }
|
2017-09-01 21:00:46 -04:00
|
|
|
end
|
|
|
|
end
|
2018-12-04 16:38:15 -05:00
|
|
|
|
|
|
|
it_behaves_like 'clusterable policies' do
|
|
|
|
let(:clusterable) { create(:group) }
|
|
|
|
let(:cluster) do
|
|
|
|
create(:cluster,
|
|
|
|
:provided_by_gcp,
|
|
|
|
:group,
|
|
|
|
groups: [clusterable])
|
|
|
|
end
|
|
|
|
end
|
2016-12-15 14:30:35 -05:00
|
|
|
end
|