2019-03-30 07:23:56 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-06-14 11:51:12 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2017-07-10 14:24:02 +00:00
|
|
|
describe Deployment do
|
2016-06-14 11:51:12 +00:00
|
|
|
subject { build(:deployment) }
|
|
|
|
|
2019-05-21 21:07:37 +00:00
|
|
|
it { is_expected.to belong_to(:project).required }
|
|
|
|
it { is_expected.to belong_to(:environment).required }
|
2019-06-23 21:48:16 +00:00
|
|
|
it { is_expected.to belong_to(:cluster).class_name('Clusters::Cluster') }
|
2016-06-14 11:51:12 +00:00
|
|
|
it { is_expected.to belong_to(:user) }
|
|
|
|
it { is_expected.to belong_to(:deployable) }
|
|
|
|
|
|
|
|
it { is_expected.to delegate_method(:name).to(:environment).with_prefix }
|
|
|
|
it { is_expected.to delegate_method(:commit).to(:project) }
|
|
|
|
it { is_expected.to delegate_method(:commit_title).to(:commit).as(:try) }
|
2016-07-16 23:48:51 +00:00
|
|
|
it { is_expected.to delegate_method(:manual_actions).to(:deployable).as(:try) }
|
2016-06-14 11:51:12 +00:00
|
|
|
|
|
|
|
it { is_expected.to validate_presence_of(:ref) }
|
|
|
|
it { is_expected.to validate_presence_of(:sha) }
|
2016-08-03 11:37:39 +00:00
|
|
|
|
2018-12-03 13:01:30 +00:00
|
|
|
it_behaves_like 'having unique enum values'
|
2018-12-03 11:10:13 +00:00
|
|
|
|
2018-10-18 06:47:30 +00:00
|
|
|
describe '#scheduled_actions' do
|
|
|
|
subject { deployment.scheduled_actions }
|
|
|
|
|
|
|
|
let(:project) { create(:project, :repository) }
|
|
|
|
let(:pipeline) { create(:ci_pipeline, project: project) }
|
|
|
|
let(:build) { create(:ci_build, :success, pipeline: pipeline) }
|
|
|
|
let(:deployment) { create(:deployment, deployable: build) }
|
|
|
|
|
|
|
|
it 'delegates to other_scheduled_actions' do
|
|
|
|
expect_any_instance_of(Ci::Build)
|
|
|
|
.to receive(:other_scheduled_actions)
|
|
|
|
|
|
|
|
subject
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-04-20 14:00:15 +00:00
|
|
|
describe 'modules' do
|
|
|
|
it_behaves_like 'AtomicInternalId' do
|
|
|
|
let(:internal_id_attribute) { :iid }
|
|
|
|
let(:instance) { build(:deployment) }
|
2018-05-14 08:41:56 +00:00
|
|
|
let(:scope) { :project }
|
2018-04-20 14:00:15 +00:00
|
|
|
let(:scope_attrs) { { project: instance.project } }
|
|
|
|
let(:usage) { :deployments }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-11-05 00:37:40 +00:00
|
|
|
describe '.success' do
|
|
|
|
subject { described_class.success }
|
2017-05-23 08:43:55 +00:00
|
|
|
|
2018-11-05 00:37:40 +00:00
|
|
|
context 'when deployment status is success' do
|
|
|
|
let(:deployment) { create(:deployment, :success) }
|
2017-06-01 14:59:18 +00:00
|
|
|
|
2018-11-05 00:37:40 +00:00
|
|
|
it { is_expected.to eq([deployment]) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when deployment status is created' do
|
|
|
|
let(:deployment) { create(:deployment, :created) }
|
|
|
|
|
|
|
|
it { is_expected.to be_empty }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when deployment status is running' do
|
|
|
|
let(:deployment) { create(:deployment, :running) }
|
|
|
|
|
|
|
|
it { is_expected.to be_empty }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'state machine' do
|
|
|
|
context 'when deployment runs' do
|
|
|
|
let(:deployment) { create(:deployment) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
deployment.run!
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'starts running' do
|
|
|
|
Timecop.freeze do
|
|
|
|
expect(deployment).to be_running
|
|
|
|
expect(deployment.finished_at).to be_nil
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when deployment succeeded' do
|
|
|
|
let(:deployment) { create(:deployment, :running) }
|
|
|
|
|
|
|
|
it 'has correct status' do
|
|
|
|
Timecop.freeze do
|
|
|
|
deployment.succeed!
|
|
|
|
|
|
|
|
expect(deployment).to be_success
|
2018-11-06 20:11:34 +00:00
|
|
|
expect(deployment.finished_at).to be_like_time(Time.now)
|
2018-11-05 00:37:40 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'executes Deployments::SuccessWorker asynchronously' do
|
|
|
|
expect(Deployments::SuccessWorker)
|
|
|
|
.to receive(:perform_async).with(deployment.id)
|
|
|
|
|
|
|
|
deployment.succeed!
|
|
|
|
end
|
2019-04-26 21:08:41 +00:00
|
|
|
|
|
|
|
it 'executes Deployments::FinishedWorker asynchronously' do
|
|
|
|
expect(Deployments::FinishedWorker)
|
|
|
|
.to receive(:perform_async).with(deployment.id)
|
|
|
|
|
|
|
|
deployment.succeed!
|
|
|
|
end
|
2018-11-05 00:37:40 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when deployment failed' do
|
|
|
|
let(:deployment) { create(:deployment, :running) }
|
|
|
|
|
|
|
|
it 'has correct status' do
|
|
|
|
Timecop.freeze do
|
|
|
|
deployment.drop!
|
|
|
|
|
|
|
|
expect(deployment).to be_failed
|
2018-11-06 20:11:34 +00:00
|
|
|
expect(deployment.finished_at).to be_like_time(Time.now)
|
2018-11-05 00:37:40 +00:00
|
|
|
end
|
|
|
|
end
|
2019-04-26 21:08:41 +00:00
|
|
|
|
|
|
|
it 'executes Deployments::FinishedWorker asynchronously' do
|
|
|
|
expect(Deployments::FinishedWorker)
|
|
|
|
.to receive(:perform_async).with(deployment.id)
|
|
|
|
|
|
|
|
deployment.drop!
|
|
|
|
end
|
2018-11-05 00:37:40 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when deployment was canceled' do
|
|
|
|
let(:deployment) { create(:deployment, :running) }
|
|
|
|
|
|
|
|
it 'has correct status' do
|
|
|
|
Timecop.freeze do
|
|
|
|
deployment.cancel!
|
|
|
|
|
|
|
|
expect(deployment).to be_canceled
|
2018-11-06 20:11:34 +00:00
|
|
|
expect(deployment.finished_at).to be_like_time(Time.now)
|
2018-11-05 00:37:40 +00:00
|
|
|
end
|
|
|
|
end
|
2019-04-26 21:08:41 +00:00
|
|
|
|
|
|
|
it 'executes Deployments::FinishedWorker asynchronously' do
|
|
|
|
expect(Deployments::FinishedWorker)
|
|
|
|
.to receive(:perform_async).with(deployment.id)
|
|
|
|
|
|
|
|
deployment.cancel!
|
|
|
|
end
|
2018-11-05 00:37:40 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#success?' do
|
|
|
|
subject { deployment.success? }
|
|
|
|
|
|
|
|
context 'when deployment status is success' do
|
|
|
|
let(:deployment) { create(:deployment, :success) }
|
|
|
|
|
|
|
|
it { is_expected.to be_truthy }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when deployment status is failed' do
|
|
|
|
let(:deployment) { create(:deployment, :failed) }
|
|
|
|
|
|
|
|
it { is_expected.to be_falsy }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#status_name' do
|
|
|
|
subject { deployment.status_name }
|
|
|
|
|
|
|
|
context 'when deployment status is success' do
|
|
|
|
let(:deployment) { create(:deployment, :success) }
|
|
|
|
|
|
|
|
it { is_expected.to eq(:success) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when deployment status is failed' do
|
|
|
|
let(:deployment) { create(:deployment, :failed) }
|
|
|
|
|
|
|
|
it { is_expected.to eq(:failed) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#finished_at' do
|
|
|
|
subject { deployment.finished_at }
|
|
|
|
|
|
|
|
context 'when deployment status is created' do
|
|
|
|
let(:deployment) { create(:deployment) }
|
|
|
|
|
|
|
|
it { is_expected.to be_nil }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when deployment status is success' do
|
|
|
|
let(:deployment) { create(:deployment, :success) }
|
|
|
|
|
|
|
|
it { is_expected.to eq(deployment.read_attribute(:finished_at)) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when deployment status is success' do
|
|
|
|
let(:deployment) { create(:deployment, :success, finished_at: nil) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
deployment.update_column(:finished_at, nil)
|
|
|
|
end
|
|
|
|
|
|
|
|
it { is_expected.to eq(deployment.read_attribute(:created_at)) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when deployment status is running' do
|
|
|
|
let(:deployment) { create(:deployment, :running) }
|
|
|
|
|
|
|
|
it { is_expected.to be_nil }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#deployed_at' do
|
|
|
|
subject { deployment.deployed_at }
|
|
|
|
|
|
|
|
context 'when deployment status is created' do
|
|
|
|
let(:deployment) { create(:deployment) }
|
|
|
|
|
|
|
|
it { is_expected.to be_nil }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when deployment status is success' do
|
|
|
|
let(:deployment) { create(:deployment, :success) }
|
|
|
|
|
|
|
|
it { is_expected.to eq(deployment.read_attribute(:finished_at)) }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when deployment status is running' do
|
|
|
|
let(:deployment) { create(:deployment, :running) }
|
2017-06-01 14:59:18 +00:00
|
|
|
|
2018-11-05 00:37:40 +00:00
|
|
|
it { is_expected.to be_nil }
|
2017-05-23 08:43:55 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-10-12 14:10:34 +00:00
|
|
|
describe 'scopes' do
|
|
|
|
describe 'last_for_environment' do
|
|
|
|
let(:production) { create(:environment) }
|
|
|
|
let(:staging) { create(:environment) }
|
|
|
|
let(:testing) { create(:environment) }
|
|
|
|
|
|
|
|
let!(:deployments) do
|
|
|
|
[
|
|
|
|
create(:deployment, environment: production),
|
|
|
|
create(:deployment, environment: staging),
|
|
|
|
create(:deployment, environment: production)
|
|
|
|
]
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'retrieves last deployments for environments' do
|
|
|
|
last_deployments = described_class.last_for_environment([staging, production, testing])
|
|
|
|
|
|
|
|
expect(last_deployments.size).to eq(2)
|
2018-10-17 16:46:24 +00:00
|
|
|
expect(last_deployments).to match_array(deployments.last(2))
|
2018-10-12 14:10:34 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-08-09 13:11:14 +00:00
|
|
|
describe '#includes_commit?' do
|
2017-06-16 18:48:34 +00:00
|
|
|
let(:project) { create(:project, :repository) }
|
2016-08-03 11:37:39 +00:00
|
|
|
let(:environment) { create(:environment, project: project) }
|
|
|
|
let(:deployment) do
|
2016-08-09 13:11:14 +00:00
|
|
|
create(:deployment, environment: environment, sha: project.commit.id)
|
2016-08-03 11:37:39 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when there is no project commit' do
|
|
|
|
it 'returns false' do
|
2016-08-09 13:11:14 +00:00
|
|
|
commit = project.commit('feature')
|
|
|
|
|
|
|
|
expect(deployment.includes_commit?(commit)).to be false
|
2016-08-03 11:37:39 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when they share the same tree branch' do
|
|
|
|
it 'returns true' do
|
2016-08-09 13:11:14 +00:00
|
|
|
commit = project.commit
|
|
|
|
|
|
|
|
expect(deployment.includes_commit?(commit)).to be true
|
2016-08-03 11:37:39 +00:00
|
|
|
end
|
|
|
|
end
|
2016-10-13 13:19:52 +00:00
|
|
|
|
|
|
|
context 'when the SHA for the deployment does not exist in the repo' do
|
|
|
|
it 'returns false' do
|
|
|
|
deployment.update(sha: Gitlab::Git::BLANK_SHA)
|
|
|
|
commit = project.commit
|
|
|
|
|
|
|
|
expect(deployment.includes_commit?(commit)).to be false
|
|
|
|
end
|
|
|
|
end
|
2016-08-03 11:37:39 +00:00
|
|
|
end
|
2016-10-17 15:10:26 +00:00
|
|
|
|
|
|
|
describe '#stop_action' do
|
|
|
|
let(:build) { create(:ci_build) }
|
|
|
|
|
|
|
|
subject { deployment.stop_action }
|
|
|
|
|
|
|
|
context 'when no other actions' do
|
2017-12-14 00:13:44 +00:00
|
|
|
let(:deployment) { FactoryBot.build(:deployment, deployable: build) }
|
2016-10-17 15:10:26 +00:00
|
|
|
|
|
|
|
it { is_expected.to be_nil }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with other actions' do
|
2017-06-13 08:17:11 +00:00
|
|
|
let!(:close_action) { create(:ci_build, :manual, pipeline: build.pipeline, name: 'close_app') }
|
2016-10-17 15:10:26 +00:00
|
|
|
|
|
|
|
context 'when matching action is defined' do
|
2017-12-14 00:13:44 +00:00
|
|
|
let(:deployment) { FactoryBot.build(:deployment, deployable: build, on_stop: 'close_other_app') }
|
2016-10-17 15:10:26 +00:00
|
|
|
|
|
|
|
it { is_expected.to be_nil }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when no matching action is defined' do
|
2017-12-14 00:13:44 +00:00
|
|
|
let(:deployment) { FactoryBot.build(:deployment, deployable: build, on_stop: 'close_app') }
|
2016-10-17 15:10:26 +00:00
|
|
|
|
|
|
|
it { is_expected.to eq(close_action) }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2019-08-20 10:29:16 +00:00
|
|
|
|
|
|
|
describe '#deployed_by' do
|
|
|
|
it 'returns the deployment user if there is no deployable' do
|
|
|
|
deployment_user = create(:user)
|
|
|
|
deployment = create(:deployment, deployable: nil, user: deployment_user)
|
|
|
|
|
|
|
|
expect(deployment.deployed_by).to eq(deployment_user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns the deployment user if the deployable have no user' do
|
|
|
|
deployment_user = create(:user)
|
|
|
|
build = create(:ci_build, user: nil)
|
|
|
|
deployment = create(:deployment, deployable: build, user: deployment_user)
|
|
|
|
|
|
|
|
expect(deployment.deployed_by).to eq(deployment_user)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns the deployable user if there is one' do
|
|
|
|
build_user = create(:user)
|
|
|
|
deployment_user = create(:user)
|
|
|
|
build = create(:ci_build, user: build_user)
|
|
|
|
deployment = create(:deployment, deployable: build, user: deployment_user)
|
|
|
|
|
|
|
|
expect(deployment.deployed_by).to eq(build_user)
|
|
|
|
end
|
|
|
|
end
|
2019-10-16 18:08:01 +00:00
|
|
|
|
|
|
|
describe '.find_successful_deployment!' do
|
|
|
|
it 'returns a successful deployment' do
|
|
|
|
deploy = create(:deployment, :success)
|
|
|
|
|
|
|
|
expect(described_class.find_successful_deployment!(deploy.iid)).to eq(deploy)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'raises when no deployment is found' do
|
|
|
|
expect { described_class.find_successful_deployment!(-1) }
|
|
|
|
.to raise_error(ActiveRecord::RecordNotFound)
|
|
|
|
end
|
|
|
|
end
|
2016-06-14 11:51:12 +00:00
|
|
|
end
|