2019-10-11 18:06:15 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe Git::ProcessRefChangesService do
|
|
|
|
let(:project) { create(:project, :repository) }
|
|
|
|
let(:user) { project.owner }
|
|
|
|
let(:params) { { changes: git_changes } }
|
|
|
|
|
|
|
|
subject { described_class.new(project, user, params) }
|
|
|
|
|
|
|
|
shared_examples_for 'service for processing ref changes' do |push_service_class|
|
|
|
|
let(:service) { double(execute: true) }
|
|
|
|
let(:git_changes) { double(branch_changes: [], tag_changes: []) }
|
|
|
|
|
2019-10-17 12:07:33 +00:00
|
|
|
def multiple_changes(change, count)
|
|
|
|
Array.new(count).map.with_index do |n, index|
|
|
|
|
{ index: index, oldrev: change[:oldrev], newrev: change[:newrev], ref: "#{change[:ref]}#{n}" }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-10-11 18:06:15 +00:00
|
|
|
let(:changes) do
|
|
|
|
[
|
|
|
|
{ index: 0, oldrev: Gitlab::Git::BLANK_SHA, newrev: '789012', ref: "#{ref_prefix}/create" },
|
|
|
|
{ index: 1, oldrev: '123456', newrev: '789012', ref: "#{ref_prefix}/update" },
|
|
|
|
{ index: 2, oldrev: '123456', newrev: Gitlab::Git::BLANK_SHA, ref: "#{ref_prefix}/delete" }
|
|
|
|
]
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
allow(git_changes).to receive(changes_method).and_return(changes)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "calls #{push_service_class}" do
|
|
|
|
expect(push_service_class)
|
|
|
|
.to receive(:new)
|
2019-10-17 12:07:33 +00:00
|
|
|
.with(project, project.owner, hash_including(execute_project_hooks: true, create_push_event: true))
|
2019-10-11 18:06:15 +00:00
|
|
|
.exactly(changes.count).times
|
|
|
|
.and_return(service)
|
|
|
|
|
|
|
|
subject.execute
|
|
|
|
end
|
|
|
|
|
2019-10-16 18:08:01 +00:00
|
|
|
context 'changes exceed push_event_hooks_limit' do
|
|
|
|
let(:push_event_hooks_limit) { 3 }
|
|
|
|
|
|
|
|
let(:changes) do
|
|
|
|
multiple_changes(
|
|
|
|
{ oldrev: '123456', newrev: '789012', ref: "#{ref_prefix}/test" },
|
|
|
|
push_event_hooks_limit + 1
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
stub_application_setting(push_event_hooks_limit: push_event_hooks_limit)
|
|
|
|
end
|
|
|
|
|
2020-03-17 15:09:10 +00:00
|
|
|
it "calls #{push_service_class} with execute_project_hooks set to false" do
|
|
|
|
expect(push_service_class)
|
|
|
|
.to receive(:new)
|
|
|
|
.with(project, project.owner, hash_including(execute_project_hooks: false))
|
|
|
|
.exactly(changes.count).times
|
|
|
|
.and_return(service)
|
|
|
|
|
|
|
|
subject.execute
|
2019-10-16 18:08:01 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-10-17 12:07:33 +00:00
|
|
|
context 'changes exceed push_event_activities_limit per action' do
|
|
|
|
let(:push_event_activities_limit) { 3 }
|
|
|
|
|
|
|
|
let(:changes) do
|
|
|
|
[
|
|
|
|
{ oldrev: Gitlab::Git::BLANK_SHA, newrev: '789012', ref: "#{ref_prefix}/create" },
|
|
|
|
{ oldrev: '123456', newrev: '789012', ref: "#{ref_prefix}/update" },
|
|
|
|
{ oldrev: '123456', newrev: Gitlab::Git::BLANK_SHA, ref: "#{ref_prefix}/delete" }
|
|
|
|
].map do |change|
|
|
|
|
multiple_changes(change, push_event_activities_limit + 1)
|
|
|
|
end.flatten
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
stub_application_setting(push_event_activities_limit: push_event_activities_limit)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "calls #{push_service_class} with create_push_event set to false" do
|
|
|
|
expect(push_service_class)
|
|
|
|
.to receive(:new)
|
|
|
|
.with(project, project.owner, hash_including(create_push_event: false))
|
|
|
|
.exactly(changes.count).times
|
|
|
|
.and_return(service)
|
|
|
|
|
|
|
|
subject.execute
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'creates events per action' do
|
|
|
|
allow(push_service_class).to receive(:new).and_return(service)
|
|
|
|
|
|
|
|
expect { subject.execute }.to change { Event.count }.by(3)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-10-11 18:06:15 +00:00
|
|
|
context 'pipeline creation' do
|
|
|
|
context 'with valid .gitlab-ci.yml' do
|
|
|
|
before do
|
|
|
|
stub_ci_pipeline_to_return_yaml_file
|
|
|
|
|
|
|
|
allow_any_instance_of(Project)
|
|
|
|
.to receive(:commit)
|
|
|
|
.and_return(project.commit)
|
|
|
|
|
|
|
|
allow_any_instance_of(Repository)
|
|
|
|
.to receive(:branch_exists?)
|
|
|
|
.and_return(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when git_push_create_all_pipelines is disabled' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(git_push_create_all_pipelines: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'creates pipeline for branches and tags' do
|
|
|
|
subject.execute
|
|
|
|
|
|
|
|
expect(Ci::Pipeline.pluck(:ref)).to contain_exactly('create', 'update', 'delete')
|
|
|
|
end
|
|
|
|
|
|
|
|
it "creates exactly #{described_class::PIPELINE_PROCESS_LIMIT} pipelines" do
|
|
|
|
stub_const("#{described_class}::PIPELINE_PROCESS_LIMIT", changes.count - 1)
|
|
|
|
|
|
|
|
expect { subject.execute }.to change { Ci::Pipeline.count }.by(described_class::PIPELINE_PROCESS_LIMIT)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when git_push_create_all_pipelines is enabled' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(git_push_create_all_pipelines: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'creates all pipelines' do
|
|
|
|
expect { subject.execute }.to change { Ci::Pipeline.count }.by(changes.count)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with invalid .gitlab-ci.yml' do
|
|
|
|
before do
|
|
|
|
stub_ci_pipeline_yaml_file(nil)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not create a pipeline' do
|
|
|
|
expect { subject.execute }.not_to change { Ci::Pipeline.count }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'branch changes' do
|
|
|
|
let(:changes_method) { :branch_changes }
|
|
|
|
let(:ref_prefix) { 'refs/heads' }
|
|
|
|
|
|
|
|
it_behaves_like 'service for processing ref changes', Git::BranchPushService
|
2020-04-21 15:21:10 +00:00
|
|
|
|
|
|
|
context 'when there are merge requests associated with branches' do
|
|
|
|
let(:tag_changes) do
|
|
|
|
[
|
|
|
|
{ index: 0, oldrev: Gitlab::Git::BLANK_SHA, newrev: '789012', ref: "refs/tags/v10.0.0" }
|
|
|
|
]
|
|
|
|
end
|
|
|
|
let(:branch_changes) do
|
|
|
|
[
|
|
|
|
{ index: 0, oldrev: Gitlab::Git::BLANK_SHA, newrev: '789012', ref: "#{ref_prefix}/create1" },
|
|
|
|
{ index: 1, oldrev: Gitlab::Git::BLANK_SHA, newrev: '789013', ref: "#{ref_prefix}/create2" },
|
|
|
|
{ index: 2, oldrev: Gitlab::Git::BLANK_SHA, newrev: '789014', ref: "#{ref_prefix}/create3" }
|
|
|
|
]
|
|
|
|
end
|
|
|
|
let(:git_changes) { double(branch_changes: branch_changes, tag_changes: tag_changes) }
|
|
|
|
|
|
|
|
it 'schedules job for existing merge requests' do
|
|
|
|
expect_next_instance_of(MergeRequests::PushedBranchesService) do |service|
|
|
|
|
expect(service).to receive(:execute).and_return(%w(create1 create2))
|
|
|
|
end
|
|
|
|
|
|
|
|
expect(UpdateMergeRequestsWorker).to receive(:perform_async)
|
|
|
|
.with(project.id, user.id, Gitlab::Git::BLANK_SHA, '789012', "#{ref_prefix}/create1").ordered
|
|
|
|
expect(UpdateMergeRequestsWorker).to receive(:perform_async)
|
|
|
|
.with(project.id, user.id, Gitlab::Git::BLANK_SHA, '789013', "#{ref_prefix}/create2").ordered
|
|
|
|
expect(UpdateMergeRequestsWorker).not_to receive(:perform_async)
|
|
|
|
.with(project.id, user.id, Gitlab::Git::BLANK_SHA, '789014', "#{ref_prefix}/create3").ordered
|
|
|
|
|
|
|
|
subject.execute
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'refresh_only_existing_merge_requests_on_push disabled' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(refresh_only_existing_merge_requests_on_push: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'refreshes all merge requests' do
|
|
|
|
expect(UpdateMergeRequestsWorker).to receive(:perform_async).exactly(3).times
|
|
|
|
|
|
|
|
subject.execute
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2019-10-11 18:06:15 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'tag changes' do
|
|
|
|
let(:changes_method) { :tag_changes }
|
|
|
|
let(:ref_prefix) { 'refs/tags' }
|
|
|
|
|
|
|
|
it_behaves_like 'service for processing ref changes', Git::TagPushService
|
|
|
|
end
|
|
|
|
end
|