2016-06-22 17:04:51 -04:00
|
|
|
def storage_name_valid?(name)
|
|
|
|
!!(name =~ /\A[a-zA-Z0-9\-_]+\z/)
|
|
|
|
end
|
|
|
|
|
|
|
|
def find_parent_path(name, path)
|
2016-07-11 21:29:13 -04:00
|
|
|
parent = Pathname.new(path).realpath.parent
|
2017-02-28 16:08:40 -05:00
|
|
|
Gitlab.config.repositories.storages.detect do |n, rs|
|
2018-03-14 09:42:49 -04:00
|
|
|
name != n && Pathname.new(rs.legacy_disk_path).realpath == parent
|
2016-06-22 17:04:51 -04:00
|
|
|
end
|
2017-05-17 12:17:15 -04:00
|
|
|
rescue Errno::EIO, Errno::ENOENT => e
|
|
|
|
warning = "WARNING: couldn't verify #{path} (#{name}). "\
|
|
|
|
"If this is an external storage, it might be offline."
|
|
|
|
message = "#{warning}\n#{e.message}"
|
|
|
|
Rails.logger.error("#{message}\n\t" + e.backtrace.join("\n\t"))
|
|
|
|
|
|
|
|
nil
|
2016-06-22 17:04:51 -04:00
|
|
|
end
|
|
|
|
|
2016-07-11 21:29:13 -04:00
|
|
|
def storage_validation_error(message)
|
2016-06-22 17:04:51 -04:00
|
|
|
raise "#{message}. Please fix this in your gitlab.yml before starting GitLab."
|
|
|
|
end
|
|
|
|
|
2017-03-08 11:15:05 -05:00
|
|
|
def validate_storages_config
|
2016-07-18 17:28:26 -04:00
|
|
|
storage_validation_error('No repository storage path defined') if Gitlab.config.repositories.storages.empty?
|
2016-06-22 17:04:51 -04:00
|
|
|
|
2017-02-28 16:08:40 -05:00
|
|
|
Gitlab.config.repositories.storages.each do |name, repository_storage|
|
2016-07-18 17:28:26 -04:00
|
|
|
storage_validation_error("\"#{name}\" is not a valid storage name") unless storage_name_valid?(name)
|
2016-06-22 17:04:51 -04:00
|
|
|
|
2017-02-28 16:08:40 -05:00
|
|
|
if repository_storage.is_a?(String)
|
2017-03-08 11:15:05 -05:00
|
|
|
raise "#{name} is not a valid storage, because it has no `path` key. " \
|
2017-02-28 16:08:40 -05:00
|
|
|
"It may be configured as:\n\n#{name}:\n path: #{repository_storage}\n\n" \
|
2017-03-08 11:15:05 -05:00
|
|
|
"For source installations, update your config/gitlab.yml Refer to gitlab.yml.example for an updated example.\n\n" \
|
|
|
|
"If you're using the Gitlab Development Kit, you can update your configuration running `gdk reconfigure`.\n"
|
2017-02-28 16:08:40 -05:00
|
|
|
end
|
|
|
|
|
2018-03-14 09:42:49 -04:00
|
|
|
if !repository_storage.is_a?(Gitlab::GitalyClient::StorageSettings) || repository_storage.legacy_disk_path.nil?
|
2017-02-28 16:08:40 -05:00
|
|
|
storage_validation_error("#{name} is not a valid storage, because it has no `path` key. Refer to gitlab.yml.example for an updated example")
|
|
|
|
end
|
2017-05-17 12:17:15 -04:00
|
|
|
|
2017-08-13 08:52:44 -04:00
|
|
|
%w(failure_count_threshold failure_reset_time storage_timeout).each do |setting|
|
2017-05-17 12:17:15 -04:00
|
|
|
# Falling back to the defaults is fine!
|
|
|
|
next if repository_storage[setting].nil?
|
|
|
|
|
|
|
|
unless repository_storage[setting].to_f > 0
|
2017-08-13 08:52:44 -04:00
|
|
|
storage_validation_error("`#{setting}` for storage `#{name}` needs to be greater than 0")
|
2017-05-17 12:17:15 -04:00
|
|
|
end
|
|
|
|
end
|
2017-03-08 11:15:05 -05:00
|
|
|
end
|
|
|
|
end
|
2017-02-28 16:08:40 -05:00
|
|
|
|
2017-03-08 11:15:05 -05:00
|
|
|
def validate_storages_paths
|
|
|
|
Gitlab.config.repositories.storages.each do |name, repository_storage|
|
2018-03-14 09:42:49 -04:00
|
|
|
parent_name, _parent_path = find_parent_path(name, repository_storage.legacy_disk_path)
|
2016-07-18 17:28:26 -04:00
|
|
|
if parent_name
|
|
|
|
storage_validation_error("#{name} is a nested path of #{parent_name}. Nested paths are not supported for repository storages")
|
|
|
|
end
|
2016-06-22 17:04:51 -04:00
|
|
|
end
|
|
|
|
end
|
2016-07-18 17:28:26 -04:00
|
|
|
|
2017-03-08 11:15:05 -05:00
|
|
|
validate_storages_config
|
|
|
|
validate_storages_paths unless Rails.env.test? || ENV['SKIP_STORAGE_VALIDATION'] == 'true'
|