2016-12-20 09:53:53 -05:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe Projects::PipelinesController do
|
2017-05-06 12:45:46 -04:00
|
|
|
include ApiHelpers
|
|
|
|
|
2017-10-12 04:39:11 -04:00
|
|
|
set(:user) { create(:user) }
|
2018-06-26 12:31:05 -04:00
|
|
|
let(:project) { create(:project, :public, :repository) }
|
2019-01-28 07:12:30 -05:00
|
|
|
let(:feature) { ProjectFeature::ENABLED }
|
2016-12-20 09:53:53 -05:00
|
|
|
|
|
|
|
before do
|
2017-07-18 10:32:34 -04:00
|
|
|
stub_not_protect_default_branch
|
|
|
|
project.add_developer(user)
|
2017-10-12 04:39:11 -04:00
|
|
|
project.project_feature.update(builds_access_level: feature)
|
2017-05-04 15:01:15 -04:00
|
|
|
|
2016-12-20 09:53:53 -05:00
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
2016-12-21 09:13:24 -05:00
|
|
|
describe 'GET index.json' do
|
|
|
|
before do
|
2018-05-29 11:19:39 -04:00
|
|
|
%w(pending running success failed canceled).each_with_index do |status, index|
|
2018-05-22 08:38:25 -04:00
|
|
|
create_pipeline(status, project.commit("HEAD~#{index}"))
|
|
|
|
end
|
2016-12-21 09:13:24 -05:00
|
|
|
end
|
|
|
|
|
2018-05-29 11:19:39 -04:00
|
|
|
context 'when using persisted stages', :request_store do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(ci_pipeline_persisted_stages: true)
|
2018-05-22 06:30:45 -04:00
|
|
|
end
|
2017-10-12 04:39:11 -04:00
|
|
|
|
2018-05-29 11:19:39 -04:00
|
|
|
it 'returns serialized pipelines', :request_store do
|
2019-03-29 12:23:51 -04:00
|
|
|
expect(::Gitlab::GitalyClient).to receive(:allow_ref_name_caching).and_call_original
|
|
|
|
|
2018-05-29 11:19:39 -04:00
|
|
|
queries = ActiveRecord::QueryRecorder.new do
|
|
|
|
get_pipelines_index_json
|
|
|
|
end
|
2016-12-21 09:13:24 -05:00
|
|
|
|
2018-05-29 11:19:39 -04:00
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
expect(response).to match_response_schema('pipeline')
|
|
|
|
|
|
|
|
expect(json_response).to include('pipelines')
|
|
|
|
expect(json_response['pipelines'].count).to eq 5
|
|
|
|
expect(json_response['count']['all']).to eq '5'
|
|
|
|
expect(json_response['count']['running']).to eq '1'
|
|
|
|
expect(json_response['count']['pending']).to eq '1'
|
|
|
|
expect(json_response['count']['finished']).to eq '3'
|
|
|
|
|
|
|
|
json_response.dig('pipelines', 0, 'details', 'stages').tap do |stages|
|
|
|
|
expect(stages.count).to eq 3
|
|
|
|
end
|
|
|
|
|
|
|
|
expect(queries.count).to be
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-01-16 07:09:29 -05:00
|
|
|
context 'when using legacy stages', :request_store do
|
2018-05-29 11:19:39 -04:00
|
|
|
before do
|
|
|
|
stub_feature_flags(ci_pipeline_persisted_stages: false)
|
|
|
|
end
|
|
|
|
|
2018-07-02 11:09:49 -04:00
|
|
|
it 'returns JSON with serialized pipelines' do
|
|
|
|
get_pipelines_index_json
|
2018-05-29 11:19:39 -04:00
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
expect(response).to match_response_schema('pipeline')
|
|
|
|
|
|
|
|
expect(json_response).to include('pipelines')
|
|
|
|
expect(json_response['pipelines'].count).to eq 5
|
|
|
|
expect(json_response['count']['all']).to eq '5'
|
|
|
|
expect(json_response['count']['running']).to eq '1'
|
|
|
|
expect(json_response['count']['pending']).to eq '1'
|
|
|
|
expect(json_response['count']['finished']).to eq '3'
|
|
|
|
|
|
|
|
json_response.dig('pipelines', 0, 'details', 'stages').tap do |stages|
|
|
|
|
expect(stages.count).to eq 3
|
|
|
|
end
|
2018-07-02 11:09:49 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not execute N+1 queries' do
|
|
|
|
queries = ActiveRecord::QueryRecorder.new do
|
|
|
|
get_pipelines_index_json
|
|
|
|
end
|
2018-05-29 11:19:39 -04:00
|
|
|
|
2018-07-02 11:09:49 -04:00
|
|
|
expect(queries.count).to be <= 36
|
2018-05-29 11:19:39 -04:00
|
|
|
end
|
2016-12-21 09:13:24 -05:00
|
|
|
end
|
2017-10-12 04:39:11 -04:00
|
|
|
|
2018-05-11 10:17:03 -04:00
|
|
|
it 'does not include coverage data for the pipelines' do
|
2018-05-21 05:39:46 -04:00
|
|
|
get_pipelines_index_json
|
2018-05-11 10:17:03 -04:00
|
|
|
|
|
|
|
expect(json_response['pipelines'][0]).not_to include('coverage')
|
|
|
|
end
|
|
|
|
|
2017-10-12 04:39:11 -04:00
|
|
|
context 'when performing gitaly calls', :request_store do
|
|
|
|
it 'limits the Gitaly requests' do
|
2018-09-25 13:12:51 -04:00
|
|
|
# Isolate from test preparation (Repository#exists? is also cached in RequestStore)
|
|
|
|
RequestStore.end!
|
|
|
|
RequestStore.clear!
|
|
|
|
RequestStore.begin!
|
|
|
|
|
2019-04-04 16:22:11 -04:00
|
|
|
expect(::Gitlab::GitalyClient).to receive(:allow_ref_name_caching).and_call_original
|
|
|
|
|
2018-05-21 05:39:46 -04:00
|
|
|
expect { get_pipelines_index_json }
|
|
|
|
.to change { Gitlab::GitalyClient.get_request_count }.by(2)
|
2017-10-12 04:39:11 -04:00
|
|
|
end
|
|
|
|
end
|
2018-05-21 05:39:46 -04:00
|
|
|
|
2018-06-26 12:31:05 -04:00
|
|
|
context 'when the project is private' do
|
|
|
|
let(:project) { create(:project, :private, :repository) }
|
|
|
|
|
|
|
|
it 'returns `not_found` when the user does not have access' do
|
|
|
|
sign_in(create(:user))
|
|
|
|
|
|
|
|
get_pipelines_index_json
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns the pipelines when the user has access' do
|
|
|
|
get_pipelines_index_json
|
|
|
|
|
|
|
|
expect(json_response['pipelines'].size).to eq(5)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-05-21 05:39:46 -04:00
|
|
|
def get_pipelines_index_json
|
2018-12-17 17:52:17 -05:00
|
|
|
get :index, params: {
|
|
|
|
namespace_id: project.namespace,
|
|
|
|
project_id: project
|
|
|
|
},
|
2018-05-21 05:39:46 -04:00
|
|
|
format: :json
|
|
|
|
end
|
|
|
|
|
2018-05-22 06:30:45 -04:00
|
|
|
def create_pipeline(status, sha)
|
|
|
|
pipeline = create(:ci_empty_pipeline, status: status,
|
|
|
|
project: project,
|
|
|
|
sha: sha)
|
|
|
|
|
|
|
|
create_build(pipeline, 'build', 1, 'build')
|
|
|
|
create_build(pipeline, 'test', 2, 'test')
|
|
|
|
create_build(pipeline, 'deploy', 3, 'deploy')
|
|
|
|
end
|
|
|
|
|
2018-05-21 05:39:46 -04:00
|
|
|
def create_build(pipeline, stage, stage_idx, name)
|
2018-05-22 06:30:45 -04:00
|
|
|
status = %w[created running pending success failed canceled].sample
|
|
|
|
create(:ci_build, pipeline: pipeline, stage: stage, stage_idx: stage_idx, name: name, status: status)
|
2018-05-21 05:39:46 -04:00
|
|
|
end
|
2016-12-21 09:13:24 -05:00
|
|
|
end
|
|
|
|
|
2018-05-21 05:39:46 -04:00
|
|
|
describe 'GET show.json' do
|
2017-05-10 12:39:17 -04:00
|
|
|
let(:pipeline) { create(:ci_pipeline_with_one_job, project: project) }
|
2017-05-06 12:45:46 -04:00
|
|
|
|
|
|
|
it 'returns the pipeline' do
|
|
|
|
get_pipeline_json
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
2017-05-06 12:45:46 -04:00
|
|
|
expect(json_response).not_to be_an(Array)
|
|
|
|
expect(json_response['id']).to be(pipeline.id)
|
|
|
|
expect(json_response['details']).to have_key 'stages'
|
|
|
|
end
|
|
|
|
|
2017-06-09 13:12:51 -04:00
|
|
|
context 'when the pipeline has multiple stages and groups', :request_store do
|
2018-05-21 05:39:46 -04:00
|
|
|
let(:project) { create(:project, :repository) }
|
|
|
|
|
|
|
|
let(:pipeline) do
|
|
|
|
create(:ci_empty_pipeline, project: project,
|
|
|
|
user: user,
|
|
|
|
sha: project.commit.id)
|
|
|
|
end
|
|
|
|
|
2017-05-10 12:39:17 -04:00
|
|
|
before do
|
|
|
|
create_build('build', 0, 'build')
|
|
|
|
create_build('test', 1, 'rspec 0')
|
|
|
|
create_build('deploy', 2, 'production')
|
|
|
|
create_build('post deploy', 3, 'pages 0')
|
|
|
|
end
|
|
|
|
|
2017-05-06 12:45:46 -04:00
|
|
|
it 'does not perform N + 1 queries' do
|
|
|
|
control_count = ActiveRecord::QueryRecorder.new { get_pipeline_json }.count
|
|
|
|
|
2017-05-10 12:39:17 -04:00
|
|
|
create_build('test', 1, 'rspec 1')
|
|
|
|
create_build('test', 1, 'spinach 0')
|
|
|
|
create_build('test', 1, 'spinach 1')
|
|
|
|
create_build('test', 1, 'audit')
|
|
|
|
create_build('post deploy', 3, 'pages 1')
|
|
|
|
create_build('post deploy', 3, 'pages 2')
|
2017-05-06 12:45:46 -04:00
|
|
|
|
2017-05-10 12:39:17 -04:00
|
|
|
new_count = ActiveRecord::QueryRecorder.new { get_pipeline_json }.count
|
2018-05-21 05:39:46 -04:00
|
|
|
|
2017-05-10 12:39:17 -04:00
|
|
|
expect(new_count).to be_within(12).of(control_count)
|
2017-05-06 12:45:46 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-01-28 07:12:30 -05:00
|
|
|
context 'when builds are disabled' do
|
|
|
|
let(:feature) { ProjectFeature::DISABLED }
|
|
|
|
|
|
|
|
it 'users can not see internal pipelines' do
|
|
|
|
get_pipeline_json
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when pipeline is external' do
|
|
|
|
let(:pipeline) { create(:ci_pipeline, source: :external, project: project) }
|
|
|
|
|
|
|
|
it 'users can see the external pipeline' do
|
|
|
|
get_pipeline_json
|
|
|
|
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
expect(json_response['id']).to be(pipeline.id)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-05-06 12:45:46 -04:00
|
|
|
def get_pipeline_json
|
2018-12-17 17:52:17 -05:00
|
|
|
get :show, params: { namespace_id: project.namespace, project_id: project, id: pipeline }, format: :json
|
2017-05-06 12:45:46 -04:00
|
|
|
end
|
2017-05-10 12:39:17 -04:00
|
|
|
|
|
|
|
def create_build(stage, stage_idx, name)
|
|
|
|
create(:ci_build, pipeline: pipeline, stage: stage, stage_idx: stage_idx, name: name)
|
|
|
|
end
|
2017-05-06 12:45:46 -04:00
|
|
|
end
|
|
|
|
|
2016-12-20 09:53:53 -05:00
|
|
|
describe 'GET stages.json' do
|
2016-12-21 09:13:24 -05:00
|
|
|
let(:pipeline) { create(:ci_pipeline, project: project) }
|
|
|
|
|
2016-12-20 09:53:53 -05:00
|
|
|
context 'when accessing existing stage' do
|
|
|
|
before do
|
2018-09-06 06:21:58 -04:00
|
|
|
create(:ci_build, :retried, :failed, pipeline: pipeline, stage: 'build')
|
2016-12-20 09:53:53 -05:00
|
|
|
create(:ci_build, pipeline: pipeline, stage: 'build')
|
2018-09-06 06:21:58 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'without retried' do
|
|
|
|
before do
|
|
|
|
get_stage('build')
|
|
|
|
end
|
2016-12-20 09:53:53 -05:00
|
|
|
|
2018-09-06 06:21:58 -04:00
|
|
|
it 'returns pipeline jobs without the retried builds' do
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
expect(response).to match_response_schema('pipeline_stage')
|
|
|
|
expect(json_response['latest_statuses'].length).to eq 1
|
|
|
|
expect(json_response).not_to have_key('retried')
|
|
|
|
end
|
2016-12-20 09:53:53 -05:00
|
|
|
end
|
|
|
|
|
2018-09-06 06:21:58 -04:00
|
|
|
context 'with retried' do
|
|
|
|
before do
|
|
|
|
get_stage('build', retried: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns pipelines jobs with the retried builds' do
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
expect(response).to match_response_schema('pipeline_stage')
|
|
|
|
expect(json_response['latest_statuses'].length).to eq 1
|
|
|
|
expect(json_response['retried'].length).to eq 1
|
|
|
|
end
|
2016-12-20 09:53:53 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when accessing unknown stage' do
|
|
|
|
before do
|
|
|
|
get_stage('test')
|
|
|
|
end
|
|
|
|
|
2016-12-20 14:07:34 -05:00
|
|
|
it 'responds with not found' do
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2016-12-20 14:07:34 -05:00
|
|
|
end
|
2016-12-20 09:53:53 -05:00
|
|
|
end
|
|
|
|
|
2018-09-06 06:21:58 -04:00
|
|
|
def get_stage(name, params = {})
|
2018-12-17 17:52:17 -05:00
|
|
|
get :stage, params: {
|
|
|
|
**params.merge(
|
|
|
|
namespace_id: project.namespace,
|
|
|
|
project_id: project,
|
|
|
|
id: pipeline.id,
|
|
|
|
stage: name,
|
|
|
|
format: :json)
|
|
|
|
}
|
2016-12-20 14:07:34 -05:00
|
|
|
end
|
2016-12-20 09:53:53 -05:00
|
|
|
end
|
2017-03-06 07:01:18 -05:00
|
|
|
|
2018-05-01 17:56:33 -04:00
|
|
|
describe 'GET stages_ajax.json' do
|
|
|
|
let(:pipeline) { create(:ci_pipeline, project: project) }
|
|
|
|
|
|
|
|
context 'when accessing existing stage' do
|
|
|
|
before do
|
|
|
|
create(:ci_build, pipeline: pipeline, stage: 'build')
|
|
|
|
|
|
|
|
get_stage_ajax('build')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns html source for stage dropdown' do
|
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
|
|
|
expect(response).to render_template('projects/pipelines/_stage')
|
|
|
|
expect(json_response).to include('html')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when accessing unknown stage' do
|
|
|
|
before do
|
|
|
|
get_stage_ajax('test')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'responds with not found' do
|
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def get_stage_ajax(name)
|
2018-12-17 17:52:17 -05:00
|
|
|
get :stage_ajax, params: {
|
|
|
|
namespace_id: project.namespace,
|
|
|
|
project_id: project,
|
|
|
|
id: pipeline.id,
|
|
|
|
stage: name
|
|
|
|
},
|
2018-05-02 12:00:12 -04:00
|
|
|
format: :json
|
2018-05-01 17:56:33 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-03-06 07:01:18 -05:00
|
|
|
describe 'GET status.json' do
|
2017-03-21 09:21:13 -04:00
|
|
|
let(:pipeline) { create(:ci_pipeline, project: project) }
|
|
|
|
let(:status) { pipeline.detailed_status(double('user')) }
|
2017-03-10 12:44:41 -05:00
|
|
|
|
2017-03-21 09:21:13 -04:00
|
|
|
before do
|
2018-12-17 17:52:17 -05:00
|
|
|
get :status, params: {
|
|
|
|
namespace_id: project.namespace,
|
|
|
|
project_id: project,
|
|
|
|
id: pipeline.id
|
|
|
|
},
|
2017-03-21 09:21:13 -04:00
|
|
|
format: :json
|
|
|
|
end
|
2017-03-06 07:01:18 -05:00
|
|
|
|
2017-03-21 09:21:13 -04:00
|
|
|
it 'return a detailed pipeline status in json' do
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(:ok)
|
2017-03-21 09:21:13 -04:00
|
|
|
expect(json_response['text']).to eq status.text
|
|
|
|
expect(json_response['label']).to eq status.label
|
|
|
|
expect(json_response['icon']).to eq status.icon
|
2017-12-07 07:15:49 -05:00
|
|
|
expect(json_response['favicon']).to match_asset_path("/assets/ci_favicons/#{status.favicon}.png")
|
2017-03-06 07:01:18 -05:00
|
|
|
end
|
|
|
|
end
|
2017-05-04 15:01:15 -04:00
|
|
|
|
|
|
|
describe 'POST retry.json' do
|
|
|
|
let!(:pipeline) { create(:ci_pipeline, :failed, project: project) }
|
|
|
|
let!(:build) { create(:ci_build, :failed, pipeline: pipeline) }
|
|
|
|
|
|
|
|
before do
|
2018-12-17 17:52:17 -05:00
|
|
|
post :retry, params: {
|
|
|
|
namespace_id: project.namespace,
|
|
|
|
project_id: project,
|
|
|
|
id: pipeline.id
|
|
|
|
},
|
2017-05-04 15:01:15 -04:00
|
|
|
format: :json
|
|
|
|
end
|
|
|
|
|
2019-01-28 07:12:30 -05:00
|
|
|
it 'retries a pipeline without returning any content' do
|
|
|
|
expect(response).to have_gitlab_http_status(:no_content)
|
|
|
|
expect(build.reload).to be_retried
|
2017-06-07 06:32:16 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when builds are disabled' do
|
2019-01-28 07:12:30 -05:00
|
|
|
let(:feature) { ProjectFeature::DISABLED }
|
|
|
|
|
2017-06-07 06:32:16 -04:00
|
|
|
it 'fails to retry pipeline' do
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2017-06-07 06:32:16 -04:00
|
|
|
end
|
2017-05-04 15:01:15 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'POST cancel.json' do
|
|
|
|
let!(:pipeline) { create(:ci_pipeline, project: project) }
|
|
|
|
let!(:build) { create(:ci_build, :running, pipeline: pipeline) }
|
2017-07-03 17:58:28 -04:00
|
|
|
|
2017-05-04 15:01:15 -04:00
|
|
|
before do
|
2018-12-17 17:52:17 -05:00
|
|
|
post :cancel, params: {
|
|
|
|
namespace_id: project.namespace,
|
|
|
|
project_id: project,
|
|
|
|
id: pipeline.id
|
|
|
|
},
|
2017-05-04 15:01:15 -04:00
|
|
|
format: :json
|
|
|
|
end
|
|
|
|
|
2019-01-28 07:12:30 -05:00
|
|
|
it 'cancels a pipeline without returning any content' do
|
|
|
|
expect(response).to have_gitlab_http_status(:no_content)
|
|
|
|
expect(pipeline.reload).to be_canceled
|
2017-06-07 06:32:16 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when builds are disabled' do
|
2019-01-28 07:12:30 -05:00
|
|
|
let(:feature) { ProjectFeature::DISABLED }
|
|
|
|
|
2017-06-07 06:32:16 -04:00
|
|
|
it 'fails to retry pipeline' do
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(:not_found)
|
2017-06-07 06:32:16 -04:00
|
|
|
end
|
2017-05-04 15:01:15 -04:00
|
|
|
end
|
|
|
|
end
|
2016-12-20 09:53:53 -05:00
|
|
|
end
|