2021-06-15 14:09:57 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
module Gitlab
|
|
|
|
module Checks
|
|
|
|
class ChangesAccess
|
2022-05-10 20:08:02 -04:00
|
|
|
include Gitlab::Utils::StrongMemoize
|
|
|
|
|
2021-06-15 14:09:57 -04:00
|
|
|
ATTRIBUTES = %i[user_access project protocol changes logger].freeze
|
|
|
|
|
|
|
|
attr_reader(*ATTRIBUTES)
|
|
|
|
|
|
|
|
def initialize(
|
|
|
|
changes, user_access:, project:, protocol:, logger:
|
|
|
|
)
|
|
|
|
@changes = changes
|
|
|
|
@user_access = user_access
|
|
|
|
@project = project
|
|
|
|
@protocol = protocol
|
|
|
|
@logger = logger
|
|
|
|
end
|
|
|
|
|
|
|
|
def validate!
|
|
|
|
return if changes.empty?
|
|
|
|
|
|
|
|
single_access_checks!
|
|
|
|
|
|
|
|
logger.log_timed("Running checks for #{changes.length} changes") do
|
|
|
|
bulk_access_checks!
|
|
|
|
end
|
|
|
|
|
|
|
|
true
|
|
|
|
end
|
|
|
|
|
2021-07-29 08:08:55 -04:00
|
|
|
# All commits which have been newly introduced via any of the given
|
|
|
|
# changes. This set may also contain commits which are not referenced by
|
|
|
|
# any of the new revisions.
|
|
|
|
def commits
|
2022-05-10 20:08:02 -04:00
|
|
|
strong_memoize(:commits) do
|
|
|
|
allow_quarantine = true
|
|
|
|
|
|
|
|
newrevs = @changes.map do |change|
|
|
|
|
oldrev = change[:oldrev]
|
|
|
|
newrev = change[:newrev]
|
2022-01-05 07:16:26 -05:00
|
|
|
|
2022-05-10 20:08:02 -04:00
|
|
|
next if blank_rev?(newrev)
|
2022-01-05 07:16:26 -05:00
|
|
|
|
2022-05-10 20:08:02 -04:00
|
|
|
# In case any of the old revisions is blank, then we cannot reliably
|
|
|
|
# detect which commits are new for a given change when enumerating
|
|
|
|
# objects via the object quarantine directory given that the client
|
|
|
|
# may have pushed too many commits, and we don't know when to
|
|
|
|
# terminate the walk. We thus fall back to using `git rev-list --not
|
|
|
|
# --all`, which is a lot less efficient but at least can only ever
|
|
|
|
# returns commits which really are new.
|
|
|
|
allow_quarantine = false if allow_quarantine && blank_rev?(oldrev)
|
2022-01-05 07:16:26 -05:00
|
|
|
|
2022-05-10 20:08:02 -04:00
|
|
|
newrev
|
|
|
|
end.compact
|
2022-01-05 07:16:26 -05:00
|
|
|
|
2022-05-10 20:08:02 -04:00
|
|
|
next [] if newrevs.empty?
|
2021-07-29 08:08:55 -04:00
|
|
|
|
2022-05-10 20:08:02 -04:00
|
|
|
# When filtering quarantined commits we can enable usage of the object
|
|
|
|
# quarantine no matter whether we have an `oldrev` or not.
|
|
|
|
if Feature.enabled?(:filter_quarantined_commits)
|
|
|
|
allow_quarantine = true
|
|
|
|
end
|
2021-07-29 08:08:55 -04:00
|
|
|
|
2022-05-10 20:08:02 -04:00
|
|
|
project.repository.new_commits(newrevs, allow_quarantine: allow_quarantine)
|
|
|
|
end
|
2021-07-29 08:08:55 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
# All commits which have been newly introduced via the given revision.
|
2022-01-05 07:16:26 -05:00
|
|
|
def commits_for(oldrev, newrev)
|
2021-07-29 08:08:55 -04:00
|
|
|
commits_by_id = commits.index_by(&:id)
|
|
|
|
|
|
|
|
result = []
|
2021-08-12 11:09:58 -04:00
|
|
|
pending = Set[newrev]
|
2021-07-29 08:08:55 -04:00
|
|
|
|
|
|
|
# We go up the parent chain of our newrev and collect all commits which
|
|
|
|
# are new. In case a commit's ID cannot be found in the set of new
|
|
|
|
# commits, then it must already be a preexisting commit.
|
2021-08-12 11:09:58 -04:00
|
|
|
while pending.any?
|
|
|
|
rev = pending.first
|
|
|
|
pending.delete(rev)
|
|
|
|
|
|
|
|
# Remove the revision from commit candidates such that we don't walk
|
|
|
|
# it multiple times. If the hash doesn't contain the revision, then
|
|
|
|
# we have either already walked the commit or it's not new.
|
|
|
|
commit = commits_by_id.delete(rev)
|
2021-07-29 08:08:55 -04:00
|
|
|
next if commit.nil?
|
|
|
|
|
2021-08-12 11:09:58 -04:00
|
|
|
# Only add the parent ID to the pending set if we actually know its
|
|
|
|
# commit to guards us against readding an ID which we have already
|
2022-01-05 07:16:26 -05:00
|
|
|
# queued up before. Furthermore, we stop walking as soon as we hit
|
|
|
|
# `oldrev` such that we do not include any commits in our checks
|
|
|
|
# which have been "over-pushed" by the client.
|
2021-08-12 11:09:58 -04:00
|
|
|
commit.parent_ids.each do |parent_id|
|
2022-01-05 07:16:26 -05:00
|
|
|
pending.add(parent_id) if commits_by_id.has_key?(parent_id) && parent_id != oldrev
|
2021-08-12 11:09:58 -04:00
|
|
|
end
|
|
|
|
|
2021-07-29 08:08:55 -04:00
|
|
|
result << commit
|
|
|
|
end
|
|
|
|
|
|
|
|
result
|
|
|
|
end
|
|
|
|
|
2021-08-26 08:10:28 -04:00
|
|
|
def single_change_accesses
|
|
|
|
@single_changes_accesses ||=
|
|
|
|
changes.map do |change|
|
|
|
|
commits =
|
2022-01-05 07:16:26 -05:00
|
|
|
if blank_rev?(change[:newrev])
|
2021-08-26 08:10:28 -04:00
|
|
|
[]
|
|
|
|
else
|
2022-01-05 07:16:26 -05:00
|
|
|
Gitlab::Lazy.new { commits_for(change[:oldrev], change[:newrev]) }
|
2021-08-26 08:10:28 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
Checks::SingleChangeAccess.new(
|
|
|
|
change,
|
|
|
|
user_access: user_access,
|
|
|
|
project: project,
|
|
|
|
protocol: protocol,
|
|
|
|
logger: logger,
|
|
|
|
commits: commits
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-06-15 14:09:57 -04:00
|
|
|
protected
|
|
|
|
|
|
|
|
def single_access_checks!
|
|
|
|
# Iterate over all changes to find if user allowed all of them to be applied
|
2021-08-26 08:10:28 -04:00
|
|
|
single_change_accesses.each do |single_change_access|
|
|
|
|
single_change_access.validate!
|
2021-06-15 14:09:57 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def bulk_access_checks!
|
|
|
|
Gitlab::Checks::LfsCheck.new(self).validate!
|
|
|
|
end
|
2022-01-05 07:16:26 -05:00
|
|
|
|
|
|
|
def blank_rev?(rev)
|
|
|
|
rev.blank? || Gitlab::Git.blank_ref?(rev)
|
|
|
|
end
|
2021-06-15 14:09:57 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2021-08-26 08:10:28 -04:00
|
|
|
|
|
|
|
Gitlab::Checks::ChangesAccess.prepend_mod_with('Gitlab::Checks::ChangesAccess')
|