2014-05-23 04:22:00 -04:00
|
|
|
require('spec_helper')
|
|
|
|
|
|
|
|
describe ProjectsController do
|
|
|
|
let(:project) { create(:project) }
|
2014-06-26 03:49:14 -04:00
|
|
|
let(:public_project) { create(:project, :public) }
|
2014-05-23 04:22:00 -04:00
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:jpg) { fixture_file_upload(Rails.root + 'spec/fixtures/rails_sample.jpg', 'image/jpg') }
|
2014-05-26 09:58:03 -04:00
|
|
|
let(:txt) { fixture_file_upload(Rails.root + 'spec/fixtures/doc_sample.txt', 'text/plain') }
|
2014-05-23 04:22:00 -04:00
|
|
|
|
2015-02-24 11:02:11 -05:00
|
|
|
describe "GET show" do
|
2016-04-29 17:06:22 -04:00
|
|
|
context "user not project member" do
|
|
|
|
before { sign_in(user) }
|
|
|
|
|
|
|
|
context "user does not have access to project" do
|
|
|
|
let(:private_project) { create(:project, :private) }
|
|
|
|
|
|
|
|
it "does not initialize notification setting" do
|
|
|
|
get :show, namespace_id: private_project.namespace.path, id: private_project.path
|
|
|
|
expect(assigns(:notification_setting)).to be_nil
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "user has access to project" do
|
|
|
|
context "and does not have notification setting" do
|
|
|
|
it "initializes notification as disabled" do
|
|
|
|
get :show, namespace_id: public_project.namespace.path, id: public_project.path
|
2016-05-19 19:20:06 -04:00
|
|
|
expect(assigns(:notification_setting).level).to eq("global")
|
2016-04-29 17:06:22 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "and has notification setting" do
|
|
|
|
before do
|
|
|
|
setting = user.notification_settings_for(public_project)
|
2016-05-19 19:20:06 -04:00
|
|
|
setting.level = :watch
|
2016-04-29 17:06:22 -04:00
|
|
|
setting.save
|
|
|
|
end
|
|
|
|
|
|
|
|
it "shows current notification setting" do
|
|
|
|
get :show, namespace_id: public_project.namespace.path, id: public_project.path
|
2016-05-19 19:20:06 -04:00
|
|
|
expect(assigns(:notification_setting).level).to eq("watch")
|
2016-04-29 17:06:22 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2015-02-24 11:02:11 -05:00
|
|
|
|
2016-07-18 06:58:50 -04:00
|
|
|
context "project with empty repo" do
|
|
|
|
let(:empty_project) { create(:project_empty_repo, :public) }
|
|
|
|
|
|
|
|
before { sign_in(user) }
|
|
|
|
|
|
|
|
User.project_views.keys.each do |project_view|
|
|
|
|
context "with #{project_view} view set" do
|
|
|
|
before do
|
|
|
|
user.update_attributes(project_view: project_view)
|
|
|
|
|
|
|
|
get :show, namespace_id: empty_project.namespace.path, id: empty_project.path
|
|
|
|
end
|
|
|
|
|
|
|
|
it "renders the empty project view" do
|
|
|
|
expect(response).to render_template('empty')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-09-23 03:42:07 -04:00
|
|
|
context "project with broken repo" do
|
|
|
|
let(:empty_project) { create(:project_broken_repo, :public) }
|
|
|
|
|
|
|
|
before { sign_in(user) }
|
|
|
|
|
|
|
|
User.project_views.keys.each do |project_view|
|
|
|
|
context "with #{project_view} view set" do
|
|
|
|
before do
|
|
|
|
user.update_attributes(project_view: project_view)
|
|
|
|
|
|
|
|
get :show, namespace_id: empty_project.namespace.path, id: empty_project.path
|
|
|
|
end
|
|
|
|
|
|
|
|
it "renders the empty project view" do
|
|
|
|
allow(Project).to receive(:repo).and_raise(Gitlab::Git::Repository::NoRepository)
|
|
|
|
|
|
|
|
expect(response).to render_template('projects/no_repo')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-10-01 10:05:20 -04:00
|
|
|
context "rendering default project view" do
|
|
|
|
render_views
|
2016-05-19 19:20:06 -04:00
|
|
|
|
2015-10-17 13:27:02 -04:00
|
|
|
it "renders the activity view" do
|
2015-10-01 10:05:20 -04:00
|
|
|
allow(controller).to receive(:current_user).and_return(user)
|
|
|
|
allow(user).to receive(:project_view).and_return('activity')
|
2015-10-17 13:27:02 -04:00
|
|
|
|
2015-10-01 10:05:20 -04:00
|
|
|
get :show, namespace_id: public_project.namespace.path, id: public_project.path
|
|
|
|
expect(response).to render_template('_activity')
|
|
|
|
end
|
|
|
|
|
2015-10-17 13:27:02 -04:00
|
|
|
it "renders the readme view" do
|
2015-10-01 10:05:20 -04:00
|
|
|
allow(controller).to receive(:current_user).and_return(user)
|
|
|
|
allow(user).to receive(:project_view).and_return('readme')
|
2015-10-17 13:27:02 -04:00
|
|
|
|
2015-10-01 10:05:20 -04:00
|
|
|
get :show, namespace_id: public_project.namespace.path, id: public_project.path
|
|
|
|
expect(response).to render_template('_readme')
|
|
|
|
end
|
|
|
|
|
2015-10-17 13:27:02 -04:00
|
|
|
it "renders the files view" do
|
2015-10-01 10:05:20 -04:00
|
|
|
allow(controller).to receive(:current_user).and_return(user)
|
|
|
|
allow(user).to receive(:project_view).and_return('files')
|
2015-10-17 13:27:02 -04:00
|
|
|
|
2015-10-01 10:05:20 -04:00
|
|
|
get :show, namespace_id: public_project.namespace.path, id: public_project.path
|
|
|
|
expect(response).to render_template('_files')
|
|
|
|
end
|
|
|
|
end
|
2015-10-17 12:20:04 -04:00
|
|
|
|
2015-09-17 09:56:16 -04:00
|
|
|
context "when requested with case sensitive namespace and project path" do
|
2015-10-20 10:16:08 -04:00
|
|
|
context "when there is a match with the same casing" do
|
|
|
|
it "loads the project" do
|
|
|
|
get :show, namespace_id: public_project.namespace.path, id: public_project.path
|
2015-09-17 09:56:16 -04:00
|
|
|
|
2015-10-20 10:16:08 -04:00
|
|
|
expect(assigns(:project)).to eq(public_project)
|
2016-06-27 14:10:42 -04:00
|
|
|
expect(response).to have_http_status(200)
|
2015-10-20 10:16:08 -04:00
|
|
|
end
|
2015-09-17 09:56:16 -04:00
|
|
|
end
|
|
|
|
|
2015-10-20 10:16:08 -04:00
|
|
|
context "when there is a match with different casing" do
|
|
|
|
it "redirects to the normalized path" do
|
|
|
|
get :show, namespace_id: public_project.namespace.path, id: public_project.path.upcase
|
|
|
|
|
|
|
|
expect(assigns(:project)).to eq(public_project)
|
|
|
|
expect(response).to redirect_to("/#{public_project.path_with_namespace}")
|
|
|
|
end
|
|
|
|
|
2015-10-21 04:21:01 -04:00
|
|
|
# MySQL queries are case insensitive by default, so this spec would fail.
|
2015-10-22 04:19:12 -04:00
|
|
|
if Gitlab::Database.postgresql?
|
2015-10-21 04:21:01 -04:00
|
|
|
context "when there is also a match with the same casing" do
|
|
|
|
let!(:other_project) { create(:project, :public, namespace: public_project.namespace, path: public_project.path.upcase) }
|
2015-10-21 04:09:40 -04:00
|
|
|
|
2015-10-21 04:21:01 -04:00
|
|
|
it "loads the exactly matched project" do
|
|
|
|
get :show, namespace_id: public_project.namespace.path, id: public_project.path.upcase
|
|
|
|
|
|
|
|
expect(assigns(:project)).to eq(other_project)
|
2016-06-27 14:10:42 -04:00
|
|
|
expect(response).to have_http_status(200)
|
2015-10-21 04:21:01 -04:00
|
|
|
end
|
2015-10-20 10:16:08 -04:00
|
|
|
end
|
|
|
|
end
|
2015-09-17 09:56:16 -04:00
|
|
|
end
|
|
|
|
end
|
2016-01-22 11:55:12 -05:00
|
|
|
|
|
|
|
context "when the url contains .atom" do
|
2016-02-04 07:20:55 -05:00
|
|
|
let(:public_project_with_dot_atom) { build(:project, :public, name: 'my.atom', path: 'my.atom') }
|
2016-01-22 11:55:12 -05:00
|
|
|
|
2016-07-25 14:16:19 -04:00
|
|
|
it 'expects an error creating the project' do
|
2016-02-04 07:20:55 -05:00
|
|
|
expect(public_project_with_dot_atom).not_to be_valid
|
2016-01-22 11:55:12 -05:00
|
|
|
end
|
|
|
|
end
|
2016-05-14 05:33:14 -04:00
|
|
|
|
|
|
|
context 'when the project is pending deletions' do
|
|
|
|
it 'renders a 404 error' do
|
|
|
|
project = create(:project, pending_delete: true)
|
|
|
|
sign_in(user)
|
|
|
|
|
|
|
|
get :show, namespace_id: project.namespace.path, id: project.path
|
|
|
|
|
|
|
|
expect(response.status).to eq 404
|
|
|
|
end
|
|
|
|
end
|
2015-02-24 11:02:11 -05:00
|
|
|
end
|
2015-06-23 01:24:39 -04:00
|
|
|
|
2016-04-04 17:59:54 -04:00
|
|
|
describe "#update" do
|
|
|
|
render_views
|
|
|
|
|
|
|
|
let(:admin) { create(:admin) }
|
|
|
|
|
|
|
|
it "sets the repository to the right path after a rename" do
|
|
|
|
new_path = 'renamed_path'
|
|
|
|
project_params = { path: new_path }
|
|
|
|
controller.instance_variable_set(:@project, project)
|
|
|
|
sign_in(admin)
|
|
|
|
|
|
|
|
put :update,
|
|
|
|
namespace_id: project.namespace.to_param,
|
|
|
|
id: project.id,
|
|
|
|
project: project_params
|
|
|
|
|
|
|
|
expect(project.repository.path).to include(new_path)
|
|
|
|
expect(assigns(:repository).path).to eq(project.repository.path)
|
2016-06-27 14:10:42 -04:00
|
|
|
expect(response).to have_http_status(200)
|
2016-04-04 17:59:54 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-11-26 02:11:35 -05:00
|
|
|
describe "#destroy" do
|
|
|
|
let(:admin) { create(:admin) }
|
|
|
|
|
|
|
|
it "redirects to the dashboard" do
|
|
|
|
controller.instance_variable_set(:@project, project)
|
|
|
|
sign_in(admin)
|
|
|
|
|
|
|
|
orig_id = project.id
|
|
|
|
delete :destroy, namespace_id: project.namespace.path, id: project.path
|
|
|
|
|
|
|
|
expect { Project.find(orig_id) }.to raise_error(ActiveRecord::RecordNotFound)
|
2016-06-27 14:10:42 -04:00
|
|
|
expect(response).to have_http_status(302)
|
2015-11-26 02:11:35 -05:00
|
|
|
expect(response).to redirect_to(dashboard_projects_path)
|
|
|
|
end
|
2016-09-01 07:42:17 -04:00
|
|
|
|
2016-09-08 08:20:11 -04:00
|
|
|
context "when the project is forked" do
|
2016-09-01 07:42:17 -04:00
|
|
|
let(:project) { create(:project) }
|
|
|
|
let(:fork_project) { create(:project, forked_from_project: project) }
|
|
|
|
let(:merge_request) do
|
2016-09-02 09:36:59 -04:00
|
|
|
create(:merge_request,
|
|
|
|
source_project: fork_project,
|
|
|
|
target_project: project)
|
2016-09-01 07:42:17 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "closes all related merge requests" do
|
2016-09-02 07:36:25 -04:00
|
|
|
project.merge_requests << merge_request
|
|
|
|
sign_in(admin)
|
2016-09-01 07:42:17 -04:00
|
|
|
|
2016-09-02 07:36:25 -04:00
|
|
|
delete :destroy, namespace_id: fork_project.namespace.path, id: fork_project.path
|
|
|
|
|
|
|
|
expect(merge_request.reload.state).to eq('closed')
|
2016-09-01 07:42:17 -04:00
|
|
|
end
|
|
|
|
end
|
2015-11-26 02:11:35 -05:00
|
|
|
end
|
|
|
|
|
2014-06-26 03:49:14 -04:00
|
|
|
describe "POST #toggle_star" do
|
2014-07-14 09:17:59 -04:00
|
|
|
it "toggles star if user is signed in" do
|
2014-06-26 03:49:14 -04:00
|
|
|
sign_in(user)
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(user.starred?(public_project)).to be_falsey
|
2015-06-23 01:24:39 -04:00
|
|
|
post(:toggle_star,
|
|
|
|
namespace_id: public_project.namespace.to_param,
|
2015-01-24 13:02:58 -05:00
|
|
|
id: public_project.to_param)
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(user.starred?(public_project)).to be_truthy
|
2015-06-23 01:24:39 -04:00
|
|
|
post(:toggle_star,
|
|
|
|
namespace_id: public_project.namespace.to_param,
|
2015-01-24 13:02:58 -05:00
|
|
|
id: public_project.to_param)
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(user.starred?(public_project)).to be_falsey
|
2014-06-26 03:49:14 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "does nothing if user is not signed in" do
|
2015-06-23 01:24:39 -04:00
|
|
|
post(:toggle_star,
|
|
|
|
namespace_id: project.namespace.to_param,
|
2015-01-24 13:02:58 -05:00
|
|
|
id: public_project.to_param)
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(user.starred?(public_project)).to be_falsey
|
2015-06-23 01:24:39 -04:00
|
|
|
post(:toggle_star,
|
|
|
|
namespace_id: project.namespace.to_param,
|
2015-01-24 13:02:58 -05:00
|
|
|
id: public_project.to_param)
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(user.starred?(public_project)).to be_falsey
|
2014-06-26 03:49:14 -04:00
|
|
|
end
|
|
|
|
end
|
2015-10-13 06:24:44 -04:00
|
|
|
|
2015-10-18 06:37:50 -04:00
|
|
|
describe "DELETE remove_fork" do
|
2015-10-13 06:24:44 -04:00
|
|
|
context 'when signed in' do
|
|
|
|
before do
|
|
|
|
sign_in(user)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with forked project' do
|
|
|
|
let(:project_fork) { create(:project, namespace: user.namespace) }
|
|
|
|
|
2015-10-13 18:04:22 -04:00
|
|
|
before do
|
2015-10-13 06:24:44 -04:00
|
|
|
create(:forked_project_link, forked_to_project: project_fork)
|
2015-10-13 18:04:22 -04:00
|
|
|
end
|
|
|
|
|
2016-07-25 14:16:19 -04:00
|
|
|
it 'removes fork from project' do
|
2015-10-13 18:04:22 -04:00
|
|
|
delete(:remove_fork,
|
2015-10-13 06:24:44 -04:00
|
|
|
namespace_id: project_fork.namespace.to_param,
|
|
|
|
id: project_fork.to_param, format: :js)
|
|
|
|
|
|
|
|
expect(project_fork.forked?).to be_falsey
|
2015-10-18 06:37:50 -04:00
|
|
|
expect(flash[:notice]).to eq('The fork relationship has been removed.')
|
2015-10-13 06:24:44 -04:00
|
|
|
expect(response).to render_template(:remove_fork)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2015-10-13 18:04:22 -04:00
|
|
|
context 'when project not forked' do
|
|
|
|
let(:unforked_project) { create(:project, namespace: user.namespace) }
|
2015-10-13 06:24:44 -04:00
|
|
|
|
2016-07-25 14:16:19 -04:00
|
|
|
it 'does nothing if project was not forked' do
|
2015-10-13 18:04:22 -04:00
|
|
|
delete(:remove_fork,
|
|
|
|
namespace_id: unforked_project.namespace.to_param,
|
|
|
|
id: unforked_project.to_param, format: :js)
|
|
|
|
|
|
|
|
expect(flash[:notice]).to be_nil
|
|
|
|
expect(response).to render_template(:remove_fork)
|
|
|
|
end
|
2015-10-13 06:24:44 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it "does nothing if user is not signed in" do
|
2015-10-13 18:04:22 -04:00
|
|
|
delete(:remove_fork,
|
2015-10-13 06:24:44 -04:00
|
|
|
namespace_id: project.namespace.to_param,
|
|
|
|
id: project.to_param, format: :js)
|
2016-06-27 14:10:42 -04:00
|
|
|
expect(response).to have_http_status(401)
|
2015-10-13 06:24:44 -04:00
|
|
|
end
|
|
|
|
end
|
2016-06-20 06:37:27 -04:00
|
|
|
|
|
|
|
describe "GET refs" do
|
2016-07-25 14:16:19 -04:00
|
|
|
it "gets a list of branches and tags" do
|
2016-06-20 06:37:27 -04:00
|
|
|
get :refs, namespace_id: public_project.namespace.path, id: public_project.path
|
|
|
|
|
|
|
|
parsed_body = JSON.parse(response.body)
|
|
|
|
expect(parsed_body["Branches"]).to include("master")
|
|
|
|
expect(parsed_body["Tags"]).to include("v1.0.0")
|
|
|
|
expect(parsed_body["Commits"]).to be_nil
|
|
|
|
end
|
|
|
|
|
2016-07-25 14:16:19 -04:00
|
|
|
it "gets a list of branches, tags and commits" do
|
2016-06-20 06:37:27 -04:00
|
|
|
get :refs, namespace_id: public_project.namespace.path, id: public_project.path, ref: "123456"
|
|
|
|
|
|
|
|
parsed_body = JSON.parse(response.body)
|
|
|
|
expect(parsed_body["Branches"]).to include("master")
|
|
|
|
expect(parsed_body["Tags"]).to include("v1.0.0")
|
|
|
|
expect(parsed_body["Commits"]).to include("123456")
|
|
|
|
end
|
|
|
|
end
|
2014-05-26 08:17:46 -04:00
|
|
|
end
|