gitlab-org--gitlab-foss/db/migrate/20160805041956_add_deleted_at_to_namespaces.rb

# rubocop:disable RemoveIndex
class AddDeletedAtToNamespaces < ActiveRecord::Migration
  include Gitlab::Database::MigrationHelpers

  DOWNTIME = false

  disable_ddl_transaction!

  def up
    add_column :namespaces, :deleted_at, :datetime

    add_concurrent_index :namespaces, :deleted_at
  end

  def down
    remove_index :namespaces, :deleted_at if index_exists? :namespaces, :deleted_at

    remove_column :namespaces, :deleted_at
  end
end
Add remove_concurrent_index to database helper 2017-04-05 18:53:57 -04:00			`# rubocop:disable RemoveIndex`
Fix bug where destroying a namespace would not always destroy projects There is a race condition in DestroyGroupService now that projects are deleted asynchronously: 1. User attempts to delete group 2. DestroyGroupService iterates through all projects and schedules a Sidekiq job to delete each Project 3. DestroyGroupService destroys the Group, leaving all its projects without a namespace 4. Projects::DestroyService runs later but the can?(current_user, :remove_project) is `false` because the user no longer has permission to destroy projects with no namespace. 5. This leaves the project in pending_delete state with no namespace/group. Projects without a namespace or group also adds another problem: it's not possible to destroy the container registry tags, since container_registry_path_with_namespace is the wrong value. The fix is to destroy the group asynchronously and to run execute directly on Projects::DestroyService. Closes #17893 2016-05-28 22:54:17 -04:00			`class AddDeletedAtToNamespaces < ActiveRecord::Migration`
			`include Gitlab::Database::MigrationHelpers`

			`DOWNTIME = false`

			`disable_ddl_transaction!`

Add cop to ensure reversibility of add_concurrent_index 2017-03-07 11:08:53 -05:00			`def up`
Fix bug where destroying a namespace would not always destroy projects There is a race condition in DestroyGroupService now that projects are deleted asynchronously: 1. User attempts to delete group 2. DestroyGroupService iterates through all projects and schedules a Sidekiq job to delete each Project 3. DestroyGroupService destroys the Group, leaving all its projects without a namespace 4. Projects::DestroyService runs later but the can?(current_user, :remove_project) is `false` because the user no longer has permission to destroy projects with no namespace. 5. This leaves the project in pending_delete state with no namespace/group. Projects without a namespace or group also adds another problem: it's not possible to destroy the container registry tags, since container_registry_path_with_namespace is the wrong value. The fix is to destroy the group asynchronously and to run execute directly on Projects::DestroyService. Closes #17893 2016-05-28 22:54:17 -04:00			`add_column :namespaces, :deleted_at, :datetime`
Add cop to ensure reversibility of add_concurrent_index 2017-03-07 11:08:53 -05:00
Fix bug where destroying a namespace would not always destroy projects There is a race condition in DestroyGroupService now that projects are deleted asynchronously: 1. User attempts to delete group 2. DestroyGroupService iterates through all projects and schedules a Sidekiq job to delete each Project 3. DestroyGroupService destroys the Group, leaving all its projects without a namespace 4. Projects::DestroyService runs later but the can?(current_user, :remove_project) is `false` because the user no longer has permission to destroy projects with no namespace. 5. This leaves the project in pending_delete state with no namespace/group. Projects without a namespace or group also adds another problem: it's not possible to destroy the container registry tags, since container_registry_path_with_namespace is the wrong value. The fix is to destroy the group asynchronously and to run execute directly on Projects::DestroyService. Closes #17893 2016-05-28 22:54:17 -04:00			`add_concurrent_index :namespaces, :deleted_at`
			`end`
Add cop to ensure reversibility of add_concurrent_index 2017-03-07 11:08:53 -05:00
			`def down`
			`remove_index :namespaces, :deleted_at if index_exists? :namespaces, :deleted_at`

			`remove_column :namespaces, :deleted_at`
			`end`
Fix bug where destroying a namespace would not always destroy projects There is a race condition in DestroyGroupService now that projects are deleted asynchronously: 1. User attempts to delete group 2. DestroyGroupService iterates through all projects and schedules a Sidekiq job to delete each Project 3. DestroyGroupService destroys the Group, leaving all its projects without a namespace 4. Projects::DestroyService runs later but the can?(current_user, :remove_project) is `false` because the user no longer has permission to destroy projects with no namespace. 5. This leaves the project in pending_delete state with no namespace/group. Projects without a namespace or group also adds another problem: it's not possible to destroy the container registry tags, since container_registry_path_with_namespace is the wrong value. The fix is to destroy the group asynchronously and to run execute directly on Projects::DestroyService. Closes #17893 2016-05-28 22:54:17 -04:00			`end`