2020-06-09 21:08:21 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-26 09:08:59 +00:00
|
|
|
RSpec.describe Gitlab::GitAccessProject do
|
2020-06-09 21:08:21 +00:00
|
|
|
let_it_be(:user) { create(:user) }
|
|
|
|
let_it_be(:project) { create(:project, :repository) }
|
2021-04-21 06:09:28 +00:00
|
|
|
|
2020-07-21 18:09:45 +00:00
|
|
|
let(:container) { project }
|
2020-06-09 21:08:21 +00:00
|
|
|
let(:actor) { user }
|
|
|
|
let(:project_path) { project.path }
|
|
|
|
let(:namespace_path) { project&.namespace&.path }
|
2020-12-01 12:09:17 +00:00
|
|
|
let(:repository_path) { "#{namespace_path}/#{project_path}.git" }
|
2020-06-09 21:08:21 +00:00
|
|
|
let(:protocol) { 'ssh' }
|
|
|
|
let(:authentication_abilities) { %i[read_project download_code push_code] }
|
|
|
|
let(:changes) { Gitlab::GitAccess::ANY }
|
|
|
|
let(:push_access_check) { access.check('git-receive-pack', changes) }
|
|
|
|
let(:pull_access_check) { access.check('git-upload-pack', changes) }
|
2020-07-21 18:09:45 +00:00
|
|
|
let(:access) do
|
|
|
|
described_class.new(actor, container, protocol,
|
|
|
|
authentication_abilities: authentication_abilities,
|
2020-12-01 12:09:17 +00:00
|
|
|
repository_path: repository_path)
|
2020-07-21 18:09:45 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
describe '#check_namespace!' do
|
|
|
|
context 'when namespace is nil' do
|
|
|
|
let(:namespace_path) { nil }
|
|
|
|
|
|
|
|
it 'does not allow push and pull access' do
|
|
|
|
aggregate_failures do
|
|
|
|
expect { push_access_check }.to raise_namespace_not_found
|
|
|
|
expect { pull_access_check }.to raise_namespace_not_found
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2020-06-09 21:08:21 +00:00
|
|
|
|
|
|
|
describe '#check_project_accessibility!' do
|
|
|
|
context 'when the project is nil' do
|
2020-07-21 18:09:45 +00:00
|
|
|
let(:container) { nil }
|
2020-06-09 21:08:21 +00:00
|
|
|
let(:project_path) { "new-project" }
|
|
|
|
|
|
|
|
context 'when user is allowed to create project in namespace' do
|
|
|
|
let(:namespace_path) { user.namespace.path }
|
|
|
|
|
|
|
|
it 'blocks pull access with "not found"' do
|
|
|
|
expect { pull_access_check }.to raise_not_found
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'allows push access' do
|
|
|
|
expect { push_access_check }.not_to raise_error
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is not allowed to create project in namespace' do
|
|
|
|
let(:user2) { create(:user) }
|
|
|
|
let(:namespace_path) { user2.namespace.path }
|
|
|
|
|
|
|
|
it 'blocks push and pull with "not found"' do
|
|
|
|
aggregate_failures do
|
|
|
|
expect { pull_access_check }.to raise_not_found
|
|
|
|
expect { push_access_check }.to raise_not_found
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#ensure_project_on_push!' do
|
|
|
|
before do
|
|
|
|
allow(access).to receive(:changes).and_return(changes)
|
|
|
|
end
|
|
|
|
|
2020-07-21 18:09:45 +00:00
|
|
|
shared_examples 'no project is created' do
|
|
|
|
let(:raise_specific_error) { raise_not_found }
|
|
|
|
let(:action) { push_access_check }
|
|
|
|
|
|
|
|
it 'does not create a new project' do
|
|
|
|
expect { action }
|
|
|
|
.to raise_specific_error
|
|
|
|
.and change { Project.count }.by(0)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-06-09 21:08:21 +00:00
|
|
|
context 'when push' do
|
|
|
|
let(:cmd) { 'git-receive-pack' }
|
|
|
|
|
|
|
|
context 'when project does not exist' do
|
|
|
|
let(:project_path) { "nonexistent" }
|
2020-07-21 18:09:45 +00:00
|
|
|
let(:container) { nil }
|
2020-06-09 21:08:21 +00:00
|
|
|
|
|
|
|
context 'when changes is _any' do
|
|
|
|
let(:changes) { Gitlab::GitAccess::ANY }
|
|
|
|
|
|
|
|
context 'when authentication abilities include push code' do
|
|
|
|
let(:authentication_abilities) { [:push_code] }
|
|
|
|
|
|
|
|
context 'when user can create project in namespace' do
|
|
|
|
let(:namespace_path) { user.namespace.path }
|
|
|
|
|
2020-07-21 18:09:45 +00:00
|
|
|
it 'creates a new project in the correct namespace' do
|
|
|
|
expect { push_access_check }
|
2020-06-09 21:08:21 +00:00
|
|
|
.to change { Project.count }.by(1)
|
|
|
|
.and change { Project.where(namespace: user.namespace, name: project_path).count }.by(1)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2020-12-01 12:09:17 +00:00
|
|
|
context 'when namespace is blank' do
|
|
|
|
let(:repository_path) { 'project.git' }
|
|
|
|
|
|
|
|
it_behaves_like 'no project is created' do
|
|
|
|
let(:raise_specific_error) { raise_namespace_not_found }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when namespace does not exist' do
|
|
|
|
let(:namespace_path) { 'unknown' }
|
|
|
|
|
|
|
|
it_behaves_like 'no project is created'
|
|
|
|
end
|
|
|
|
|
2020-06-09 21:08:21 +00:00
|
|
|
context 'when user cannot create project in namespace' do
|
|
|
|
let(:user2) { create(:user) }
|
|
|
|
let(:namespace_path) { user2.namespace.path }
|
|
|
|
|
2020-07-21 18:09:45 +00:00
|
|
|
it_behaves_like 'no project is created'
|
2020-06-09 21:08:21 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when authentication abilities do not include push code' do
|
|
|
|
let(:authentication_abilities) { [] }
|
|
|
|
|
|
|
|
context 'when user can create project in namespace' do
|
|
|
|
let(:namespace_path) { user.namespace.path }
|
|
|
|
|
2020-07-21 18:09:45 +00:00
|
|
|
it_behaves_like 'no project is created' do
|
|
|
|
let(:raise_specific_error) { raise_forbidden }
|
2020-06-09 21:08:21 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when check contains actual changes' do
|
|
|
|
let(:changes) { "#{Gitlab::Git::BLANK_SHA} 570e7b2abdd848b95f2f578043fc23bd6f6fd24d refs/heads/new_branch" }
|
|
|
|
|
2020-07-21 18:09:45 +00:00
|
|
|
it_behaves_like 'no project is created'
|
2020-06-09 21:08:21 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when project exists' do
|
|
|
|
let(:changes) { Gitlab::GitAccess::ANY }
|
2020-07-21 18:09:45 +00:00
|
|
|
let!(:container) { project }
|
2020-06-09 21:08:21 +00:00
|
|
|
|
2020-07-21 18:09:45 +00:00
|
|
|
it_behaves_like 'no project is created'
|
2020-06-09 21:08:21 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when deploy key is used' do
|
|
|
|
let(:key) { create(:deploy_key, user: user) }
|
|
|
|
let(:actor) { key }
|
|
|
|
let(:project_path) { "nonexistent" }
|
2020-07-21 18:09:45 +00:00
|
|
|
let(:container) { nil }
|
2020-06-09 21:08:21 +00:00
|
|
|
let(:namespace_path) { user.namespace.path }
|
|
|
|
let(:changes) { Gitlab::GitAccess::ANY }
|
|
|
|
|
2020-07-21 18:09:45 +00:00
|
|
|
it_behaves_like 'no project is created'
|
2020-06-09 21:08:21 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when pull' do
|
|
|
|
let(:cmd) { 'git-upload-pack' }
|
|
|
|
let(:changes) { Gitlab::GitAccess::ANY }
|
|
|
|
|
|
|
|
context 'when project does not exist' do
|
|
|
|
let(:project_path) { "new-project" }
|
|
|
|
let(:namespace_path) { user.namespace.path }
|
2020-07-21 18:09:45 +00:00
|
|
|
let(:container) { nil }
|
2020-06-09 21:08:21 +00:00
|
|
|
|
2020-07-21 18:09:45 +00:00
|
|
|
it_behaves_like 'no project is created' do
|
|
|
|
let(:action) { pull_access_check }
|
2020-06-09 21:08:21 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def raise_not_found
|
|
|
|
raise_error(Gitlab::GitAccess::NotFoundError, Gitlab::GitAccess::ERROR_MESSAGES[:project_not_found])
|
|
|
|
end
|
2020-07-21 18:09:45 +00:00
|
|
|
|
|
|
|
def raise_forbidden
|
|
|
|
raise_error(Gitlab::GitAccess::ForbiddenError)
|
|
|
|
end
|
|
|
|
|
|
|
|
def raise_namespace_not_found
|
|
|
|
raise_error(Gitlab::GitAccess::NotFoundError, described_class::ERROR_MESSAGES[:namespace_not_found])
|
|
|
|
end
|
2020-06-09 21:08:21 +00:00
|
|
|
end
|