2016-08-23 19:19:36 -04:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2017-07-10 10:24:02 -04:00
|
|
|
describe ProjectPolicy do
|
2019-04-09 11:38:58 -04:00
|
|
|
include ExternalAuthorizationServiceHelpers
|
2019-03-26 07:31:47 -04:00
|
|
|
include_context 'ProjectPolicy context'
|
2017-09-22 03:13:31 -04:00
|
|
|
set(:guest) { create(:user) }
|
|
|
|
set(:reporter) { create(:user) }
|
|
|
|
set(:developer) { create(:user) }
|
2018-07-11 10:36:08 -04:00
|
|
|
set(:maintainer) { create(:user) }
|
2017-09-22 03:13:31 -04:00
|
|
|
set(:owner) { create(:user) }
|
|
|
|
set(:admin) { create(:admin) }
|
2017-08-02 15:55:11 -04:00
|
|
|
let(:project) { create(:project, :public, namespace: owner.namespace) }
|
2016-08-23 19:19:36 -04:00
|
|
|
|
2017-09-22 03:13:31 -04:00
|
|
|
let(:base_guest_permissions) do
|
2017-02-06 18:19:37 -05:00
|
|
|
%i[
|
2018-04-02 11:14:20 -04:00
|
|
|
read_project read_board read_list read_wiki read_issue
|
2019-01-09 14:24:05 -05:00
|
|
|
read_project_for_iids read_issue_iid read_label
|
2018-04-02 11:14:20 -04:00
|
|
|
read_milestone read_project_snippet read_project_member read_note
|
2018-04-06 08:18:58 -04:00
|
|
|
create_project create_issue create_note upload_file create_merge_request_in
|
2019-05-03 09:29:20 -04:00
|
|
|
award_emoji read_release
|
2016-09-21 01:09:31 -04:00
|
|
|
]
|
2016-08-23 19:19:36 -04:00
|
|
|
end
|
|
|
|
|
2017-09-22 03:13:31 -04:00
|
|
|
let(:base_reporter_permissions) do
|
2017-02-06 18:19:37 -05:00
|
|
|
%i[
|
|
|
|
download_code fork_project create_project_snippet update_issue
|
|
|
|
admin_issue admin_label admin_list read_commit_status read_build
|
|
|
|
read_container_image read_pipeline read_environment read_deployment
|
2019-05-03 09:29:20 -04:00
|
|
|
read_merge_request download_wiki_code read_sentry_issue
|
2016-09-21 01:09:31 -04:00
|
|
|
]
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:team_member_reporter_permissions) do
|
2017-02-06 18:19:37 -05:00
|
|
|
%i[build_download_code build_read_container_image]
|
2016-09-21 01:09:31 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
let(:developer_permissions) do
|
2017-02-06 18:19:37 -05:00
|
|
|
%i[
|
2017-09-13 16:32:58 -04:00
|
|
|
admin_milestone admin_merge_request update_merge_request create_commit_status
|
2017-02-06 18:19:37 -05:00
|
|
|
update_commit_status create_build update_build create_pipeline
|
2018-04-06 08:18:58 -04:00
|
|
|
update_pipeline create_merge_request_from create_wiki push_code
|
2017-02-06 18:19:37 -05:00
|
|
|
resolve_note create_container_image update_container_image
|
2018-12-13 06:08:53 -05:00
|
|
|
create_environment create_deployment create_release update_release
|
2016-09-21 01:09:31 -04:00
|
|
|
]
|
|
|
|
end
|
|
|
|
|
2018-07-11 10:36:08 -04:00
|
|
|
let(:base_maintainer_permissions) do
|
2017-02-06 18:19:37 -05:00
|
|
|
%i[
|
2018-04-02 12:30:49 -04:00
|
|
|
push_to_delete_protected_branch update_project_snippet update_environment
|
2019-03-06 07:20:27 -05:00
|
|
|
update_deployment admin_project_snippet admin_project_member admin_note admin_wiki admin_project
|
2017-02-06 18:19:37 -05:00
|
|
|
admin_commit_status admin_build admin_container_image
|
2018-12-25 04:48:26 -05:00
|
|
|
admin_pipeline admin_environment admin_deployment destroy_release add_cluster
|
2018-12-13 14:26:56 -05:00
|
|
|
daily_statistics
|
2016-09-21 01:09:31 -04:00
|
|
|
]
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:public_permissions) do
|
2017-02-06 18:19:37 -05:00
|
|
|
%i[
|
|
|
|
download_code fork_project read_commit_status read_pipeline
|
|
|
|
read_container_image build_download_code build_read_container_image
|
2018-12-13 06:08:53 -05:00
|
|
|
download_wiki_code read_release
|
2016-09-21 01:09:31 -04:00
|
|
|
]
|
|
|
|
end
|
|
|
|
|
|
|
|
let(:owner_permissions) do
|
2017-02-06 18:19:37 -05:00
|
|
|
%i[
|
|
|
|
change_namespace change_visibility_level rename_project remove_project
|
|
|
|
archive_project remove_fork_project destroy_merge_request destroy_issue
|
2018-08-22 08:10:54 -04:00
|
|
|
set_issue_iid set_issue_created_at set_note_created_at
|
2016-09-21 01:09:31 -04:00
|
|
|
]
|
2016-08-23 19:19:36 -04:00
|
|
|
end
|
|
|
|
|
2017-09-22 03:13:31 -04:00
|
|
|
# Used in EE specs
|
2019-01-16 07:09:29 -05:00
|
|
|
let(:additional_guest_permissions) { [] }
|
2017-09-22 03:13:31 -04:00
|
|
|
let(:additional_reporter_permissions) { [] }
|
2018-07-11 10:36:08 -04:00
|
|
|
let(:additional_maintainer_permissions) { [] }
|
2017-09-22 03:13:31 -04:00
|
|
|
|
|
|
|
let(:guest_permissions) { base_guest_permissions + additional_guest_permissions }
|
|
|
|
let(:reporter_permissions) { base_reporter_permissions + additional_reporter_permissions }
|
2018-07-11 10:36:08 -04:00
|
|
|
let(:maintainer_permissions) { base_maintainer_permissions + additional_maintainer_permissions }
|
2017-09-22 03:13:31 -04:00
|
|
|
|
2016-08-23 19:19:36 -04:00
|
|
|
before do
|
2017-09-22 03:13:31 -04:00
|
|
|
project.add_guest(guest)
|
2018-07-11 10:36:08 -04:00
|
|
|
project.add_maintainer(maintainer)
|
2017-09-22 03:13:31 -04:00
|
|
|
project.add_developer(developer)
|
|
|
|
project.add_reporter(reporter)
|
2016-08-23 19:19:36 -04:00
|
|
|
end
|
2016-09-19 16:21:58 -04:00
|
|
|
|
2017-04-06 17:09:58 -04:00
|
|
|
def expect_allowed(*permissions)
|
|
|
|
permissions.each { |p| is_expected.to be_allowed(p) }
|
|
|
|
end
|
|
|
|
|
|
|
|
def expect_disallowed(*permissions)
|
|
|
|
permissions.each { |p| is_expected.not_to be_allowed(p) }
|
|
|
|
end
|
|
|
|
|
2016-09-19 16:21:58 -04:00
|
|
|
it 'does not include the read_issue permission when the issue author is not a member of the private project' do
|
2017-08-02 15:55:11 -04:00
|
|
|
project = create(:project, :private)
|
2017-08-04 13:14:04 -04:00
|
|
|
issue = create(:issue, project: project, author: create(:user))
|
2016-09-19 16:21:58 -04:00
|
|
|
user = issue.author
|
|
|
|
|
2017-04-06 17:09:58 -04:00
|
|
|
expect(project.team.member?(issue.author)).to be false
|
2016-09-19 16:21:58 -04:00
|
|
|
|
2017-04-06 17:09:58 -04:00
|
|
|
expect(Ability).not_to be_allowed(user, :read_issue, project)
|
2016-09-19 16:21:58 -04:00
|
|
|
end
|
2016-09-21 01:09:31 -04:00
|
|
|
|
2019-01-09 10:05:52 -05:00
|
|
|
context 'wiki feature' do
|
|
|
|
let(:permissions) { %i(read_wiki create_wiki update_wiki admin_wiki download_wiki_code) }
|
|
|
|
|
2017-04-06 17:09:58 -04:00
|
|
|
subject { described_class.new(owner, project) }
|
2016-11-29 14:30:14 -05:00
|
|
|
|
2019-01-09 10:05:52 -05:00
|
|
|
context 'when the feature is disabled' do
|
|
|
|
before do
|
|
|
|
project.project_feature.update_attribute(:wiki_access_level, ProjectFeature::DISABLED)
|
|
|
|
end
|
2016-11-29 14:30:14 -05:00
|
|
|
|
2019-01-09 10:05:52 -05:00
|
|
|
it 'does not include the wiki permissions' do
|
|
|
|
expect_disallowed(*permissions)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when there is an external wiki' do
|
|
|
|
it 'does not include the wiki permissions' do
|
|
|
|
allow(project).to receive(:has_external_wiki?).and_return(true)
|
|
|
|
|
|
|
|
expect_disallowed(*permissions)
|
|
|
|
end
|
|
|
|
end
|
2017-04-06 17:09:58 -04:00
|
|
|
end
|
2016-11-29 14:30:14 -05:00
|
|
|
end
|
|
|
|
|
2017-06-13 04:25:25 -04:00
|
|
|
context 'issues feature' do
|
|
|
|
subject { described_class.new(owner, project) }
|
|
|
|
|
|
|
|
context 'when the feature is disabled' do
|
2019-02-11 05:51:53 -05:00
|
|
|
before do
|
2017-06-13 04:25:25 -04:00
|
|
|
project.issues_enabled = false
|
|
|
|
project.save!
|
2019-02-11 05:51:53 -05:00
|
|
|
end
|
2017-06-13 04:25:25 -04:00
|
|
|
|
2019-02-11 05:51:53 -05:00
|
|
|
it 'does not include the issues permissions' do
|
2018-04-02 11:14:20 -04:00
|
|
|
expect_disallowed :read_issue, :read_issue_iid, :create_issue, :update_issue, :admin_issue
|
2017-06-13 04:25:25 -04:00
|
|
|
end
|
|
|
|
|
2019-02-11 05:51:53 -05:00
|
|
|
it 'disables boards and lists permissions' do
|
2019-03-26 07:31:47 -04:00
|
|
|
expect_disallowed :read_board, :create_board, :update_board
|
2019-02-11 05:51:53 -05:00
|
|
|
expect_disallowed :read_list, :create_list, :update_list, :admin_list
|
|
|
|
end
|
2017-06-13 04:25:25 -04:00
|
|
|
|
2019-02-11 05:51:53 -05:00
|
|
|
context 'when external tracker configured' do
|
|
|
|
it 'does not include the issues permissions' do
|
|
|
|
create(:jira_service, project: project)
|
2017-06-13 04:25:25 -04:00
|
|
|
|
2019-02-11 05:51:53 -05:00
|
|
|
expect_disallowed :read_issue, :read_issue_iid, :create_issue, :update_issue, :admin_issue
|
|
|
|
end
|
2017-06-13 04:25:25 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-04-06 06:47:52 -04:00
|
|
|
context 'merge requests feature' do
|
|
|
|
subject { described_class.new(owner, project) }
|
|
|
|
|
|
|
|
it 'disallows all permissions when the feature is disabled' do
|
|
|
|
project.project_feature.update(merge_requests_access_level: ProjectFeature::DISABLED)
|
|
|
|
|
2018-04-06 08:18:58 -04:00
|
|
|
mr_permissions = [:create_merge_request_from, :read_merge_request,
|
2018-04-06 06:47:52 -04:00
|
|
|
:update_merge_request, :admin_merge_request,
|
2018-04-06 08:18:58 -04:00
|
|
|
:create_merge_request_in]
|
2018-04-06 06:47:52 -04:00
|
|
|
|
|
|
|
expect_disallowed(*mr_permissions)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2019-01-09 14:24:05 -05:00
|
|
|
context 'for a guest in a private project' do
|
|
|
|
let(:project) { create(:project, :private) }
|
|
|
|
subject { described_class.new(guest, project) }
|
|
|
|
|
|
|
|
it 'disallows the guest from reading the merge request and merge request iid' do
|
|
|
|
expect_disallowed(:read_merge_request)
|
|
|
|
expect_disallowed(:read_merge_request_iid)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-06-14 06:34:09 -04:00
|
|
|
context 'builds feature' do
|
2019-01-28 07:12:30 -05:00
|
|
|
context 'when builds are disabled' do
|
|
|
|
subject { described_class.new(owner, project) }
|
2018-06-14 06:34:09 -04:00
|
|
|
|
2019-01-28 07:12:30 -05:00
|
|
|
before do
|
|
|
|
project.project_feature.update(builds_access_level: ProjectFeature::DISABLED)
|
|
|
|
end
|
2018-06-14 06:34:09 -04:00
|
|
|
|
2019-01-28 07:12:30 -05:00
|
|
|
it 'disallows all permissions except pipeline when the feature is disabled' do
|
|
|
|
builds_permissions = [
|
|
|
|
:create_build, :read_build, :update_build, :admin_build, :destroy_build,
|
|
|
|
:create_pipeline_schedule, :read_pipeline_schedule, :update_pipeline_schedule, :admin_pipeline_schedule, :destroy_pipeline_schedule,
|
|
|
|
:create_environment, :read_environment, :update_environment, :admin_environment, :destroy_environment,
|
|
|
|
:create_cluster, :read_cluster, :update_cluster, :admin_cluster, :destroy_cluster,
|
|
|
|
:create_deployment, :read_deployment, :update_deployment, :admin_deployment, :destroy_deployment
|
|
|
|
]
|
|
|
|
|
|
|
|
expect_disallowed(*builds_permissions)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when builds are disabled only for some users' do
|
|
|
|
subject { described_class.new(guest, project) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
project.project_feature.update(builds_access_level: ProjectFeature::PRIVATE)
|
|
|
|
end
|
2018-06-14 06:34:09 -04:00
|
|
|
|
2019-01-28 07:12:30 -05:00
|
|
|
it 'disallows pipeline and commit_status permissions' do
|
|
|
|
builds_permissions = [
|
|
|
|
:create_pipeline, :update_pipeline, :admin_pipeline, :destroy_pipeline,
|
|
|
|
:create_commit_status, :update_commit_status, :admin_commit_status, :destroy_commit_status
|
|
|
|
]
|
|
|
|
|
|
|
|
expect_disallowed(*builds_permissions)
|
|
|
|
end
|
2018-06-14 06:34:09 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'repository feature' do
|
|
|
|
subject { described_class.new(owner, project) }
|
|
|
|
|
|
|
|
it 'disallows all permissions when the feature is disabled' do
|
|
|
|
project.project_feature.update(repository_access_level: ProjectFeature::DISABLED)
|
|
|
|
|
|
|
|
repository_permissions = [
|
|
|
|
:create_pipeline, :update_pipeline, :admin_pipeline, :destroy_pipeline,
|
|
|
|
:create_build, :read_build, :update_build, :admin_build, :destroy_build,
|
|
|
|
:create_pipeline_schedule, :read_pipeline_schedule, :update_pipeline_schedule, :admin_pipeline_schedule, :destroy_pipeline_schedule,
|
|
|
|
:create_environment, :read_environment, :update_environment, :admin_environment, :destroy_environment,
|
2018-10-14 20:42:02 -04:00
|
|
|
:create_cluster, :read_cluster, :update_cluster, :admin_cluster,
|
2018-12-13 06:08:53 -05:00
|
|
|
:create_deployment, :read_deployment, :update_deployment, :admin_deployment, :destroy_deployment,
|
2018-12-25 04:48:26 -05:00
|
|
|
:destroy_release
|
2018-06-14 06:34:09 -04:00
|
|
|
]
|
|
|
|
|
|
|
|
expect_disallowed(*repository_permissions)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-09-22 03:13:31 -04:00
|
|
|
it_behaves_like 'project policies as anonymous'
|
|
|
|
it_behaves_like 'project policies as guest'
|
|
|
|
it_behaves_like 'project policies as reporter'
|
|
|
|
it_behaves_like 'project policies as developer'
|
2018-07-11 10:36:08 -04:00
|
|
|
it_behaves_like 'project policies as maintainer'
|
2017-09-22 03:13:31 -04:00
|
|
|
it_behaves_like 'project policies as owner'
|
|
|
|
it_behaves_like 'project policies as admin'
|
2018-02-26 07:32:42 -05:00
|
|
|
|
|
|
|
context 'when a public project has merge requests allowing access' do
|
|
|
|
include ProjectForksHelper
|
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:target_project) { create(:project, :public) }
|
|
|
|
let(:project) { fork_project(target_project) }
|
|
|
|
let!(:merge_request) do
|
|
|
|
create(
|
|
|
|
:merge_request,
|
|
|
|
target_project: target_project,
|
|
|
|
source_project: project,
|
2018-05-22 21:54:57 -04:00
|
|
|
allow_collaboration: true
|
2018-02-26 07:32:42 -05:00
|
|
|
)
|
|
|
|
end
|
|
|
|
let(:maintainer_abilities) do
|
2018-05-15 04:18:22 -04:00
|
|
|
%w(create_build create_pipeline)
|
2018-02-26 07:32:42 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
subject { described_class.new(user, project) }
|
|
|
|
|
|
|
|
it 'does not allow pushing code' do
|
|
|
|
expect_disallowed(*maintainer_abilities)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'allows pushing if the user is a member with push access to the target project' do
|
|
|
|
target_project.add_developer(user)
|
|
|
|
|
|
|
|
expect_allowed(*maintainer_abilities)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'dissallows abilities to a maintainer if the merge request was closed' do
|
|
|
|
target_project.add_developer(user)
|
|
|
|
merge_request.close!
|
|
|
|
|
|
|
|
expect_disallowed(*maintainer_abilities)
|
|
|
|
end
|
|
|
|
end
|
2018-12-04 16:38:15 -05:00
|
|
|
|
|
|
|
it_behaves_like 'clusterable policies' do
|
|
|
|
let(:clusterable) { create(:project, :repository) }
|
|
|
|
let(:cluster) do
|
|
|
|
create(:cluster,
|
|
|
|
:provided_by_gcp,
|
|
|
|
:project,
|
|
|
|
projects: [clusterable])
|
|
|
|
end
|
|
|
|
end
|
2019-04-09 11:38:58 -04:00
|
|
|
|
|
|
|
context 'reading a project' do
|
|
|
|
it 'allows access when a user has read access to the repo' do
|
|
|
|
expect(described_class.new(owner, project)).to be_allowed(:read_project)
|
|
|
|
expect(described_class.new(developer, project)).to be_allowed(:read_project)
|
|
|
|
expect(described_class.new(admin, project)).to be_allowed(:read_project)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'never checks the external service' do
|
|
|
|
expect(::Gitlab::ExternalAuthorization).not_to receive(:access_allowed?)
|
|
|
|
|
|
|
|
expect(described_class.new(owner, project)).to be_allowed(:read_project)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with an external authorization service' do
|
|
|
|
before do
|
|
|
|
enable_external_authorization_service_check
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'allows access when the external service allows it' do
|
|
|
|
external_service_allow_access(owner, project)
|
|
|
|
external_service_allow_access(developer, project)
|
|
|
|
|
|
|
|
expect(described_class.new(owner, project)).to be_allowed(:read_project)
|
|
|
|
expect(described_class.new(developer, project)).to be_allowed(:read_project)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not check the external service for admins and allows access' do
|
|
|
|
expect(::Gitlab::ExternalAuthorization).not_to receive(:access_allowed?)
|
|
|
|
|
|
|
|
expect(described_class.new(admin, project)).to be_allowed(:read_project)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'prevents all but seeing a public project in a list when access is denied' do
|
|
|
|
[developer, owner, build(:user), nil].each do |user|
|
|
|
|
external_service_deny_access(user, project)
|
|
|
|
policy = described_class.new(user, project)
|
|
|
|
|
|
|
|
expect(policy).not_to be_allowed(:read_project)
|
|
|
|
expect(policy).not_to be_allowed(:owner_access)
|
|
|
|
expect(policy).not_to be_allowed(:change_namespace)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'passes the full path to external authorization for logging purposes' do
|
|
|
|
expect(::Gitlab::ExternalAuthorization)
|
|
|
|
.to receive(:access_allowed?).with(owner, 'default_label', project.full_path).and_call_original
|
|
|
|
|
|
|
|
described_class.new(owner, project).allowed?(:read_project)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2016-08-23 19:19:36 -04:00
|
|
|
end
|