2013-06-23 12:47:22 -04:00
|
|
|
class Projects::IssuesController < Projects::ApplicationController
|
2016-07-20 00:52:31 -04:00
|
|
|
include NotesHelper
|
2016-03-15 12:18:47 -04:00
|
|
|
include ToggleSubscriptionAction
|
2016-03-21 09:12:52 -04:00
|
|
|
include IssuableActions
|
2016-04-16 15:09:08 -04:00
|
|
|
include ToggleAwardEmoji
|
2016-07-23 19:28:12 -04:00
|
|
|
include IssuableCollections
|
2016-08-02 17:21:57 -04:00
|
|
|
include SpammableActions
|
2016-03-15 12:18:47 -04:00
|
|
|
|
2016-08-01 21:23:12 -04:00
|
|
|
before_action :redirect_to_external_issue_tracker, only: [:index, :new]
|
2015-04-16 08:03:37 -04:00
|
|
|
before_action :module_enabled
|
2016-04-21 10:34:00 -04:00
|
|
|
before_action :issue, only: [:edit, :update, :show, :referenced_merge_requests,
|
|
|
|
:related_branches, :can_create_branch]
|
2012-06-27 16:13:44 -04:00
|
|
|
|
2011-12-15 16:57:46 -05:00
|
|
|
# Allow read any issue
|
2016-03-17 15:38:51 -04:00
|
|
|
before_action :authorize_read_issue!, only: [:show]
|
2011-12-15 16:57:46 -05:00
|
|
|
|
|
|
|
# Allow write(create) issue
|
2015-06-26 10:44:21 -04:00
|
|
|
before_action :authorize_create_issue!, only: [:new, :create]
|
2011-12-15 16:57:46 -05:00
|
|
|
|
|
|
|
# Allow modify issue
|
2015-06-26 10:44:21 -04:00
|
|
|
before_action :authorize_update_issue!, only: [:edit, :update]
|
2014-02-10 08:36:58 -05:00
|
|
|
|
2013-11-29 08:05:32 -05:00
|
|
|
respond_to :html
|
2011-10-08 17:36:38 -04:00
|
|
|
|
|
|
|
def index
|
2017-01-23 15:40:25 -05:00
|
|
|
@collection_type = "Issue"
|
|
|
|
@issues = issues_collection
|
|
|
|
@issues = @issues.page(params[:page])
|
2017-02-16 15:03:42 -05:00
|
|
|
@issuable_meta_data = issuable_meta_data(@issues, @collection_type)
|
2017-01-23 15:40:25 -05:00
|
|
|
|
2016-12-20 13:52:09 -05:00
|
|
|
if @issues.out_of_range? && @issues.total_pages != 0
|
2016-12-21 10:02:05 -05:00
|
|
|
return redirect_to url_for(params.merge(page: @issues.total_pages))
|
2016-12-20 13:52:09 -05:00
|
|
|
end
|
2016-09-19 16:34:27 -04:00
|
|
|
|
2016-10-13 16:14:05 -04:00
|
|
|
if params[:label_name].present?
|
2016-09-19 16:34:27 -04:00
|
|
|
@labels = LabelsFinder.new(current_user, project_id: @project.id, title: params[:label_name]).execute
|
|
|
|
end
|
2011-11-15 04:09:07 -05:00
|
|
|
|
2017-01-20 16:35:39 -05:00
|
|
|
@users = []
|
|
|
|
|
|
|
|
if params[:assignee_id].present?
|
|
|
|
assignee = User.find_by_id(params[:assignee_id])
|
|
|
|
@users.push(assignee) if assignee
|
|
|
|
end
|
|
|
|
|
|
|
|
if params[:author_id].present?
|
|
|
|
author = User.find_by_id(params[:author_id])
|
|
|
|
@users.push(author) if author
|
|
|
|
end
|
|
|
|
|
2011-10-08 17:36:38 -04:00
|
|
|
respond_to do |format|
|
2013-11-29 08:05:32 -05:00
|
|
|
format.html
|
2012-08-10 18:07:50 -04:00
|
|
|
format.atom { render layout: false }
|
2013-11-29 08:05:32 -05:00
|
|
|
format.json do
|
|
|
|
render json: {
|
2016-04-09 00:09:09 -04:00
|
|
|
html: view_to_html_string("projects/issues/_issues"),
|
2016-04-20 12:00:12 -04:00
|
|
|
labels: @labels.as_json(methods: :text_color)
|
2013-11-29 08:05:32 -05:00
|
|
|
}
|
|
|
|
end
|
2011-10-08 17:36:38 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def new
|
2014-07-01 08:03:49 -04:00
|
|
|
params[:issue] ||= ActionController::Parameters.new(
|
|
|
|
assignee_id: ""
|
|
|
|
)
|
2016-10-26 17:21:50 -04:00
|
|
|
build_params = issue_params.merge(merge_request_for_resolving_discussions: merge_request_for_resolving_discussions)
|
|
|
|
@issue = @noteable = Issues::BuildService.new(project, current_user, build_params).execute
|
2014-07-01 08:03:49 -04:00
|
|
|
|
2011-10-08 17:36:38 -04:00
|
|
|
respond_with(@issue)
|
|
|
|
end
|
|
|
|
|
|
|
|
def edit
|
|
|
|
respond_with(@issue)
|
|
|
|
end
|
|
|
|
|
|
|
|
def show
|
2016-09-27 09:00:04 -04:00
|
|
|
raw_notes = @issue.notes.inc_relations_for_view.fresh
|
2016-06-21 07:35:09 -04:00
|
|
|
|
|
|
|
@notes = Banzai::NoteRenderer.
|
|
|
|
render(raw_notes, @project, current_user, @path, @project_wiki, @ref)
|
|
|
|
|
2016-02-09 06:02:52 -05:00
|
|
|
@note = @project.notes.new(noteable: @issue)
|
2013-12-25 15:32:48 -05:00
|
|
|
@noteable = @issue
|
2011-11-04 11:46:51 -04:00
|
|
|
|
2016-07-25 09:21:55 -04:00
|
|
|
preload_max_access_for_authors(@notes, @project)
|
2016-07-20 00:52:31 -04:00
|
|
|
|
2016-03-13 15:08:42 -04:00
|
|
|
respond_to do |format|
|
|
|
|
format.html
|
|
|
|
format.json do
|
2016-11-18 21:19:04 -05:00
|
|
|
render json: IssueSerializer.new.represent(@issue)
|
2016-03-13 15:08:42 -04:00
|
|
|
end
|
|
|
|
end
|
2011-10-08 17:36:38 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
def create
|
2017-02-14 14:07:11 -05:00
|
|
|
create_params = issue_params
|
|
|
|
.merge(merge_request_for_resolving_discussions: merge_request_for_resolving_discussions)
|
|
|
|
.merge(spammable_params)
|
2017-01-27 11:25:39 -05:00
|
|
|
|
2017-02-14 14:07:11 -05:00
|
|
|
@issue = Issues::CreateService.new(project, current_user, create_params).execute
|
2011-10-08 17:36:38 -04:00
|
|
|
|
2012-02-29 15:38:24 -05:00
|
|
|
respond_to do |format|
|
2012-08-30 13:00:16 -04:00
|
|
|
format.html do
|
2017-02-14 14:07:11 -05:00
|
|
|
recaptcha_check_with_fallback { render :new }
|
2012-08-30 13:00:16 -04:00
|
|
|
end
|
2016-07-16 12:42:44 -04:00
|
|
|
format.js do
|
2014-05-23 04:22:00 -04:00
|
|
|
@link = @issue.attachment.url.to_js
|
|
|
|
end
|
2012-02-29 15:38:24 -05:00
|
|
|
end
|
2011-10-08 17:36:38 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
def update
|
2017-02-14 14:07:11 -05:00
|
|
|
update_params = issue_params.merge(spammable_params)
|
|
|
|
|
|
|
|
@issue = Issues::UpdateService.new(project, current_user, update_params).execute(issue)
|
2011-10-08 17:36:38 -04:00
|
|
|
|
2016-03-18 09:48:55 -04:00
|
|
|
if params[:move_to_project_id].to_i > 0
|
|
|
|
new_project = Project.find(params[:move_to_project_id])
|
2016-04-30 15:14:40 -04:00
|
|
|
return render_404 unless issue.can_move?(current_user, new_project)
|
|
|
|
|
2016-03-20 04:28:06 -04:00
|
|
|
move_service = Issues::MoveService.new(project, current_user)
|
2016-03-18 09:48:55 -04:00
|
|
|
@issue = move_service.execute(@issue, new_project)
|
2016-02-17 09:59:25 -05:00
|
|
|
end
|
2011-10-08 17:36:38 -04:00
|
|
|
|
|
|
|
respond_to do |format|
|
2012-10-09 15:09:46 -04:00
|
|
|
format.html do
|
2017-02-14 14:07:11 -05:00
|
|
|
recaptcha_check_with_fallback { render :edit }
|
2012-03-25 12:05:24 -04:00
|
|
|
end
|
2016-05-25 19:08:48 -04:00
|
|
|
|
2014-06-04 11:52:35 -04:00
|
|
|
format.json do
|
2016-09-26 17:36:11 -04:00
|
|
|
render json: @issue.to_json(include: { milestone: {}, assignee: { methods: :avatar_url }, labels: { methods: :text_color } }, methods: [:task_status, :task_status_short])
|
2014-06-04 11:52:35 -04:00
|
|
|
end
|
2011-10-08 17:36:38 -04:00
|
|
|
end
|
2016-08-01 11:34:17 -04:00
|
|
|
|
|
|
|
rescue ActiveRecord::StaleObjectError
|
2017-01-16 13:43:03 -05:00
|
|
|
render_conflict_response
|
2011-10-08 17:36:38 -04:00
|
|
|
end
|
|
|
|
|
2016-04-12 09:55:54 -04:00
|
|
|
def referenced_merge_requests
|
|
|
|
@merge_requests = @issue.referenced_merge_requests(current_user)
|
|
|
|
@closed_by_merge_requests = @issue.closed_by_merge_requests(current_user)
|
|
|
|
|
|
|
|
respond_to do |format|
|
|
|
|
format.json do
|
|
|
|
render json: {
|
|
|
|
html: view_to_html_string('projects/issues/_merge_requests')
|
|
|
|
}
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def related_branches
|
2016-04-15 00:20:53 -04:00
|
|
|
@related_branches = @issue.related_branches(current_user)
|
2016-04-12 09:55:54 -04:00
|
|
|
|
|
|
|
respond_to do |format|
|
|
|
|
format.json do
|
|
|
|
render json: {
|
|
|
|
html: view_to_html_string('projects/issues/_related_branches')
|
|
|
|
}
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-04-21 10:34:00 -04:00
|
|
|
def can_create_branch
|
|
|
|
can_create = current_user &&
|
|
|
|
can?(current_user, :push_code, @project) &&
|
|
|
|
@issue.can_be_worked_on?(current_user)
|
|
|
|
|
|
|
|
respond_to do |format|
|
|
|
|
format.json do
|
|
|
|
render json: { can_create_branch: can_create }
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2011-10-26 09:46:25 -04:00
|
|
|
protected
|
2011-10-17 06:39:03 -04:00
|
|
|
|
|
|
|
def issue
|
2016-10-06 15:09:55 -04:00
|
|
|
# The Sortable default scope causes performance issues when used with find_by
|
|
|
|
@noteable = @issue ||= @project.issues.where(iid: params[:id]).reorder(nil).take || redirect_old
|
2011-10-17 06:39:03 -04:00
|
|
|
end
|
2016-03-15 12:18:47 -04:00
|
|
|
alias_method :subscribable_resource, :issue
|
2016-03-21 09:12:52 -04:00
|
|
|
alias_method :issuable, :issue
|
2016-04-16 15:09:08 -04:00
|
|
|
alias_method :awardable, :issue
|
2016-08-02 17:21:57 -04:00
|
|
|
alias_method :spammable, :issue
|
2011-12-15 16:57:46 -05:00
|
|
|
|
2016-10-26 17:21:50 -04:00
|
|
|
def merge_request_for_resolving_discussions
|
|
|
|
return unless merge_request_iid = params[:merge_request_for_resolving_discussions]
|
|
|
|
|
|
|
|
@merge_request_for_resolving_discussions ||= MergeRequestsFinder.new(current_user, project_id: project.id).
|
|
|
|
execute.
|
|
|
|
find_by(iid: merge_request_iid)
|
|
|
|
end
|
|
|
|
|
2016-03-17 15:38:51 -04:00
|
|
|
def authorize_read_issue!
|
|
|
|
return render_404 unless can?(current_user, :read_issue, @issue)
|
|
|
|
end
|
|
|
|
|
2015-06-26 10:44:21 -04:00
|
|
|
def authorize_update_issue!
|
2015-06-26 09:55:56 -04:00
|
|
|
return render_404 unless can?(current_user, :update_issue, @issue)
|
2011-12-15 16:57:46 -05:00
|
|
|
end
|
|
|
|
|
2014-02-10 08:36:58 -05:00
|
|
|
def authorize_admin_issues!
|
|
|
|
return render_404 unless can?(current_user, :admin_issue, @project)
|
2011-12-15 16:57:46 -05:00
|
|
|
end
|
2012-02-06 12:40:32 -05:00
|
|
|
|
|
|
|
def module_enabled
|
2016-08-01 18:31:21 -04:00
|
|
|
return render_404 unless @project.feature_available?(:issues, current_user) && @project.default_issues_tracker?
|
2012-02-06 12:40:32 -05:00
|
|
|
end
|
2012-06-12 04:31:38 -04:00
|
|
|
|
2016-08-01 19:59:44 -04:00
|
|
|
def redirect_to_external_issue_tracker
|
2016-08-01 21:23:12 -04:00
|
|
|
external = @project.external_issue_tracker
|
2016-08-01 19:59:44 -04:00
|
|
|
|
2016-08-01 21:23:12 -04:00
|
|
|
return unless external
|
|
|
|
|
|
|
|
if action_name == 'new'
|
|
|
|
redirect_to external.new_issue_path
|
|
|
|
else
|
2016-08-24 23:06:16 -04:00
|
|
|
redirect_to external.project_path
|
2016-08-01 21:23:12 -04:00
|
|
|
end
|
2016-08-01 19:59:44 -04:00
|
|
|
end
|
|
|
|
|
2013-08-26 07:15:21 -04:00
|
|
|
# Since iids are implemented only in 6.1
|
|
|
|
# user may navigate to issue page using old global ids.
|
|
|
|
#
|
|
|
|
# To prevent 404 errors we provide a redirect to correct iids until 7.0 release
|
|
|
|
#
|
|
|
|
def redirect_old
|
2014-01-19 13:55:59 -05:00
|
|
|
issue = @project.issues.find_by(id: params[:id])
|
2013-08-26 07:15:21 -04:00
|
|
|
|
|
|
|
if issue
|
2015-02-25 22:50:01 -05:00
|
|
|
redirect_to issue_path(issue)
|
2013-08-26 07:15:21 -04:00
|
|
|
else
|
|
|
|
raise ActiveRecord::RecordNotFound.new
|
|
|
|
end
|
|
|
|
end
|
2014-06-26 07:30:07 -04:00
|
|
|
|
|
|
|
def issue_params
|
2015-11-26 10:16:50 -05:00
|
|
|
params.require(:issue).permit(
|
2016-03-17 15:16:48 -04:00
|
|
|
:title, :assignee_id, :position, :description, :confidential,
|
2016-08-01 11:34:17 -04:00
|
|
|
:milestone_id, :due_date, :state_event, :task_num, :lock_version, label_ids: []
|
2014-06-26 07:30:07 -04:00
|
|
|
)
|
|
|
|
end
|
2011-10-08 17:36:38 -04:00
|
|
|
end
|