2013-12-04 06:20:16 -05:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2017-04-21 16:32:02 -04:00
|
|
|
describe API::ProjectHooks, 'ProjectHooks' do
|
2013-12-04 06:20:16 -05:00
|
|
|
let(:user) { create(:user) }
|
|
|
|
let(:user3) { create(:user) }
|
2017-08-02 15:55:11 -04:00
|
|
|
let!(:project) { create(:project, creator_id: user.id, namespace: user.namespace) }
|
2015-12-07 07:23:23 -05:00
|
|
|
let!(:hook) do
|
|
|
|
create(:project_hook,
|
2016-08-12 04:48:47 -04:00
|
|
|
:all_events_enabled,
|
|
|
|
project: project,
|
|
|
|
url: 'http://example.com',
|
2015-12-07 07:23:23 -05:00
|
|
|
enable_ssl_verification: true)
|
|
|
|
end
|
2013-12-04 06:20:16 -05:00
|
|
|
|
|
|
|
before do
|
2017-12-22 03:18:28 -05:00
|
|
|
project.add_master(user)
|
|
|
|
project.add_developer(user3)
|
2013-12-04 06:20:16 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
describe "GET /projects/:id/hooks" do
|
|
|
|
context "authorized user" do
|
2016-08-01 11:00:44 -04:00
|
|
|
it "returns project hooks" do
|
2013-12-04 06:20:16 -05:00
|
|
|
get api("/projects/#{project.id}/hooks", user)
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(json_response).to be_an Array
|
2017-01-24 15:49:10 -05:00
|
|
|
expect(response).to include_pagination_headers
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(json_response.count).to eq(1)
|
|
|
|
expect(json_response.first['url']).to eq("http://example.com")
|
2015-09-24 14:16:36 -04:00
|
|
|
expect(json_response.first['issues_events']).to eq(true)
|
2018-02-26 12:35:04 -05:00
|
|
|
expect(json_response.first['confidential_issues_events']).to eq(true)
|
2015-09-24 14:16:36 -04:00
|
|
|
expect(json_response.first['push_events']).to eq(true)
|
|
|
|
expect(json_response.first['merge_requests_events']).to eq(true)
|
|
|
|
expect(json_response.first['tag_push_events']).to eq(true)
|
|
|
|
expect(json_response.first['note_events']).to eq(true)
|
2018-04-03 07:00:33 -04:00
|
|
|
expect(json_response.first['confidential_note_events']).to eq(true)
|
2017-03-03 10:39:29 -05:00
|
|
|
expect(json_response.first['job_events']).to eq(true)
|
2016-08-02 06:06:31 -04:00
|
|
|
expect(json_response.first['pipeline_events']).to eq(true)
|
2016-08-23 14:54:44 -04:00
|
|
|
expect(json_response.first['wiki_page_events']).to eq(true)
|
2015-09-24 14:16:36 -04:00
|
|
|
expect(json_response.first['enable_ssl_verification']).to eq(true)
|
2013-12-04 06:20:16 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "unauthorized user" do
|
2016-08-01 11:00:44 -04:00
|
|
|
it "does not access project hooks" do
|
2013-12-04 06:20:16 -05:00
|
|
|
get api("/projects/#{project.id}/hooks", user3)
|
2017-04-10 06:05:29 -04:00
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(403)
|
2013-12-04 06:20:16 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "GET /projects/:id/hooks/:hook_id" do
|
|
|
|
context "authorized user" do
|
2016-08-01 11:00:44 -04:00
|
|
|
it "returns a project hook" do
|
2013-12-04 06:20:16 -05:00
|
|
|
get api("/projects/#{project.id}/hooks/#{hook.id}", user)
|
2017-04-10 06:05:29 -04:00
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(json_response['url']).to eq(hook.url)
|
2015-09-24 14:16:36 -04:00
|
|
|
expect(json_response['issues_events']).to eq(hook.issues_events)
|
2018-02-26 12:35:04 -05:00
|
|
|
expect(json_response['confidential_issues_events']).to eq(hook.confidential_issues_events)
|
2015-09-24 14:16:36 -04:00
|
|
|
expect(json_response['push_events']).to eq(hook.push_events)
|
|
|
|
expect(json_response['merge_requests_events']).to eq(hook.merge_requests_events)
|
|
|
|
expect(json_response['tag_push_events']).to eq(hook.tag_push_events)
|
|
|
|
expect(json_response['note_events']).to eq(hook.note_events)
|
2018-04-03 07:00:33 -04:00
|
|
|
expect(json_response['confidential_note_events']).to eq(hook.confidential_note_events)
|
2017-05-15 11:11:45 -04:00
|
|
|
expect(json_response['job_events']).to eq(hook.job_events)
|
2016-08-23 14:51:05 -04:00
|
|
|
expect(json_response['pipeline_events']).to eq(hook.pipeline_events)
|
2016-08-23 14:54:44 -04:00
|
|
|
expect(json_response['wiki_page_events']).to eq(hook.wiki_page_events)
|
2015-09-24 14:16:36 -04:00
|
|
|
expect(json_response['enable_ssl_verification']).to eq(hook.enable_ssl_verification)
|
2013-12-04 06:20:16 -05:00
|
|
|
end
|
|
|
|
|
2016-08-01 11:00:44 -04:00
|
|
|
it "returns a 404 error if hook id is not available" do
|
2013-12-04 06:20:16 -05:00
|
|
|
get api("/projects/#{project.id}/hooks/1234", user)
|
2017-04-10 06:05:29 -04:00
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(404)
|
2013-12-04 06:20:16 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "unauthorized user" do
|
2016-08-01 11:00:44 -04:00
|
|
|
it "does not access an existing hook" do
|
2013-12-04 06:20:16 -05:00
|
|
|
get api("/projects/#{project.id}/hooks/#{hook.id}", user3)
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(403)
|
2013-12-04 06:20:16 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2016-08-01 11:00:44 -04:00
|
|
|
it "returns a 404 error if hook id is not available" do
|
2013-12-04 06:20:16 -05:00
|
|
|
get api("/projects/#{project.id}/hooks/1234", user)
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(404)
|
2013-12-04 06:20:16 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "POST /projects/:id/hooks" do
|
2016-08-01 11:00:44 -04:00
|
|
|
it "adds hook to project" do
|
2015-06-22 16:00:54 -04:00
|
|
|
expect do
|
2017-01-03 15:07:12 -05:00
|
|
|
post api("/projects/#{project.id}/hooks", user),
|
2018-02-26 12:35:04 -05:00
|
|
|
url: "http://example.com", issues_events: true, confidential_issues_events: true, wiki_page_events: true,
|
2017-04-10 06:05:29 -04:00
|
|
|
job_events: true
|
2015-06-22 16:00:54 -04:00
|
|
|
end.to change {project.hooks.count}.by(1)
|
2016-11-01 07:40:06 -04:00
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(201)
|
2015-09-24 14:16:36 -04:00
|
|
|
expect(json_response['url']).to eq('http://example.com')
|
|
|
|
expect(json_response['issues_events']).to eq(true)
|
2018-02-26 12:35:04 -05:00
|
|
|
expect(json_response['confidential_issues_events']).to eq(true)
|
2015-09-24 14:16:36 -04:00
|
|
|
expect(json_response['push_events']).to eq(true)
|
|
|
|
expect(json_response['merge_requests_events']).to eq(false)
|
|
|
|
expect(json_response['tag_push_events']).to eq(false)
|
|
|
|
expect(json_response['note_events']).to eq(false)
|
2018-04-03 07:00:33 -04:00
|
|
|
expect(json_response['confidential_note_events']).to eq(nil)
|
2017-04-10 06:05:29 -04:00
|
|
|
expect(json_response['job_events']).to eq(true)
|
2016-08-02 06:06:31 -04:00
|
|
|
expect(json_response['pipeline_events']).to eq(false)
|
2017-01-03 15:07:12 -05:00
|
|
|
expect(json_response['wiki_page_events']).to eq(true)
|
2015-09-24 14:16:36 -04:00
|
|
|
expect(json_response['enable_ssl_verification']).to eq(true)
|
2016-11-01 07:40:06 -04:00
|
|
|
expect(json_response).not_to include('token')
|
|
|
|
end
|
|
|
|
|
|
|
|
it "adds the token without including it in the response" do
|
|
|
|
token = "secret token"
|
|
|
|
|
|
|
|
expect do
|
|
|
|
post api("/projects/#{project.id}/hooks", user), url: "http://example.com", token: token
|
|
|
|
end.to change {project.hooks.count}.by(1)
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(201)
|
2016-11-01 07:40:06 -04:00
|
|
|
expect(json_response["url"]).to eq("http://example.com")
|
|
|
|
expect(json_response).not_to include("token")
|
|
|
|
|
|
|
|
hook = project.hooks.find(json_response["id"])
|
|
|
|
|
|
|
|
expect(hook.url).to eq("http://example.com")
|
|
|
|
expect(hook.token).to eq(token)
|
2013-12-04 06:20:16 -05:00
|
|
|
end
|
|
|
|
|
2016-08-01 11:00:44 -04:00
|
|
|
it "returns a 400 error if url not given" do
|
2013-12-04 06:20:16 -05:00
|
|
|
post api("/projects/#{project.id}/hooks", user)
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(400)
|
2013-12-04 06:20:16 -05:00
|
|
|
end
|
|
|
|
|
2016-08-01 11:00:44 -04:00
|
|
|
it "returns a 422 error if url not valid" do
|
2013-12-04 06:20:16 -05:00
|
|
|
post api("/projects/#{project.id}/hooks", user), "url" => "ftp://example.com"
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(422)
|
2013-12-04 06:20:16 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "PUT /projects/:id/hooks/:hook_id" do
|
2016-08-01 11:00:44 -04:00
|
|
|
it "updates an existing project hook" do
|
2013-12-04 06:20:16 -05:00
|
|
|
put api("/projects/#{project.id}/hooks/#{hook.id}", user),
|
2017-04-10 06:05:29 -04:00
|
|
|
url: 'http://example.org', push_events: false, job_events: true
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(json_response['url']).to eq('http://example.org')
|
2015-09-24 14:16:36 -04:00
|
|
|
expect(json_response['issues_events']).to eq(hook.issues_events)
|
2018-02-26 12:35:04 -05:00
|
|
|
expect(json_response['confidential_issues_events']).to eq(hook.confidential_issues_events)
|
2015-09-24 14:16:36 -04:00
|
|
|
expect(json_response['push_events']).to eq(false)
|
|
|
|
expect(json_response['merge_requests_events']).to eq(hook.merge_requests_events)
|
|
|
|
expect(json_response['tag_push_events']).to eq(hook.tag_push_events)
|
|
|
|
expect(json_response['note_events']).to eq(hook.note_events)
|
2018-04-03 07:00:33 -04:00
|
|
|
expect(json_response['confidential_note_events']).to eq(hook.confidential_note_events)
|
2017-05-15 11:11:45 -04:00
|
|
|
expect(json_response['job_events']).to eq(hook.job_events)
|
2016-08-23 14:51:05 -04:00
|
|
|
expect(json_response['pipeline_events']).to eq(hook.pipeline_events)
|
2016-08-23 14:54:44 -04:00
|
|
|
expect(json_response['wiki_page_events']).to eq(hook.wiki_page_events)
|
2015-09-24 14:16:36 -04:00
|
|
|
expect(json_response['enable_ssl_verification']).to eq(hook.enable_ssl_verification)
|
2016-11-01 07:40:06 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "adds the token without including it in the response" do
|
|
|
|
token = "secret token"
|
|
|
|
|
|
|
|
put api("/projects/#{project.id}/hooks/#{hook.id}", user), url: "http://example.org", token: token
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(200)
|
2016-11-01 07:40:06 -04:00
|
|
|
expect(json_response["url"]).to eq("http://example.org")
|
|
|
|
expect(json_response).not_to include("token")
|
|
|
|
|
|
|
|
expect(hook.reload.url).to eq("http://example.org")
|
|
|
|
expect(hook.reload.token).to eq(token)
|
2013-12-04 06:20:16 -05:00
|
|
|
end
|
|
|
|
|
2016-08-01 11:00:44 -04:00
|
|
|
it "returns 404 error if hook id not found" do
|
2013-12-04 06:20:16 -05:00
|
|
|
put api("/projects/#{project.id}/hooks/1234", user), url: 'http://example.org'
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(404)
|
2013-12-04 06:20:16 -05:00
|
|
|
end
|
|
|
|
|
2016-08-01 11:00:44 -04:00
|
|
|
it "returns 400 error if url is not given" do
|
2013-12-04 06:20:16 -05:00
|
|
|
put api("/projects/#{project.id}/hooks/#{hook.id}", user)
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(400)
|
2013-12-04 06:20:16 -05:00
|
|
|
end
|
|
|
|
|
2016-08-01 11:00:44 -04:00
|
|
|
it "returns a 422 error if url is not valid" do
|
2013-12-04 06:20:16 -05:00
|
|
|
put api("/projects/#{project.id}/hooks/#{hook.id}", user), url: 'ftp://example.com'
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(422)
|
2013-12-04 06:20:16 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "DELETE /projects/:id/hooks/:hook_id" do
|
2016-08-01 11:00:44 -04:00
|
|
|
it "deletes hook from project" do
|
2015-06-22 16:00:54 -04:00
|
|
|
expect do
|
2013-12-04 06:20:16 -05:00
|
|
|
delete api("/projects/#{project.id}/hooks/#{hook.id}", user)
|
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(204)
|
2017-02-20 13:18:12 -05:00
|
|
|
end.to change {project.hooks.count}.by(-1)
|
2013-12-04 06:20:16 -05:00
|
|
|
end
|
|
|
|
|
2016-08-01 11:00:44 -04:00
|
|
|
it "returns a 404 error when deleting non existent hook" do
|
2013-12-04 06:20:16 -05:00
|
|
|
delete api("/projects/#{project.id}/hooks/42", user)
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(404)
|
2013-12-04 06:20:16 -05:00
|
|
|
end
|
|
|
|
|
2016-10-07 13:18:02 -04:00
|
|
|
it "returns a 404 error if hook id not given" do
|
2013-12-04 06:20:16 -05:00
|
|
|
delete api("/projects/#{project.id}/hooks", user)
|
2016-10-07 11:39:04 -04:00
|
|
|
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(404)
|
2013-12-04 06:20:16 -05:00
|
|
|
end
|
2016-04-25 01:39:18 -04:00
|
|
|
|
2016-08-01 11:00:44 -04:00
|
|
|
it "returns a 404 if a user attempts to delete project hooks he/she does not own" do
|
2016-04-25 01:39:18 -04:00
|
|
|
test_user = create(:user)
|
2017-08-02 15:55:11 -04:00
|
|
|
other_project = create(:project)
|
2017-12-22 03:18:28 -05:00
|
|
|
other_project.add_master(test_user)
|
2016-04-25 01:39:18 -04:00
|
|
|
|
|
|
|
delete api("/projects/#{other_project.id}/hooks/#{hook.id}", test_user)
|
2017-10-19 14:28:19 -04:00
|
|
|
expect(response).to have_gitlab_http_status(404)
|
2016-04-25 01:39:18 -04:00
|
|
|
expect(WebHook.exists?(hook.id)).to be_truthy
|
|
|
|
end
|
2017-08-24 12:03:39 -04:00
|
|
|
|
|
|
|
it_behaves_like '412 response' do
|
|
|
|
let(:request) { api("/projects/#{project.id}/hooks/#{hook.id}", user) }
|
|
|
|
end
|
2013-12-04 06:20:16 -05:00
|
|
|
end
|
|
|
|
end
|