2019-10-25 09:06:06 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2018-07-27 05:04:35 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-24 06:09:01 +00:00
|
|
|
RSpec.describe Ci::BuildRunnerPresenter do
|
2018-07-27 05:04:35 +00:00
|
|
|
let(:presenter) { described_class.new(build) }
|
|
|
|
let(:archive) { { paths: ['sample.txt'] } }
|
|
|
|
|
|
|
|
let(:archive_expectation) do
|
|
|
|
{
|
|
|
|
artifact_type: :archive,
|
|
|
|
artifact_format: :zip,
|
|
|
|
paths: archive[:paths],
|
|
|
|
untracked: archive[:untracked]
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#artifacts' do
|
|
|
|
context "when option contains archive-type artifacts" do
|
|
|
|
let(:build) { create(:ci_build, options: { artifacts: archive } ) }
|
|
|
|
|
|
|
|
it 'presents correct hash' do
|
|
|
|
expect(presenter.artifacts.first).to include(archive_expectation)
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when untracked is specified" do
|
|
|
|
let(:archive) { { untracked: true } }
|
|
|
|
|
|
|
|
it 'presents correct hash' do
|
|
|
|
expect(presenter.artifacts.first).to include(archive_expectation)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when untracked and paths are missing" do
|
|
|
|
let(:archive) { { when: 'always' } }
|
|
|
|
|
|
|
|
it 'does not present hash' do
|
|
|
|
expect(presenter.artifacts).to be_empty
|
|
|
|
end
|
|
|
|
end
|
2020-05-13 18:08:47 +00:00
|
|
|
|
|
|
|
context 'when artifacts exclude is defined' do
|
|
|
|
let(:build) do
|
|
|
|
create(:ci_build, options: { artifacts: { paths: %w[abc], exclude: %w[cde] } })
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the feature is enabled' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(ci_artifacts_exclude: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'includes the list of excluded paths' do
|
|
|
|
expect(presenter.artifacts.first).to include(
|
|
|
|
artifact_type: :archive,
|
|
|
|
artifact_format: :zip,
|
|
|
|
paths: %w[abc],
|
|
|
|
exclude: %w[cde]
|
|
|
|
)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the feature is disabled' do
|
|
|
|
before do
|
|
|
|
stub_feature_flags(ci_artifacts_exclude: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not include the list of excluded paths' do
|
|
|
|
expect(presenter.artifacts.first).not_to have_key(:exclude)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when artifacts exclude is not defined' do
|
|
|
|
let(:build) do
|
|
|
|
create(:ci_build, options: { artifacts: { paths: %w[abc] } })
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not include an empty list of excluded paths' do
|
|
|
|
expect(presenter.artifacts.first).not_to have_key(:exclude)
|
|
|
|
end
|
|
|
|
end
|
2018-07-27 05:04:35 +00:00
|
|
|
end
|
|
|
|
|
2018-09-27 21:15:08 +00:00
|
|
|
context "with reports" do
|
|
|
|
Ci::JobArtifact::DEFAULT_FILE_NAMES.each do |file_type, filename|
|
2018-10-15 10:17:21 +00:00
|
|
|
context file_type.to_s do
|
|
|
|
let(:report) { { "#{file_type}": [filename] } }
|
|
|
|
let(:build) { create(:ci_build, options: { artifacts: { reports: report } } ) }
|
2018-09-27 21:15:08 +00:00
|
|
|
|
2018-10-15 10:17:21 +00:00
|
|
|
let(:report_expectation) do
|
|
|
|
{
|
|
|
|
name: filename,
|
|
|
|
artifact_type: :"#{file_type}",
|
|
|
|
artifact_format: Ci::JobArtifact::TYPE_AND_FORMAT_PAIRS.fetch(file_type),
|
|
|
|
paths: [filename],
|
|
|
|
when: 'always'
|
|
|
|
}
|
|
|
|
end
|
2018-07-27 05:04:35 +00:00
|
|
|
|
2018-10-15 10:17:21 +00:00
|
|
|
it 'presents correct hash' do
|
|
|
|
expect(presenter.artifacts.first).to include(report_expectation)
|
|
|
|
end
|
2018-09-27 21:15:08 +00:00
|
|
|
end
|
2018-07-27 05:04:35 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when option has both archive and reports specification" do
|
2018-09-27 21:15:08 +00:00
|
|
|
let(:report) { { junit: ['junit.xml'] } }
|
|
|
|
let(:build) { create(:ci_build, options: { script: 'echo', artifacts: { **archive, reports: report } } ) }
|
|
|
|
|
|
|
|
let(:report_expectation) do
|
|
|
|
{
|
|
|
|
name: 'junit.xml',
|
|
|
|
artifact_type: :junit,
|
|
|
|
artifact_format: :gzip,
|
|
|
|
paths: ['junit.xml'],
|
|
|
|
when: 'always'
|
|
|
|
}
|
|
|
|
end
|
2018-07-27 05:04:35 +00:00
|
|
|
|
|
|
|
it 'presents correct hash' do
|
|
|
|
expect(presenter.artifacts.first).to include(archive_expectation)
|
2018-09-27 21:15:08 +00:00
|
|
|
expect(presenter.artifacts.second).to include(report_expectation)
|
2018-07-27 05:04:35 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context "when archive specifies 'expire_in' keyword" do
|
|
|
|
let(:archive) { { paths: ['sample.txt'], expire_in: '3 mins 4 sec' } }
|
|
|
|
|
|
|
|
it 'inherits expire_in from archive' do
|
|
|
|
expect(presenter.artifacts.first).to include({ **archive_expectation, expire_in: '3 mins 4 sec' })
|
2018-09-27 21:15:08 +00:00
|
|
|
expect(presenter.artifacts.second).to include({ **report_expectation, expire_in: '3 mins 4 sec' })
|
2018-07-27 05:04:35 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when option has no artifact keywords" do
|
|
|
|
let(:build) { create(:ci_build, :no_options) }
|
|
|
|
|
|
|
|
it 'does not present hash' do
|
|
|
|
expect(presenter.artifacts).to be_nil
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2019-02-14 06:25:10 +00:00
|
|
|
|
|
|
|
describe '#ref_type' do
|
|
|
|
subject { presenter.ref_type }
|
|
|
|
|
|
|
|
let(:build) { create(:ci_build, tag: tag) }
|
|
|
|
let(:tag) { true }
|
|
|
|
|
|
|
|
it 'returns the correct ref type' do
|
|
|
|
is_expected.to eq('tag')
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when tag is false' do
|
|
|
|
let(:tag) { false }
|
|
|
|
|
|
|
|
it 'returns the correct ref type' do
|
|
|
|
is_expected.to eq('branch')
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#git_depth' do
|
|
|
|
let(:build) { create(:ci_build) }
|
|
|
|
|
2019-05-30 06:40:53 +00:00
|
|
|
subject(:git_depth) { presenter.git_depth }
|
2019-02-14 06:25:10 +00:00
|
|
|
|
|
|
|
context 'when GIT_DEPTH variable is specified' do
|
|
|
|
before do
|
|
|
|
create(:ci_pipeline_variable, key: 'GIT_DEPTH', value: 1, pipeline: build.pipeline)
|
|
|
|
end
|
|
|
|
|
2019-05-30 06:40:53 +00:00
|
|
|
it 'returns its value' do
|
|
|
|
expect(git_depth).to eq(1)
|
2019-02-14 06:25:10 +00:00
|
|
|
end
|
|
|
|
end
|
2019-05-30 06:40:53 +00:00
|
|
|
|
|
|
|
it 'defaults to git depth setting for the project' do
|
2019-06-07 11:51:42 +00:00
|
|
|
expect(git_depth).to eq(build.project.ci_default_git_depth)
|
2019-05-30 06:40:53 +00:00
|
|
|
end
|
2019-02-14 06:25:10 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
describe '#refspecs' do
|
|
|
|
subject { presenter.refspecs }
|
|
|
|
|
|
|
|
let(:build) { create(:ci_build) }
|
2020-05-18 15:08:15 +00:00
|
|
|
let(:pipeline) { build.pipeline }
|
2019-02-14 06:25:10 +00:00
|
|
|
|
|
|
|
it 'returns the correct refspecs' do
|
2020-05-18 15:08:15 +00:00
|
|
|
is_expected.to contain_exactly("+refs/heads/#{build.ref}:refs/remotes/origin/#{build.ref}",
|
2021-01-14 06:11:16 +00:00
|
|
|
"+#{pipeline.sha}:refs/pipelines/#{pipeline.id}")
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'uses a SHA in the persistent refspec' do
|
|
|
|
expect(subject[0]).to match(/^\+[0-9a-f]{40}:refs\/pipelines\/[0-9]+$/)
|
|
|
|
end
|
|
|
|
|
2019-05-30 06:40:53 +00:00
|
|
|
context 'when ref is tag' do
|
|
|
|
let(:build) { create(:ci_build, :tag) }
|
2019-02-14 06:25:10 +00:00
|
|
|
|
|
|
|
it 'returns the correct refspecs' do
|
2020-05-18 15:08:15 +00:00
|
|
|
is_expected.to contain_exactly("+refs/tags/#{build.ref}:refs/tags/#{build.ref}",
|
2021-01-14 06:11:16 +00:00
|
|
|
"+#{pipeline.sha}:refs/pipelines/#{pipeline.id}")
|
2019-02-14 06:25:10 +00:00
|
|
|
end
|
|
|
|
|
2019-05-30 06:40:53 +00:00
|
|
|
context 'when GIT_DEPTH is zero' do
|
|
|
|
before do
|
|
|
|
create(:ci_pipeline_variable, key: 'GIT_DEPTH', value: 0, pipeline: build.pipeline)
|
|
|
|
end
|
2019-02-14 06:25:10 +00:00
|
|
|
|
|
|
|
it 'returns the correct refspecs' do
|
2019-05-30 06:40:53 +00:00
|
|
|
is_expected.to contain_exactly('+refs/tags/*:refs/tags/*',
|
2020-05-18 15:08:15 +00:00
|
|
|
'+refs/heads/*:refs/remotes/origin/*',
|
2021-01-14 06:11:16 +00:00
|
|
|
"+#{pipeline.sha}:refs/pipelines/#{pipeline.id}")
|
2019-02-14 06:25:10 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2019-03-21 13:08:32 +00:00
|
|
|
|
|
|
|
context 'when pipeline is detached merge request pipeline' do
|
|
|
|
let(:merge_request) { create(:merge_request, :with_detached_merge_request_pipeline) }
|
|
|
|
let(:pipeline) { merge_request.all_pipelines.first }
|
|
|
|
let(:build) { create(:ci_build, ref: pipeline.ref, pipeline: pipeline) }
|
|
|
|
|
2020-05-06 12:09:36 +00:00
|
|
|
before do
|
|
|
|
pipeline.persistent_ref.create
|
|
|
|
end
|
2020-01-02 13:03:23 +00:00
|
|
|
|
2020-05-06 12:09:36 +00:00
|
|
|
it 'returns the correct refspecs' do
|
|
|
|
is_expected
|
2021-01-14 06:11:16 +00:00
|
|
|
.to contain_exactly("+#{pipeline.sha}:refs/pipelines/#{pipeline.id}")
|
2019-03-21 13:08:32 +00:00
|
|
|
end
|
|
|
|
|
2020-05-06 12:09:36 +00:00
|
|
|
context 'when GIT_DEPTH is zero' do
|
2020-01-02 13:03:23 +00:00
|
|
|
before do
|
2020-05-06 12:09:36 +00:00
|
|
|
create(:ci_pipeline_variable, key: 'GIT_DEPTH', value: 0, pipeline: build.pipeline)
|
2020-01-02 13:03:23 +00:00
|
|
|
end
|
2019-03-21 13:08:32 +00:00
|
|
|
|
|
|
|
it 'returns the correct refspecs' do
|
2020-01-02 13:03:23 +00:00
|
|
|
is_expected
|
2021-01-14 06:11:16 +00:00
|
|
|
.to contain_exactly("+#{pipeline.sha}:refs/pipelines/#{pipeline.id}",
|
2020-05-06 12:09:36 +00:00
|
|
|
'+refs/heads/*:refs/remotes/origin/*',
|
|
|
|
'+refs/tags/*:refs/tags/*')
|
2020-01-02 13:03:23 +00:00
|
|
|
end
|
2020-05-06 12:09:36 +00:00
|
|
|
end
|
2020-01-02 13:03:23 +00:00
|
|
|
|
2020-05-06 12:09:36 +00:00
|
|
|
context 'when pipeline is legacy detached merge request pipeline' do
|
|
|
|
let(:merge_request) { create(:merge_request, :with_legacy_detached_merge_request_pipeline) }
|
2020-01-02 13:03:23 +00:00
|
|
|
|
2020-05-06 12:09:36 +00:00
|
|
|
it 'returns the correct refspecs' do
|
2021-01-14 06:11:16 +00:00
|
|
|
is_expected.to contain_exactly("+#{pipeline.sha}:refs/pipelines/#{pipeline.id}",
|
2020-05-06 12:09:36 +00:00
|
|
|
"+refs/heads/#{build.ref}:refs/remotes/origin/#{build.ref}")
|
2019-03-21 13:08:32 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2019-09-27 18:06:20 +00:00
|
|
|
|
|
|
|
context 'when persistent pipeline ref exists' do
|
|
|
|
let(:project) { create(:project, :repository) }
|
|
|
|
let(:sha) { project.repository.commit.sha }
|
|
|
|
let(:pipeline) { create(:ci_pipeline, sha: sha, project: project) }
|
|
|
|
let(:build) { create(:ci_build, pipeline: pipeline) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
pipeline.persistent_ref.create
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'exposes the persistent pipeline ref' do
|
|
|
|
is_expected
|
2021-01-14 06:11:16 +00:00
|
|
|
.to contain_exactly("+#{pipeline.sha}:refs/pipelines/#{pipeline.id}",
|
2019-09-27 18:06:20 +00:00
|
|
|
"+refs/heads/#{build.ref}:refs/remotes/origin/#{build.ref}")
|
|
|
|
end
|
|
|
|
end
|
2019-02-14 06:25:10 +00:00
|
|
|
end
|
2018-07-27 05:04:35 +00:00
|
|
|
end
|