2018-07-25 05:30:33 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2019-03-28 09:17:42 -04:00
|
|
|
class MergeRequestsClosingIssues < ApplicationRecord
|
Improve performance of the cycle analytics page.
1. These changes bring down page load time for 100 issues from more than
a minute to about 1.5 seconds.
2. This entire commit is composed of these types of performance
enhancements:
- Cache relevant data in `IssueMetrics` wherever possible.
- Cache relevant data in `MergeRequestMetrics` wherever possible.
- Preload metrics
3. Given these improvements, we now only need to make 4 SQL calls:
- Load all issues
- Load all merge requests
- Load all metrics for the issues
- Load all metrics for the merge requests
4. A list of all the data points that are now being pre-calculated:
a. The first time an issue is mentioned in a commit
- In `GitPushService`, find all issues mentioned by the given commit
using `ReferenceExtractor`. Set the `first_mentioned_in_commit_at`
flag for each of them.
- There seems to be a (pre-existing) bug here - files (and
therefore commits) created using the Web CI don't have
cross-references created, and issues are not closed even when
the commit title is "Fixes #xx".
b. The first time a merge request is deployed to production
When a `Deployment` is created, find all merge requests that
were merged in before the deployment, and set the
`first_deployed_to_production_at` flag for each of them.
c. The start / end time for a merge request pipeline
Hook into the `Pipeline` state machine. When the `status` moves to
`running`, find the merge requests whose tip commit matches the
pipeline, and record the `latest_build_started_at` time for each
of them. When the `status` moves to `success`, record the
`latest_build_finished_at` time.
d. The merge requests that close an issue
- This was a big cause of the performance problems we were having
with Cycle Analytics. We need to use `ReferenceExtractor` to make
this calculation, which is slow when we have to run it on a large
number of merge requests.
- When a merge request is created, updated, or refreshed, find the
issues it closes, and create an instance of
`MergeRequestsClosingIssues`, which acts as a join model between
merge requests and issues.
- If a `MergeRequestsClosingIssues` instance links a merge request
and an issue, that issue closes that merge request.
5. The `Queries` module was changed into a class, so we can cache the
results of `issues` and `merge_requests_closing_issues` across
various cycle analytics stages.
6. The code added in this commit is untested. Tests will be added in the
next commit.
2016-09-15 04:59:36 -04:00
|
|
|
belongs_to :merge_request
|
|
|
|
belongs_to :issue
|
2016-09-20 01:15:36 -04:00
|
|
|
|
2016-09-20 15:17:37 -04:00
|
|
|
validates :merge_request_id, uniqueness: { scope: :issue_id }, presence: true
|
|
|
|
validates :issue_id, presence: true
|
2017-02-16 15:03:42 -05:00
|
|
|
|
2019-06-12 12:28:25 -04:00
|
|
|
scope :with_issues, ->(ids) { where(issue_id: ids) }
|
|
|
|
scope :with_merge_requests_enabled, -> do
|
|
|
|
joins(:merge_request)
|
|
|
|
.joins('INNER JOIN project_features ON merge_requests.target_project_id = project_features.project_id')
|
|
|
|
.where('project_features.merge_requests_access_level >= :access', access: ProjectFeature::ENABLED)
|
|
|
|
end
|
|
|
|
|
|
|
|
scope :accessible_by, ->(user) do
|
|
|
|
joins(:merge_request)
|
|
|
|
.joins('INNER JOIN project_features ON merge_requests.target_project_id = project_features.project_id')
|
|
|
|
.where('project_features.merge_requests_access_level >= :access OR EXISTS(:authorizations)',
|
|
|
|
access: ProjectFeature::ENABLED,
|
|
|
|
authorizations: user.authorizations_for_projects(min_access_level: Gitlab::Access::REPORTER, related_project_column: "merge_requests.target_project_id")
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
2017-02-16 15:03:42 -05:00
|
|
|
class << self
|
2019-06-12 12:28:25 -04:00
|
|
|
def count_for_collection(ids, current_user)
|
|
|
|
closing_merge_requests(ids, current_user).group(:issue_id).pluck('issue_id', 'COUNT(*) as count')
|
|
|
|
end
|
|
|
|
|
|
|
|
def count_for_issue(id, current_user)
|
|
|
|
closing_merge_requests(id, current_user).count
|
|
|
|
end
|
|
|
|
|
|
|
|
private
|
|
|
|
|
|
|
|
def closing_merge_requests(ids, current_user)
|
|
|
|
return with_issues(ids) if current_user&.admin?
|
|
|
|
return with_issues(ids).with_merge_requests_enabled if current_user.blank?
|
|
|
|
|
|
|
|
with_issues(ids).accessible_by(current_user)
|
2017-02-16 15:03:42 -05:00
|
|
|
end
|
|
|
|
end
|
Improve performance of the cycle analytics page.
1. These changes bring down page load time for 100 issues from more than
a minute to about 1.5 seconds.
2. This entire commit is composed of these types of performance
enhancements:
- Cache relevant data in `IssueMetrics` wherever possible.
- Cache relevant data in `MergeRequestMetrics` wherever possible.
- Preload metrics
3. Given these improvements, we now only need to make 4 SQL calls:
- Load all issues
- Load all merge requests
- Load all metrics for the issues
- Load all metrics for the merge requests
4. A list of all the data points that are now being pre-calculated:
a. The first time an issue is mentioned in a commit
- In `GitPushService`, find all issues mentioned by the given commit
using `ReferenceExtractor`. Set the `first_mentioned_in_commit_at`
flag for each of them.
- There seems to be a (pre-existing) bug here - files (and
therefore commits) created using the Web CI don't have
cross-references created, and issues are not closed even when
the commit title is "Fixes #xx".
b. The first time a merge request is deployed to production
When a `Deployment` is created, find all merge requests that
were merged in before the deployment, and set the
`first_deployed_to_production_at` flag for each of them.
c. The start / end time for a merge request pipeline
Hook into the `Pipeline` state machine. When the `status` moves to
`running`, find the merge requests whose tip commit matches the
pipeline, and record the `latest_build_started_at` time for each
of them. When the `status` moves to `success`, record the
`latest_build_finished_at` time.
d. The merge requests that close an issue
- This was a big cause of the performance problems we were having
with Cycle Analytics. We need to use `ReferenceExtractor` to make
this calculation, which is slow when we have to run it on a large
number of merge requests.
- When a merge request is created, updated, or refreshed, find the
issues it closes, and create an instance of
`MergeRequestsClosingIssues`, which acts as a join model between
merge requests and issues.
- If a `MergeRequestsClosingIssues` instance links a merge request
and an issue, that issue closes that merge request.
5. The `Queries` module was changed into a class, so we can cache the
results of `issues` and `merge_requests_closing_issues` across
various cycle analytics stages.
6. The code added in this commit is untested. Tests will be added in the
next commit.
2016-09-15 04:59:36 -04:00
|
|
|
end
|