2018-03-13 18:38:25 -04:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe Gitlab::HTTP do
|
|
|
|
describe 'allow_local_requests_from_hooks_and_services is' do
|
|
|
|
before do
|
|
|
|
WebMock.stub_request(:get, /.*/).to_return(status: 200, body: 'Success')
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'disabled' do
|
|
|
|
before do
|
|
|
|
allow(Gitlab::CurrentSettings).to receive(:allow_local_requests_from_hooks_and_services?).and_return(false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'deny requests to localhost' do
|
2018-03-28 13:27:16 -04:00
|
|
|
expect { described_class.get('http://localhost:3003') }.to raise_error(Gitlab::HTTP::BlockedUrlError)
|
2018-03-13 18:38:25 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'deny requests to private network' do
|
2018-03-28 13:27:16 -04:00
|
|
|
expect { described_class.get('http://192.168.1.2:3003') }.to raise_error(Gitlab::HTTP::BlockedUrlError)
|
2018-03-13 18:38:25 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'if allow_local_requests set to true' do
|
|
|
|
it 'override the global value and allow requests to localhost or private network' do
|
|
|
|
expect { described_class.get('http://localhost:3003', allow_local_requests: true) }.not_to raise_error
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'enabled' do
|
|
|
|
before do
|
|
|
|
allow(Gitlab::CurrentSettings).to receive(:allow_local_requests_from_hooks_and_services?).and_return(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'allow requests to localhost' do
|
|
|
|
expect { described_class.get('http://localhost:3003') }.not_to raise_error
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'allow requests to private network' do
|
|
|
|
expect { described_class.get('http://192.168.1.2:3003') }.not_to raise_error
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'if allow_local_requests set to false' do
|
|
|
|
it 'override the global value and ban requests to localhost or private network' do
|
2018-03-28 13:27:16 -04:00
|
|
|
expect { described_class.get('http://localhost:3003', allow_local_requests: false) }.to raise_error(Gitlab::HTTP::BlockedUrlError)
|
2018-03-13 18:38:25 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|