2019-07-25 01:24:42 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2012-07-18 17:24:37 -04:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2020-06-03 14:08:28 -04:00
|
|
|
RSpec.describe 'Admin::Hooks' do
|
2017-09-20 05:44:39 -04:00
|
|
|
let(:user) { create(:admin) }
|
2012-07-18 17:24:37 -04:00
|
|
|
|
2017-09-20 05:44:39 -04:00
|
|
|
before do
|
|
|
|
sign_in(user)
|
2020-11-23 10:09:37 -05:00
|
|
|
gitlab_enable_admin_mode_sign_in(user)
|
2012-07-18 17:24:37 -04:00
|
|
|
end
|
|
|
|
|
2017-04-20 04:31:37 -04:00
|
|
|
describe 'GET /admin/hooks' do
|
|
|
|
it 'is ok' do
|
2012-07-18 17:24:37 -04:00
|
|
|
visit admin_root_path
|
2016-06-15 11:47:43 -04:00
|
|
|
|
2017-08-14 10:11:31 -04:00
|
|
|
page.within '.nav-sidebar' do
|
2017-09-20 05:44:39 -04:00
|
|
|
click_on 'System Hooks', match: :first
|
2012-07-18 17:24:37 -04:00
|
|
|
end
|
2016-06-15 11:47:43 -04:00
|
|
|
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(current_path).to eq(admin_hooks_path)
|
2012-07-18 17:24:37 -04:00
|
|
|
end
|
|
|
|
|
2017-04-20 04:31:37 -04:00
|
|
|
it 'has hooks list' do
|
2017-09-20 05:44:39 -04:00
|
|
|
system_hook = create(:system_hook)
|
|
|
|
|
2012-07-18 17:24:37 -04:00
|
|
|
visit admin_hooks_path
|
2017-09-20 05:44:39 -04:00
|
|
|
expect(page).to have_content(system_hook.url)
|
2012-07-18 17:24:37 -04:00
|
|
|
end
|
2018-03-06 11:24:24 -05:00
|
|
|
|
|
|
|
it 'renders plugins list as well' do
|
2020-01-16 10:08:41 -05:00
|
|
|
allow(Gitlab::FileHook).to receive(:files).and_return(['foo.rb', 'bar.clj'])
|
2018-03-06 11:24:24 -05:00
|
|
|
|
|
|
|
visit admin_hooks_path
|
|
|
|
|
2020-01-16 10:08:41 -05:00
|
|
|
expect(page).to have_content('File Hooks')
|
2018-03-06 11:24:24 -05:00
|
|
|
expect(page).to have_content('foo.rb')
|
|
|
|
expect(page).to have_content('bar.clj')
|
|
|
|
end
|
2020-04-27 05:09:51 -04:00
|
|
|
|
|
|
|
context 'deprecation warning' do
|
|
|
|
it 'shows warning for plugins directory' do
|
|
|
|
allow(Gitlab::FileHook).to receive(:files).and_return(['plugins/foo.rb'])
|
|
|
|
|
|
|
|
visit admin_hooks_path
|
|
|
|
|
|
|
|
expect(page).to have_content('Plugins directory is deprecated and will be removed in 14.0')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not show warning for file_hooks directory' do
|
|
|
|
allow(Gitlab::FileHook).to receive(:files).and_return(['file_hooks/foo.rb'])
|
|
|
|
|
|
|
|
visit admin_hooks_path
|
|
|
|
|
|
|
|
expect(page).not_to have_content('Plugins directory is deprecated and will be removed in 14.0')
|
|
|
|
end
|
|
|
|
end
|
2012-07-18 17:24:37 -04:00
|
|
|
end
|
|
|
|
|
2017-04-20 04:31:37 -04:00
|
|
|
describe 'New Hook' do
|
2017-03-23 09:08:39 -04:00
|
|
|
let(:url) { generate(:url) }
|
2016-12-05 13:50:13 -05:00
|
|
|
|
|
|
|
it 'adds new hook' do
|
2012-07-18 17:24:37 -04:00
|
|
|
visit admin_hooks_path
|
2016-12-05 13:50:13 -05:00
|
|
|
fill_in 'hook_url', with: url
|
|
|
|
check 'Enable SSL verification'
|
2012-07-18 17:24:37 -04:00
|
|
|
|
2017-04-04 18:36:19 -04:00
|
|
|
expect { click_button 'Add system hook' }.to change(SystemHook, :count).by(1)
|
2016-12-05 13:50:13 -05:00
|
|
|
expect(page).to have_content 'SSL Verification: enabled'
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(current_path).to eq(admin_hooks_path)
|
2016-12-05 13:50:13 -05:00
|
|
|
expect(page).to have_content(url)
|
2012-07-18 17:24:37 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-04-20 04:31:37 -04:00
|
|
|
describe 'Update existing hook' do
|
|
|
|
let(:new_url) { generate(:url) }
|
|
|
|
|
2017-09-20 05:44:39 -04:00
|
|
|
before do
|
|
|
|
create(:system_hook)
|
|
|
|
end
|
|
|
|
|
2017-04-20 04:31:37 -04:00
|
|
|
it 'updates existing hook' do
|
|
|
|
visit admin_hooks_path
|
|
|
|
|
|
|
|
click_link 'Edit'
|
|
|
|
fill_in 'hook_url', with: new_url
|
|
|
|
check 'Enable SSL verification'
|
|
|
|
click_button 'Save changes'
|
|
|
|
|
|
|
|
expect(page).to have_content 'SSL Verification: enabled'
|
|
|
|
expect(current_path).to eq(admin_hooks_path)
|
|
|
|
expect(page).to have_content(new_url)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-12-18 09:18:40 -05:00
|
|
|
describe 'Remove existing hook', :js do
|
2019-04-12 04:50:24 -04:00
|
|
|
let(:hook_url) { generate(:url) }
|
|
|
|
|
2017-09-20 05:44:39 -04:00
|
|
|
before do
|
2019-04-12 04:50:24 -04:00
|
|
|
create(:system_hook, url: hook_url)
|
2017-09-20 05:44:39 -04:00
|
|
|
end
|
|
|
|
|
2017-04-27 06:08:57 -04:00
|
|
|
context 'removes existing hook' do
|
|
|
|
it 'from hooks list page' do
|
|
|
|
visit admin_hooks_path
|
|
|
|
|
2019-12-16 04:08:10 -05:00
|
|
|
accept_confirm { click_link 'Delete' }
|
2019-04-12 04:50:24 -04:00
|
|
|
expect(page).not_to have_content(hook_url)
|
2017-04-27 06:08:57 -04:00
|
|
|
end
|
2017-04-20 04:31:37 -04:00
|
|
|
|
2017-04-27 06:08:57 -04:00
|
|
|
it 'from hook edit page' do
|
|
|
|
visit admin_hooks_path
|
|
|
|
click_link 'Edit'
|
|
|
|
|
2019-12-16 04:08:10 -05:00
|
|
|
accept_confirm { click_link 'Delete' }
|
2019-04-12 04:50:24 -04:00
|
|
|
expect(page).not_to have_content(hook_url)
|
2017-04-27 06:08:57 -04:00
|
|
|
end
|
2017-04-20 04:31:37 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-10-03 04:35:01 -04:00
|
|
|
describe 'Test', :js do
|
2012-07-18 17:24:37 -04:00
|
|
|
before do
|
2017-09-20 05:44:39 -04:00
|
|
|
system_hook = create(:system_hook)
|
|
|
|
WebMock.stub_request(:post, system_hook.url)
|
2012-07-18 17:24:37 -04:00
|
|
|
visit admin_hooks_path
|
2017-07-20 11:12:06 -04:00
|
|
|
|
|
|
|
find('.hook-test-button.dropdown').click
|
|
|
|
click_link 'Push events'
|
2012-07-18 17:24:37 -04:00
|
|
|
end
|
|
|
|
|
2015-02-12 13:17:35 -05:00
|
|
|
it { expect(current_path).to eq(admin_hooks_path) }
|
2012-07-18 17:24:37 -04:00
|
|
|
end
|
2017-09-20 05:44:39 -04:00
|
|
|
|
|
|
|
context 'Merge request hook' do
|
|
|
|
describe 'New Hook' do
|
|
|
|
let(:url) { generate(:url) }
|
|
|
|
|
|
|
|
it 'adds new hook' do
|
|
|
|
visit admin_hooks_path
|
|
|
|
|
|
|
|
fill_in 'hook_url', with: url
|
|
|
|
uncheck 'Repository update events'
|
2017-11-23 07:49:35 -05:00
|
|
|
check 'Merge request events'
|
2017-09-20 05:44:39 -04:00
|
|
|
|
|
|
|
expect { click_button 'Add system hook' }.to change(SystemHook, :count).by(1)
|
|
|
|
expect(current_path).to eq(admin_hooks_path)
|
|
|
|
expect(page).to have_content(url)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'Test', :js do
|
|
|
|
before do
|
|
|
|
system_hook = create(:system_hook)
|
|
|
|
WebMock.stub_request(:post, system_hook.url)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'succeeds if the user has a repository with a merge request' do
|
|
|
|
project = create(:project, :repository)
|
|
|
|
create(:project_member, user: user, project: project)
|
|
|
|
create(:merge_request, source_project: project)
|
|
|
|
|
|
|
|
visit admin_hooks_path
|
|
|
|
find('.hook-test-button.dropdown').click
|
|
|
|
click_link 'Merge requests events'
|
|
|
|
|
|
|
|
expect(page).to have_content 'Hook executed successfully'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2012-07-18 17:24:37 -04:00
|
|
|
end
|