2018-08-03 17:22:24 +00:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-10-06 21:17:11 +00:00
|
|
|
# This module takes care of updating cache columns for Markdown-containing
|
|
|
|
# fields. Use like this in the body of your class:
|
|
|
|
#
|
|
|
|
# include CacheMarkdownField
|
|
|
|
# cache_markdown_field :foo
|
|
|
|
# cache_markdown_field :bar
|
|
|
|
# cache_markdown_field :baz, pipeline: :single_line
|
2019-03-20 20:01:27 +00:00
|
|
|
# cache_markdown_field :baz, whitelisted: true
|
2016-10-06 21:17:11 +00:00
|
|
|
#
|
|
|
|
# Corresponding foo_html, bar_html and baz_html fields should exist.
|
|
|
|
module CacheMarkdownField
|
2017-04-10 18:36:30 +00:00
|
|
|
extend ActiveSupport::Concern
|
|
|
|
|
|
|
|
# changes to these attributes cause the cache to be invalidates
|
|
|
|
INVALIDATED_BY = %w[author project].freeze
|
|
|
|
|
2017-01-20 10:28:40 +00:00
|
|
|
def skip_project_check?
|
|
|
|
false
|
|
|
|
end
|
|
|
|
|
2020-02-28 21:09:15 +00:00
|
|
|
def can_cache_field?(field)
|
|
|
|
true
|
|
|
|
end
|
|
|
|
|
2017-04-10 18:36:30 +00:00
|
|
|
# Returns the default Banzai render context for the cached markdown field.
|
|
|
|
def banzai_render_context(field)
|
|
|
|
raise ArgumentError.new("Unknown field: #{field.inspect}") unless
|
|
|
|
cached_markdown_fields.markdown_fields.include?(field)
|
2016-10-06 21:17:11 +00:00
|
|
|
|
2017-04-10 18:36:30 +00:00
|
|
|
# Always include a project key, or Banzai complains
|
|
|
|
project = self.project if self.respond_to?(:project)
|
2018-04-17 15:42:19 +00:00
|
|
|
group = self.group if self.respond_to?(:group)
|
2017-11-01 17:35:14 +00:00
|
|
|
context = cached_markdown_fields[field].merge(project: project, group: group)
|
2017-04-10 18:36:30 +00:00
|
|
|
|
|
|
|
# Banzai is less strict about authors, so don't always have an author key
|
|
|
|
context[:author] = self.author if self.respond_to?(:author)
|
2016-10-06 21:17:11 +00:00
|
|
|
|
2019-01-31 08:58:23 +00:00
|
|
|
context[:markdown_engine] = :common_mark
|
2018-04-17 15:42:19 +00:00
|
|
|
|
2017-04-10 18:36:30 +00:00
|
|
|
context
|
|
|
|
end
|
2016-10-06 21:17:11 +00:00
|
|
|
|
2020-02-28 21:09:15 +00:00
|
|
|
def rendered_field_content(markdown_field)
|
|
|
|
return unless can_cache_field?(markdown_field)
|
|
|
|
|
2017-04-10 18:36:30 +00:00
|
|
|
options = { skip_project_check: skip_project_check? }
|
2020-02-28 21:09:15 +00:00
|
|
|
Banzai::Renderer.cacheless_render_field(self, markdown_field, options)
|
|
|
|
end
|
2016-10-06 21:17:11 +00:00
|
|
|
|
2020-02-28 21:09:15 +00:00
|
|
|
# Update every applicable column in a row if any one is invalidated, as we only store
|
|
|
|
# one version per row
|
|
|
|
def refresh_markdown_cache
|
2017-04-10 18:36:30 +00:00
|
|
|
updates = cached_markdown_fields.markdown_fields.map do |markdown_field|
|
|
|
|
[
|
|
|
|
cached_markdown_fields.html_field(markdown_field),
|
2020-02-28 21:09:15 +00:00
|
|
|
rendered_field_content(markdown_field)
|
2017-04-10 18:36:30 +00:00
|
|
|
]
|
|
|
|
end.to_h
|
2020-02-28 21:09:15 +00:00
|
|
|
|
2018-04-17 15:42:19 +00:00
|
|
|
updates['cached_markdown_version'] = latest_cached_markdown_version
|
2016-10-06 21:17:11 +00:00
|
|
|
|
2019-06-05 04:59:48 +00:00
|
|
|
updates.each { |field, data| write_markdown_field(field, data) }
|
2017-09-19 07:44:58 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
def refresh_markdown_cache!
|
|
|
|
updates = refresh_markdown_cache
|
|
|
|
|
2019-06-05 04:59:48 +00:00
|
|
|
save_markdown(updates)
|
2017-04-10 18:36:30 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
def cached_html_up_to_date?(markdown_field)
|
2019-06-05 04:59:48 +00:00
|
|
|
return false if cached_html_for(markdown_field).nil? && __send__(markdown_field).present? # rubocop:disable GitlabSecurity/PublicSend
|
2017-04-10 18:36:30 +00:00
|
|
|
|
2019-06-05 04:59:48 +00:00
|
|
|
html_field = cached_markdown_fields.html_field(markdown_field)
|
2017-05-02 13:24:41 +00:00
|
|
|
|
2019-06-05 04:59:48 +00:00
|
|
|
markdown_changed = markdown_field_changed?(markdown_field)
|
|
|
|
html_changed = markdown_field_changed?(html_field)
|
2016-10-06 21:17:11 +00:00
|
|
|
|
2018-04-17 15:42:19 +00:00
|
|
|
latest_cached_markdown_version == cached_markdown_version &&
|
2017-04-10 18:36:30 +00:00
|
|
|
(html_changed || markdown_changed == html_changed)
|
|
|
|
end
|
|
|
|
|
|
|
|
def invalidated_markdown_cache?
|
|
|
|
cached_markdown_fields.html_fields.any? {|html_field| attribute_invalidated?(html_field) }
|
|
|
|
end
|
|
|
|
|
|
|
|
def attribute_invalidated?(attr)
|
2017-08-10 16:39:26 +00:00
|
|
|
__send__("#{attr}_invalidated?") # rubocop:disable GitlabSecurity/PublicSend
|
2017-04-10 18:36:30 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
def cached_html_for(markdown_field)
|
2019-06-05 04:59:48 +00:00
|
|
|
raise ArgumentError.new("Unknown field: #{markdown_field}") unless
|
2017-04-10 18:36:30 +00:00
|
|
|
cached_markdown_fields.markdown_fields.include?(markdown_field)
|
|
|
|
|
2017-08-10 16:39:26 +00:00
|
|
|
__send__(cached_markdown_fields.html_field(markdown_field)) # rubocop:disable GitlabSecurity/PublicSend
|
2017-04-10 18:36:30 +00:00
|
|
|
end
|
2016-10-06 21:17:11 +00:00
|
|
|
|
2019-07-03 23:12:02 +00:00
|
|
|
# Updates the markdown cache if necessary, then returns the field
|
|
|
|
# Unlike `cached_html_for` it returns `nil` if the field does not exist
|
|
|
|
def updated_cached_html_for(markdown_field)
|
|
|
|
return unless cached_markdown_fields.markdown_fields.include?(markdown_field)
|
|
|
|
|
|
|
|
refresh_markdown_cache if attribute_invalidated?(cached_markdown_fields.html_field(markdown_field))
|
|
|
|
|
|
|
|
cached_html_for(markdown_field)
|
|
|
|
end
|
|
|
|
|
2018-04-17 15:42:19 +00:00
|
|
|
def latest_cached_markdown_version
|
2019-06-05 04:59:48 +00:00
|
|
|
@latest_cached_markdown_version ||= (Gitlab::MarkdownCache::CACHE_COMMONMARK_VERSION << 16) | local_version
|
2019-01-31 11:28:31 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
def local_version
|
|
|
|
# because local_markdown_version is stored in application_settings which
|
|
|
|
# uses cached_markdown_version too, we check explicitly to avoid
|
|
|
|
# endless loop
|
2019-06-05 04:59:48 +00:00
|
|
|
return local_markdown_version if respond_to?(:has_attribute?) && has_attribute?(:local_markdown_version)
|
2019-01-31 11:28:31 +00:00
|
|
|
|
|
|
|
settings = Gitlab::CurrentSettings.current_application_settings
|
|
|
|
|
|
|
|
# Following migrations are not properly isolated and
|
|
|
|
# use real models (by calling .ghost method), in these migrations
|
|
|
|
# local_markdown_version attribute doesn't exist yet, so we
|
|
|
|
# use a default value:
|
|
|
|
# db/migrate/20170825104051_migrate_issues_to_ghost_user.rb
|
|
|
|
# db/migrate/20171114150259_merge_requests_author_id_foreign_key.rb
|
|
|
|
if settings.respond_to?(:local_markdown_version)
|
|
|
|
settings.local_markdown_version
|
|
|
|
else
|
|
|
|
0
|
|
|
|
end
|
2019-01-29 16:46:04 +00:00
|
|
|
end
|
|
|
|
|
2017-04-10 18:36:30 +00:00
|
|
|
included do
|
|
|
|
cattr_reader :cached_markdown_fields do
|
2019-06-05 04:59:48 +00:00
|
|
|
Gitlab::MarkdownCache::FieldData.new
|
2016-10-06 21:17:11 +00:00
|
|
|
end
|
|
|
|
|
2019-06-05 04:59:48 +00:00
|
|
|
if self < ActiveRecord::Base
|
|
|
|
include Gitlab::MarkdownCache::ActiveRecord::Extension
|
|
|
|
else
|
|
|
|
prepend Gitlab::MarkdownCache::Redis::Extension
|
2016-10-06 21:17:11 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
class_methods do
|
|
|
|
private
|
|
|
|
|
|
|
|
# Specify that a field is markdown. Its rendered output will be cached in
|
|
|
|
# a corresponding _html field. Any custom rendering options may be provided
|
|
|
|
# as a context.
|
|
|
|
def cache_markdown_field(markdown_field, context = {})
|
|
|
|
cached_markdown_fields[markdown_field] = context
|
|
|
|
|
|
|
|
html_field = cached_markdown_fields.html_field(markdown_field)
|
|
|
|
invalidation_method = "#{html_field}_invalidated?".to_sym
|
|
|
|
|
|
|
|
# The HTML becomes invalid if any dependent fields change. For now, assume
|
|
|
|
# author and project invalidate the cache in all circumstances.
|
|
|
|
define_method(invalidation_method) do
|
2019-07-03 23:12:02 +00:00
|
|
|
changed_fields = changed_attributes.keys
|
|
|
|
invalidations = changed_fields & [markdown_field.to_s, *INVALIDATED_BY]
|
|
|
|
invalidations.delete(markdown_field.to_s) if changed_fields.include?("#{markdown_field}_html")
|
2017-04-10 18:36:30 +00:00
|
|
|
!invalidations.empty? || !cached_html_up_to_date?(markdown_field)
|
2016-10-06 21:17:11 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|