2016-08-11 09:22:35 -04:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2017-05-30 06:48:05 -04:00
|
|
|
describe Ci::CreatePipelineService, :services do
|
2017-03-27 17:14:01 -04:00
|
|
|
let(:project) { create(:project, :repository) }
|
2016-08-11 09:22:35 -04:00
|
|
|
let(:user) { create(:admin) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
stub_ci_pipeline_to_return_yaml_file
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#execute' do
|
2017-05-24 09:13:51 -04:00
|
|
|
def execute_service(source: :push, after: project.commit.id, message: 'Message', ref: 'refs/heads/master')
|
2017-02-19 17:17:24 -05:00
|
|
|
params = { ref: ref,
|
|
|
|
before: '00000000',
|
2017-06-05 04:30:57 -04:00
|
|
|
after: after,
|
2017-02-19 17:17:24 -05:00
|
|
|
commits: [{ message: message }] }
|
|
|
|
|
2017-05-24 09:13:51 -04:00
|
|
|
described_class.new(project, user, params).execute(source)
|
2016-08-11 09:22:35 -04:00
|
|
|
end
|
|
|
|
|
2017-03-20 16:52:35 -04:00
|
|
|
context 'valid params' do
|
|
|
|
let(:pipeline) { execute_service }
|
|
|
|
|
2017-04-05 15:23:36 -04:00
|
|
|
let(:pipeline_on_previous_commit) do
|
|
|
|
execute_service(
|
|
|
|
after: previous_commit_sha_from_ref('master')
|
|
|
|
)
|
|
|
|
end
|
|
|
|
|
2017-05-15 05:39:56 -04:00
|
|
|
it 'creates a pipeline' do
|
|
|
|
expect(pipeline).to be_kind_of(Ci::Pipeline)
|
|
|
|
expect(pipeline).to be_valid
|
2017-06-02 09:05:14 -04:00
|
|
|
expect(pipeline).to be_persisted
|
2017-05-24 09:13:51 -04:00
|
|
|
expect(pipeline).to be_push
|
2017-05-15 05:39:56 -04:00
|
|
|
expect(pipeline).to eq(project.pipelines.last)
|
|
|
|
expect(pipeline).to have_attributes(user: user)
|
|
|
|
expect(pipeline).to have_attributes(status: 'pending')
|
|
|
|
expect(pipeline.builds.first).to be_kind_of(Ci::Build)
|
|
|
|
end
|
2017-02-19 17:17:24 -05:00
|
|
|
|
2017-06-08 03:58:38 -04:00
|
|
|
it 'increments the prometheus counter' do
|
|
|
|
expect(Gitlab::Metrics).to receive(:counter)
|
2017-07-19 03:43:57 -04:00
|
|
|
.with(:pipelines_created_total, "Counter of pipelines created")
|
2017-06-08 03:58:38 -04:00
|
|
|
.and_call_original
|
|
|
|
|
|
|
|
pipeline
|
|
|
|
end
|
|
|
|
|
2017-05-25 17:14:40 -04:00
|
|
|
context 'when merge requests already exist for this source branch' do
|
2017-05-05 15:00:18 -04:00
|
|
|
it 'updates head pipeline of each merge request' do
|
|
|
|
merge_request_1 = create(:merge_request, source_branch: 'master', target_branch: "branch_1", source_project: project)
|
|
|
|
merge_request_2 = create(:merge_request, source_branch: 'master', target_branch: "branch_2", source_project: project)
|
2017-03-17 18:14:27 -04:00
|
|
|
|
2017-05-05 15:00:18 -04:00
|
|
|
head_pipeline = pipeline
|
2017-03-17 18:14:27 -04:00
|
|
|
|
2017-05-05 15:00:18 -04:00
|
|
|
expect(merge_request_1.reload.head_pipeline).to eq(head_pipeline)
|
|
|
|
expect(merge_request_2.reload.head_pipeline).to eq(head_pipeline)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when there is no pipeline for source branch' do
|
|
|
|
it "does not update merge request head pipeline" do
|
|
|
|
merge_request = create(:merge_request, source_branch: 'other_branch', target_branch: "branch_1", source_project: project)
|
|
|
|
|
|
|
|
head_pipeline = pipeline
|
|
|
|
|
|
|
|
expect(merge_request.reload.head_pipeline).not_to eq(head_pipeline)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when merge request target project is different from source project' do
|
2017-05-23 17:36:57 -04:00
|
|
|
let!(:target_project) { create(:project) }
|
2017-05-05 15:00:18 -04:00
|
|
|
let!(:forked_project_link) { create(:forked_project_link, forked_to_project: project, forked_from_project: target_project) }
|
|
|
|
|
|
|
|
it 'updates head pipeline for merge request' do
|
|
|
|
merge_request =
|
|
|
|
create(:merge_request, source_branch: 'master', target_branch: "branch_1", source_project: project, target_project: target_project)
|
|
|
|
|
|
|
|
head_pipeline = pipeline
|
|
|
|
|
|
|
|
expect(merge_request.reload.head_pipeline).to eq(head_pipeline)
|
|
|
|
end
|
|
|
|
end
|
2017-05-23 17:36:57 -04:00
|
|
|
|
2017-06-01 14:31:52 -04:00
|
|
|
context 'when the pipeline is not the latest for the branch' do
|
2017-05-23 17:36:57 -04:00
|
|
|
it 'does not update merge request head pipeline' do
|
|
|
|
merge_request = create(:merge_request, source_branch: 'master', target_branch: "branch_1", source_project: project)
|
2017-06-01 14:31:52 -04:00
|
|
|
|
|
|
|
allow_any_instance_of(Ci::Pipeline).to receive(:latest?).and_return(false)
|
2017-05-23 17:36:57 -04:00
|
|
|
|
|
|
|
pipeline
|
|
|
|
|
|
|
|
expect(merge_request.reload.head_pipeline).to be_nil
|
|
|
|
end
|
|
|
|
end
|
2017-03-17 18:14:27 -04:00
|
|
|
end
|
|
|
|
|
2017-02-19 17:17:24 -05:00
|
|
|
context 'auto-cancel enabled' do
|
|
|
|
before do
|
|
|
|
project.update(auto_cancel_pending_pipelines: 'enabled')
|
|
|
|
end
|
|
|
|
|
2017-03-18 05:50:56 -04:00
|
|
|
it 'does not cancel HEAD pipeline' do
|
|
|
|
pipeline
|
2017-03-18 10:49:01 -04:00
|
|
|
pipeline_on_previous_commit
|
2017-03-18 05:50:56 -04:00
|
|
|
|
2017-03-20 17:39:27 -04:00
|
|
|
expect(pipeline.reload).to have_attributes(status: 'pending', auto_canceled_by_id: nil)
|
2017-03-18 05:50:56 -04:00
|
|
|
end
|
2017-02-19 17:17:24 -05:00
|
|
|
|
|
|
|
it 'auto cancel pending non-HEAD pipelines' do
|
2017-03-20 17:39:27 -04:00
|
|
|
pipeline_on_previous_commit
|
2017-02-19 17:17:24 -05:00
|
|
|
pipeline
|
|
|
|
|
2017-03-20 17:39:27 -04:00
|
|
|
expect(pipeline_on_previous_commit.reload).to have_attributes(status: 'canceled', auto_canceled_by_id: pipeline.id)
|
2017-02-19 17:17:24 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not cancel running outdated pipelines' do
|
2017-03-20 17:39:27 -04:00
|
|
|
pipeline_on_previous_commit.run
|
2017-02-19 17:17:24 -05:00
|
|
|
execute_service
|
|
|
|
|
2017-03-20 17:39:27 -04:00
|
|
|
expect(pipeline_on_previous_commit.reload).to have_attributes(status: 'running', auto_canceled_by_id: nil)
|
2017-02-19 17:17:24 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'cancel created outdated pipelines' do
|
2017-03-20 17:39:27 -04:00
|
|
|
pipeline_on_previous_commit.update(status: 'created')
|
2017-02-19 17:17:24 -05:00
|
|
|
pipeline
|
|
|
|
|
2017-03-20 17:39:27 -04:00
|
|
|
expect(pipeline_on_previous_commit.reload).to have_attributes(status: 'canceled', auto_canceled_by_id: pipeline.id)
|
2017-02-19 17:17:24 -05:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not cancel pipelines from the other branches' do
|
|
|
|
pending_pipeline = execute_service(
|
|
|
|
ref: 'refs/heads/feature',
|
|
|
|
after: previous_commit_sha_from_ref('feature')
|
|
|
|
)
|
|
|
|
pipeline
|
|
|
|
|
2017-03-18 07:46:56 -04:00
|
|
|
expect(pending_pipeline.reload).to have_attributes(status: 'pending', auto_canceled_by_id: nil)
|
2017-02-19 17:17:24 -05:00
|
|
|
end
|
|
|
|
end
|
2017-04-05 15:23:36 -04:00
|
|
|
|
|
|
|
context 'auto-cancel disabled' do
|
|
|
|
before do
|
|
|
|
project.update(auto_cancel_pending_pipelines: 'disabled')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not auto cancel pending non-HEAD pipelines' do
|
|
|
|
pipeline_on_previous_commit
|
|
|
|
pipeline
|
|
|
|
|
|
|
|
expect(pipeline_on_previous_commit.reload)
|
|
|
|
.to have_attributes(status: 'pending', auto_canceled_by_id: nil)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def previous_commit_sha_from_ref(ref)
|
|
|
|
project.commit(ref).parent.sha
|
|
|
|
end
|
2017-02-19 17:17:24 -05:00
|
|
|
end
|
|
|
|
|
2016-08-11 09:22:35 -04:00
|
|
|
context "skip tag if there is no build for it" do
|
|
|
|
it "creates commit if there is appropriate job" do
|
2017-02-19 17:17:24 -05:00
|
|
|
expect(execute_service).to be_persisted
|
2016-08-11 09:22:35 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "creates commit if there is no appropriate job but deploy job has right ref setting" do
|
|
|
|
config = YAML.dump({ deploy: { script: "ls", only: ["master"] } })
|
|
|
|
stub_ci_pipeline_yaml_file(config)
|
|
|
|
|
2017-02-19 17:17:24 -05:00
|
|
|
expect(execute_service).to be_persisted
|
2016-08-11 09:22:35 -04:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'skips creating pipeline for refs without .gitlab-ci.yml' do
|
|
|
|
stub_ci_pipeline_yaml_file(nil)
|
|
|
|
|
2017-02-19 17:17:24 -05:00
|
|
|
expect(execute_service).not_to be_persisted
|
2016-08-11 09:22:35 -04:00
|
|
|
expect(Ci::Pipeline.count).to eq(0)
|
|
|
|
end
|
|
|
|
|
2017-02-19 17:17:24 -05:00
|
|
|
shared_examples 'a failed pipeline' do
|
|
|
|
it 'creates failed pipeline' do
|
|
|
|
stub_ci_pipeline_yaml_file(ci_yaml)
|
|
|
|
|
|
|
|
pipeline = execute_service(message: message)
|
|
|
|
|
|
|
|
expect(pipeline).to be_persisted
|
|
|
|
expect(pipeline.builds.any?).to be false
|
|
|
|
expect(pipeline.status).to eq('failed')
|
|
|
|
expect(pipeline.yaml_errors).not_to be_nil
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when yaml is invalid' do
|
|
|
|
let(:ci_yaml) { 'invalid: file: fiile' }
|
|
|
|
let(:message) { 'Message' }
|
|
|
|
|
|
|
|
it_behaves_like 'a failed pipeline'
|
|
|
|
|
|
|
|
context 'when receive git commit' do
|
|
|
|
before do
|
|
|
|
allow_any_instance_of(Ci::Pipeline).to receive(:git_commit_message) { message }
|
|
|
|
end
|
|
|
|
|
|
|
|
it_behaves_like 'a failed pipeline'
|
|
|
|
end
|
2016-08-11 09:22:35 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when commit contains a [ci skip] directive' do
|
|
|
|
let(:message) { "some message[ci skip]" }
|
2017-02-10 05:32:59 -05:00
|
|
|
|
|
|
|
ci_messages = [
|
|
|
|
"some message[ci skip]",
|
|
|
|
"some message[skip ci]",
|
|
|
|
"some message[CI SKIP]",
|
|
|
|
"some message[SKIP CI]",
|
|
|
|
"some message[ci_skip]",
|
|
|
|
"some message[skip_ci]",
|
|
|
|
"some message[ci-skip]",
|
|
|
|
"some message[skip-ci]"
|
|
|
|
]
|
2016-08-11 09:22:35 -04:00
|
|
|
|
|
|
|
before do
|
|
|
|
allow_any_instance_of(Ci::Pipeline).to receive(:git_commit_message) { message }
|
|
|
|
end
|
|
|
|
|
2017-02-10 05:32:59 -05:00
|
|
|
ci_messages.each do |ci_message|
|
|
|
|
it "skips builds creation if the commit message is #{ci_message}" do
|
2017-02-19 17:17:24 -05:00
|
|
|
pipeline = execute_service(message: ci_message)
|
2017-02-10 05:32:59 -05:00
|
|
|
|
|
|
|
expect(pipeline).to be_persisted
|
|
|
|
expect(pipeline.builds.any?).to be false
|
|
|
|
expect(pipeline.status).to eq("skipped")
|
|
|
|
end
|
2016-08-11 09:22:35 -04:00
|
|
|
end
|
|
|
|
|
2017-02-19 17:17:24 -05:00
|
|
|
shared_examples 'creating a pipeline' do
|
2017-03-18 06:35:34 -04:00
|
|
|
it 'does not skip pipeline creation' do
|
2017-02-19 17:17:24 -05:00
|
|
|
allow_any_instance_of(Ci::Pipeline).to receive(:git_commit_message) { commit_message }
|
2016-08-11 09:22:35 -04:00
|
|
|
|
2017-02-19 17:17:24 -05:00
|
|
|
pipeline = execute_service(message: commit_message)
|
2016-08-11 09:22:35 -04:00
|
|
|
|
2017-02-19 17:17:24 -05:00
|
|
|
expect(pipeline).to be_persisted
|
|
|
|
expect(pipeline.builds.first.name).to eq("rspec")
|
|
|
|
end
|
2016-08-11 09:22:35 -04:00
|
|
|
end
|
|
|
|
|
2017-02-19 17:17:24 -05:00
|
|
|
context 'when commit message does not contain [ci skip] nor [skip ci]' do
|
|
|
|
let(:commit_message) { 'some message' }
|
2016-08-11 09:22:35 -04:00
|
|
|
|
2017-02-19 17:17:24 -05:00
|
|
|
it_behaves_like 'creating a pipeline'
|
2016-08-11 09:22:35 -04:00
|
|
|
end
|
|
|
|
|
2017-02-19 17:17:24 -05:00
|
|
|
context 'when commit message is nil' do
|
|
|
|
let(:commit_message) { nil }
|
2016-08-11 09:22:35 -04:00
|
|
|
|
2017-02-19 17:17:24 -05:00
|
|
|
it_behaves_like 'creating a pipeline'
|
2016-08-11 09:22:35 -04:00
|
|
|
end
|
|
|
|
|
2017-02-19 17:17:24 -05:00
|
|
|
context 'when there is [ci skip] tag in commit message and yaml is invalid' do
|
|
|
|
let(:ci_yaml) { 'invalid: file: fiile' }
|
|
|
|
|
|
|
|
it_behaves_like 'a failed pipeline'
|
|
|
|
end
|
2016-08-11 09:22:35 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when there are no jobs for this pipeline' do
|
|
|
|
before do
|
|
|
|
config = YAML.dump({ test: { script: 'ls', only: ['feature'] } })
|
|
|
|
stub_ci_pipeline_yaml_file(config)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not create a new pipeline' do
|
2017-02-19 17:17:24 -05:00
|
|
|
result = execute_service
|
2016-08-11 09:22:35 -04:00
|
|
|
|
|
|
|
expect(result).not_to be_persisted
|
|
|
|
expect(Ci::Build.all).to be_empty
|
|
|
|
expect(Ci::Pipeline.count).to eq(0)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'with manual actions' do
|
|
|
|
before do
|
|
|
|
config = YAML.dump({ deploy: { script: 'ls', when: 'manual' } })
|
|
|
|
stub_ci_pipeline_yaml_file(config)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not create a new pipeline' do
|
2017-02-19 17:17:24 -05:00
|
|
|
result = execute_service
|
2016-08-11 09:22:35 -04:00
|
|
|
|
|
|
|
expect(result).to be_persisted
|
|
|
|
expect(result.manual_actions).not_to be_empty
|
|
|
|
end
|
|
|
|
end
|
2016-12-08 10:37:41 -05:00
|
|
|
|
|
|
|
context 'with environment' do
|
|
|
|
before do
|
2017-03-10 05:20:08 -05:00
|
|
|
config = YAML.dump(deploy: { environment: { name: "review/$CI_COMMIT_REF_NAME" }, script: 'ls' })
|
2016-12-08 10:37:41 -05:00
|
|
|
stub_ci_pipeline_yaml_file(config)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'creates the environment' do
|
2017-02-19 17:17:24 -05:00
|
|
|
result = execute_service
|
2016-12-08 10:37:41 -05:00
|
|
|
|
|
|
|
expect(result).to be_persisted
|
|
|
|
expect(Environment.find_by(name: "review/master")).not_to be_nil
|
|
|
|
end
|
|
|
|
end
|
2017-06-02 12:24:20 -04:00
|
|
|
|
|
|
|
context 'when environment with invalid name' do
|
|
|
|
before do
|
|
|
|
config = YAML.dump(deploy: { environment: { name: 'name,with,commas' }, script: 'ls' })
|
|
|
|
stub_ci_pipeline_yaml_file(config)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not create an environment' do
|
|
|
|
expect do
|
|
|
|
result = execute_service
|
|
|
|
|
|
|
|
expect(result).to be_persisted
|
|
|
|
end.not_to change { Environment.count }
|
|
|
|
end
|
|
|
|
end
|
2017-07-17 07:10:07 -04:00
|
|
|
|
|
|
|
context 'when builds with auto-retries are configured' do
|
|
|
|
before do
|
2017-07-20 01:43:15 -04:00
|
|
|
config = YAML.dump(rspec: { script: 'rspec', retry: 2 })
|
2017-07-17 07:10:07 -04:00
|
|
|
stub_ci_pipeline_yaml_file(config)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'correctly creates builds with auto-retry value configured' do
|
|
|
|
pipeline = execute_service
|
|
|
|
|
|
|
|
expect(pipeline).to be_persisted
|
2017-07-20 01:43:15 -04:00
|
|
|
expect(pipeline.builds.find_by(name: 'rspec').retries_max).to eq 2
|
2017-07-17 07:10:07 -04:00
|
|
|
end
|
|
|
|
end
|
2016-08-11 09:22:35 -04:00
|
|
|
end
|
|
|
|
end
|