2017-12-29 01:29:53 -05:00
|
|
|
# GitLab utilities
|
|
|
|
|
|
|
|
We developed a number of utilities to ease development.
|
|
|
|
|
|
|
|
## [`MergeHash`](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/lib/gitlab/utils/merge_hash.rb)
|
|
|
|
|
2018-11-13 01:07:16 -05:00
|
|
|
- Deep merges an array of hashes:
|
2017-12-29 01:29:53 -05:00
|
|
|
|
2019-07-31 04:28:51 -04:00
|
|
|
``` ruby
|
|
|
|
Gitlab::Utils::MergeHash.merge(
|
|
|
|
[{ hello: ["world"] },
|
|
|
|
{ hello: "Everyone" },
|
|
|
|
{ hello: { greetings: ['Bonjour', 'Hello', 'Hallo', 'Dzien dobry'] } },
|
|
|
|
"Goodbye", "Hallo"]
|
|
|
|
)
|
|
|
|
```
|
|
|
|
|
|
|
|
Gives:
|
|
|
|
|
|
|
|
``` ruby
|
|
|
|
[
|
|
|
|
{
|
|
|
|
hello:
|
|
|
|
[
|
|
|
|
"world",
|
|
|
|
"Everyone",
|
|
|
|
{ greetings: ['Bonjour', 'Hello', 'Hallo', 'Dzien dobry'] }
|
|
|
|
]
|
|
|
|
},
|
|
|
|
"Goodbye"
|
|
|
|
]
|
|
|
|
```
|
2017-12-29 01:29:53 -05:00
|
|
|
|
2018-11-13 01:07:16 -05:00
|
|
|
- Extracts all keys and values from a hash into an array:
|
2017-12-29 01:29:53 -05:00
|
|
|
|
2019-07-31 04:28:51 -04:00
|
|
|
``` ruby
|
|
|
|
Gitlab::Utils::MergeHash.crush(
|
|
|
|
{ hello: "world", this: { crushes: ["an entire", "hash"] } }
|
|
|
|
)
|
|
|
|
```
|
2017-12-29 01:29:53 -05:00
|
|
|
|
2019-07-31 04:28:51 -04:00
|
|
|
Gives:
|
2017-12-29 01:29:53 -05:00
|
|
|
|
2019-07-31 04:28:51 -04:00
|
|
|
``` ruby
|
|
|
|
[:hello, "world", :this, :crushes, "an entire", "hash"]
|
|
|
|
```
|
2017-12-29 01:29:53 -05:00
|
|
|
|
2018-01-12 06:37:03 -05:00
|
|
|
## [`Override`](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/lib/gitlab/utils/override.rb)
|
|
|
|
|
2018-11-13 01:07:16 -05:00
|
|
|
- This utility could help us check if a particular method would override
|
2018-01-12 06:37:03 -05:00
|
|
|
another method or not. It has the same idea of Java's `@Override` annotation
|
|
|
|
or Scala's `override` keyword. However we only do this check when
|
|
|
|
`ENV['STATIC_VERIFICATION']` is set to avoid production runtime overhead.
|
|
|
|
This is useful to check:
|
|
|
|
|
2019-07-31 04:28:51 -04:00
|
|
|
- If we have typos in overriding methods.
|
|
|
|
- If we renamed the overridden methods, making original overriding methods
|
|
|
|
overrides nothing.
|
2018-01-12 06:37:03 -05:00
|
|
|
|
|
|
|
Here's a simple example:
|
|
|
|
|
|
|
|
``` ruby
|
|
|
|
class Base
|
|
|
|
def execute
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
class Derived < Base
|
|
|
|
extend ::Gitlab::Utils::Override
|
|
|
|
|
|
|
|
override :execute # Override check happens here
|
|
|
|
def execute
|
|
|
|
end
|
|
|
|
end
|
|
|
|
```
|
|
|
|
|
|
|
|
This also works on modules:
|
|
|
|
|
|
|
|
``` ruby
|
|
|
|
module Extension
|
|
|
|
extend ::Gitlab::Utils::Override
|
|
|
|
|
|
|
|
override :execute # Modules do not check this immediately
|
|
|
|
def execute
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
class Derived < Base
|
|
|
|
prepend Extension # Override check happens here, not in the module
|
|
|
|
end
|
|
|
|
```
|
|
|
|
|
2017-12-29 01:29:53 -05:00
|
|
|
## [`StrongMemoize`](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/lib/gitlab/utils/strong_memoize.rb)
|
|
|
|
|
2018-11-13 01:07:16 -05:00
|
|
|
- Memoize the value even if it is `nil` or `false`.
|
2017-12-29 01:29:53 -05:00
|
|
|
|
2019-07-31 04:28:51 -04:00
|
|
|
We often do `@value ||= compute`, however this doesn't work well if
|
|
|
|
`compute` might eventually give `nil` and we don't want to compute again.
|
|
|
|
Instead we could use `defined?` to check if the value is set or not.
|
|
|
|
However it's tedious to write such pattern, and `StrongMemoize` would
|
|
|
|
help us use such pattern.
|
2017-12-29 01:29:53 -05:00
|
|
|
|
2019-07-31 04:28:51 -04:00
|
|
|
Instead of writing patterns like this:
|
2017-12-29 01:29:53 -05:00
|
|
|
|
2019-07-31 04:28:51 -04:00
|
|
|
``` ruby
|
|
|
|
class Find
|
|
|
|
def result
|
|
|
|
return @result if defined?(@result)
|
2017-12-29 01:29:53 -05:00
|
|
|
|
2019-07-31 04:28:51 -04:00
|
|
|
@result = search
|
2017-12-29 01:29:53 -05:00
|
|
|
end
|
2019-07-31 04:28:51 -04:00
|
|
|
end
|
|
|
|
```
|
2017-12-29 01:29:53 -05:00
|
|
|
|
2019-07-31 04:28:51 -04:00
|
|
|
We could write it like:
|
2017-12-29 01:29:53 -05:00
|
|
|
|
2019-07-31 04:28:51 -04:00
|
|
|
``` ruby
|
|
|
|
class Find
|
|
|
|
include Gitlab::Utils::StrongMemoize
|
2017-12-29 01:29:53 -05:00
|
|
|
|
2019-07-31 04:28:51 -04:00
|
|
|
def result
|
|
|
|
strong_memoize(:result) do
|
|
|
|
search
|
2017-12-29 01:29:53 -05:00
|
|
|
end
|
|
|
|
end
|
2019-07-31 04:28:51 -04:00
|
|
|
end
|
|
|
|
```
|
2017-12-29 01:29:53 -05:00
|
|
|
|
2018-11-13 01:07:16 -05:00
|
|
|
- Clear memoization
|
2017-12-29 01:29:53 -05:00
|
|
|
|
2019-07-31 04:28:51 -04:00
|
|
|
``` ruby
|
|
|
|
class Find
|
|
|
|
include Gitlab::Utils::StrongMemoize
|
|
|
|
end
|
2017-12-29 01:29:53 -05:00
|
|
|
|
2019-07-31 04:28:51 -04:00
|
|
|
Find.new.clear_memoization(:result)
|
|
|
|
```
|
2018-06-21 07:46:52 -04:00
|
|
|
|
|
|
|
## [`RequestCache`](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/lib/gitlab/cache/request_cache.rb)
|
|
|
|
|
|
|
|
This module provides a simple way to cache values in RequestStore,
|
|
|
|
and the cache key would be based on the class name, method name,
|
|
|
|
optionally customized instance level values, optionally customized
|
|
|
|
method level values, and optional method arguments.
|
|
|
|
|
|
|
|
A simple example that only uses the instance level customised values:
|
|
|
|
|
|
|
|
``` ruby
|
|
|
|
class UserAccess
|
|
|
|
extend Gitlab::Cache::RequestCache
|
|
|
|
|
|
|
|
request_cache_key do
|
|
|
|
[user&.id, project&.id]
|
|
|
|
end
|
|
|
|
|
|
|
|
request_cache def can_push_to_branch?(ref)
|
|
|
|
# ...
|
|
|
|
end
|
|
|
|
end
|
|
|
|
```
|
|
|
|
|
|
|
|
This way, the result of `can_push_to_branch?` would be cached in
|
|
|
|
`RequestStore.store` based on the cache key. If `RequestStore` is not
|
|
|
|
currently active, then it would be stored in a hash saved in an
|
|
|
|
instance variable, so the cache logic would be the same.
|
|
|
|
|
|
|
|
We can also set different strategies for different methods:
|
|
|
|
|
|
|
|
``` ruby
|
|
|
|
class Commit
|
|
|
|
extend Gitlab::Cache::RequestCache
|
|
|
|
|
|
|
|
def author
|
2018-11-07 06:00:21 -05:00
|
|
|
User.find_by_any_email(author_email)
|
2018-06-21 07:46:52 -04:00
|
|
|
end
|
2018-11-07 06:00:21 -05:00
|
|
|
request_cache(:author) { author_email }
|
2018-06-21 07:46:52 -04:00
|
|
|
end
|
|
|
|
```
|