2014-04-02 06:54:41 -04:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe Issues::UpdateService do
|
|
|
|
let(:user) { create(:user) }
|
2014-04-02 09:33:07 -04:00
|
|
|
let(:user2) { create(:user) }
|
2015-11-17 10:51:39 -05:00
|
|
|
let(:user3) { create(:user) }
|
|
|
|
let(:issue) { create(:issue, title: 'Old title', assignee_id: user3.id) }
|
2015-02-07 06:14:55 -05:00
|
|
|
let(:label) { create(:label) }
|
2015-05-15 09:38:05 -04:00
|
|
|
let(:project) { issue.project }
|
2014-04-02 06:54:41 -04:00
|
|
|
|
2014-04-02 09:33:07 -04:00
|
|
|
before do
|
|
|
|
project.team << [user, :master]
|
|
|
|
project.team << [user2, :developer]
|
2015-11-17 10:51:39 -05:00
|
|
|
project.team << [user3, :developer]
|
2014-04-02 09:33:07 -04:00
|
|
|
end
|
|
|
|
|
2015-05-26 21:49:04 -04:00
|
|
|
describe 'execute' do
|
2015-10-22 11:18:59 -04:00
|
|
|
def find_note(starting_with)
|
|
|
|
@issue.notes.find do |note|
|
|
|
|
note && note.note.start_with?(starting_with)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def update_issue(opts)
|
|
|
|
@issue = Issues::UpdateService.new(project, user, opts).execute(issue)
|
|
|
|
@issue.reload
|
|
|
|
end
|
|
|
|
|
2014-04-02 06:54:41 -04:00
|
|
|
context "valid params" do
|
|
|
|
before do
|
|
|
|
opts = {
|
|
|
|
title: 'New title',
|
2014-04-02 09:33:07 -04:00
|
|
|
description: 'Also please fix',
|
|
|
|
assignee_id: user2.id,
|
2015-02-07 06:14:55 -05:00
|
|
|
state_event: 'close',
|
|
|
|
label_ids: [label.id]
|
2014-04-02 06:54:41 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
@issue = Issues::UpdateService.new(project, user, opts).execute(issue)
|
2015-01-26 01:49:05 -05:00
|
|
|
@issue.reload
|
2014-04-02 06:54:41 -04:00
|
|
|
end
|
|
|
|
|
2015-02-12 13:17:35 -05:00
|
|
|
it { expect(@issue).to be_valid }
|
|
|
|
it { expect(@issue.title).to eq('New title') }
|
|
|
|
it { expect(@issue.assignee).to eq(user2) }
|
|
|
|
it { expect(@issue).to be_closed }
|
|
|
|
it { expect(@issue.labels.count).to eq(1) }
|
|
|
|
it { expect(@issue.labels.first.title).to eq('Bug') }
|
2014-04-02 09:33:07 -04:00
|
|
|
|
2015-11-17 10:53:15 -05:00
|
|
|
it 'should send email to user2 about assign of new issue and email to user3 about issue unassignment' do
|
2015-11-17 10:51:39 -05:00
|
|
|
deliveries = ActionMailer::Base.deliveries
|
2015-11-09 11:26:01 -05:00
|
|
|
email = deliveries.last
|
2015-11-17 10:51:39 -05:00
|
|
|
recipients = deliveries.last(2).map(&:to).flatten
|
|
|
|
expect(recipients).to include(user2.email, user3.email)
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(email.subject).to include(issue.title)
|
2014-04-02 09:33:07 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'should create system note about issue reassign' do
|
2015-05-26 21:49:04 -04:00
|
|
|
note = find_note('Reassigned to')
|
|
|
|
|
|
|
|
expect(note).not_to be_nil
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(note.note).to include "Reassigned to \@#{user2.username}"
|
2014-04-02 09:33:07 -04:00
|
|
|
end
|
2015-02-07 06:14:55 -05:00
|
|
|
|
|
|
|
it 'should create system note about issue label edit' do
|
2015-05-26 21:49:04 -04:00
|
|
|
note = find_note('Added ~')
|
|
|
|
|
|
|
|
expect(note).not_to be_nil
|
2015-02-12 13:17:35 -05:00
|
|
|
expect(note.note).to include "Added ~#{label.id} label"
|
2015-02-07 06:14:55 -05:00
|
|
|
end
|
2015-05-26 21:49:04 -04:00
|
|
|
|
|
|
|
it 'creates system note about title change' do
|
|
|
|
note = find_note('Title changed')
|
|
|
|
|
|
|
|
expect(note).not_to be_nil
|
|
|
|
expect(note.note).to eq 'Title changed from **Old title** to **New title**'
|
|
|
|
end
|
2014-04-02 06:54:41 -04:00
|
|
|
end
|
2015-10-22 11:18:59 -04:00
|
|
|
|
|
|
|
context 'when Issue has tasks' do
|
|
|
|
before { update_issue({ description: "- [ ] Task 1\n- [ ] Task 2" }) }
|
|
|
|
|
|
|
|
it { expect(@issue.tasks?).to eq(true) }
|
|
|
|
|
|
|
|
context 'when tasks are marked as completed' do
|
|
|
|
before { update_issue({ description: "- [x] Task 1\n- [X] Task 2" }) }
|
|
|
|
|
|
|
|
it 'creates system note about task status change' do
|
|
|
|
note1 = find_note('Marked the task **Task 1** as completed')
|
|
|
|
note2 = find_note('Marked the task **Task 2** as completed')
|
|
|
|
|
|
|
|
expect(note1).not_to be_nil
|
|
|
|
expect(note2).not_to be_nil
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when tasks are marked as incomplete' do
|
|
|
|
before do
|
|
|
|
update_issue({ description: "- [x] Task 1\n- [X] Task 2" })
|
|
|
|
update_issue({ description: "- [ ] Task 1\n- [ ] Task 2" })
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'creates system note about task status change' do
|
|
|
|
note1 = find_note('Marked the task **Task 1** as incomplete')
|
|
|
|
note2 = find_note('Marked the task **Task 2** as incomplete')
|
|
|
|
|
|
|
|
expect(note1).not_to be_nil
|
|
|
|
expect(note2).not_to be_nil
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when tasks position has been modified' do
|
|
|
|
before do
|
|
|
|
update_issue({ description: "- [x] Task 1\n- [X] Task 2" })
|
|
|
|
update_issue({ description: "- [x] Task 1\n- [ ] Task 3\n- [ ] Task 2" })
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not create a system note' do
|
|
|
|
note = find_note('Marked the task **Task 2** as incomplete')
|
|
|
|
|
|
|
|
expect(note).to be_nil
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2014-04-02 06:54:41 -04:00
|
|
|
end
|
|
|
|
end
|