gitlab-org--gitlab-foss/app/models/note.rb

207 lines
5.1 KiB
Ruby
Raw Normal View History

2012-11-19 18:24:05 +00:00
# == Schema Information
#
# Table name: notes
#
# id :integer not null, primary key
# note :text
# noteable_type :string(255)
# author_id :integer
2013-06-19 12:40:33 +00:00
# created_at :datetime
# updated_at :datetime
2012-11-19 18:24:05 +00:00
# project_id :integer
# attachment :string(255)
# line_code :string(255)
2013-01-03 19:09:18 +00:00
# commit_id :string(255)
# noteable_id :integer
2012-11-19 18:24:05 +00:00
#
2011-10-08 21:36:38 +00:00
require 'carrierwave/orm/activerecord'
require 'file_size_validator'
class Note < ActiveRecord::Base
include Mentionable
attr_accessible :note, :noteable, :noteable_id, :noteable_type, :project_id,
:attachment, :line_code, :commit_id
2011-10-08 21:36:38 +00:00
belongs_to :project
belongs_to :noteable, polymorphic: true
2012-09-27 06:20:36 +00:00
belongs_to :author, class_name: "User"
2011-10-08 21:36:38 +00:00
2012-09-27 06:20:36 +00:00
delegate :name, to: :project, prefix: true
delegate :name, :email, to: :author, prefix: true
2012-12-01 11:19:16 +00:00
validates :note, :project, presence: true
validates :line_code, format: { with: /\A[a-z0-9]+_\d+_\d+\Z/ }, allow_blank: true
validates :attachment, file_size: { maximum: 10.megabytes.to_i }
2011-10-08 21:36:38 +00:00
validates :noteable_id, presence: true, if: ->(n) { n.noteable_type.present? && n.noteable_type != 'Commit' }
validates :commit_id, presence: true, if: ->(n) { n.noteable_type == 'Commit' }
2012-12-01 11:19:16 +00:00
mount_uploader :attachment, AttachmentUploader
2012-10-09 00:10:04 +00:00
# Scopes
2013-01-05 11:11:15 +00:00
scope :for_commit_id, ->(commit_id) { where(noteable_type: "Commit", commit_id: commit_id) }
scope :inline, ->{ where("line_code IS NOT NULL") }
scope :not_inline, ->{ where(line_code: [nil, '']) }
2013-01-05 11:11:15 +00:00
scope :common, ->{ where(noteable_type: ["", nil]) }
scope :fresh, ->{ order("created_at ASC, id ASC") }
scope :inc_author_project, ->{ includes(:project, :author) }
scope :inc_author, ->{ includes(:author) }
2011-10-18 11:33:30 +00:00
serialize :st_diff
before_create :set_diff, if: ->(n) { n.line_code.present? }
Merge Request on forked projects The good: - You can do a merge request for a forked commit and it will merge properly (i.e. it does work). - Push events take into account merge requests on forked projects - Tests around merge_actions now present, spinach, and other rspec tests - Satellites now clean themselves up rather then recreate The questionable: - Events only know about target projects - Project's merge requests only hold on to MR's where they are the target - All operations performed in the satellite The bad: - Duplication between project's repositories and satellites (e.g. commits_between) (for reference: http://feedback.gitlab.com/forums/176466-general/suggestions/3456722-merge-requests-between-projects-repos) Fixes: Make test repos/satellites only create when needed -Spinach/Rspec now only initialize test directory, and setup stubs (things that are relatively cheap) -project_with_code, source_project_with_code, and target_project_with_code now create/destroy their repos individually -fixed remote removal -How to merge renders properly -Update emails to show project/branches -Edit MR doesn't set target branch -Fix some failures on editing/creating merge requests, added a test -Added back a test around merge request observer -Clean up project_transfer_spec, Remove duplicate enable/disable observers -Ensure satellite lock files are cleaned up, Attempted to add some testing around these as well -Signifant speed ups for tests -Update formatting ordering in notes_on_merge_requests -Remove wiki schema update Fixes for search/search results -Search results was using by_project for a list of projects, updated this to use in_projects -updated search results to reference the correct (target) project -udpated search results to print both sides of the merge request Change-Id: I19407990a0950945cc95d62089cbcc6262dab1a8
2013-04-25 14:15:33 +00:00
def self.create_status_change_note(noteable, project, author, status)
2012-09-27 06:20:36 +00:00
create({
noteable: noteable,
project: project,
author: author,
note: "_Status changed to #{status}_"
}, without_protection: true)
end
2012-10-29 14:49:37 +00:00
def commit_author
@commit_author ||=
project.users.find_by_email(noteable.author_email) ||
project.users.find_by_name(noteable.author_name)
2012-10-29 14:49:37 +00:00
rescue
nil
2011-12-17 13:58:35 +00:00
end
def find_diff
return nil unless noteable && noteable.diffs.present?
@diff ||= noteable.diffs.find do |d|
Digest::SHA1.hexdigest(d.new_path) == diff_file_index if d.new_path
2013-01-15 09:12:17 +00:00
end
2012-10-29 14:49:37 +00:00
end
def set_diff
# First lets find notes with same diff
# before iterating over all mr diffs
diff = Note.where(noteable_id: self.noteable_id, noteable_type: self.noteable_type, line_code: self.line_code).last.try(:diff)
diff ||= find_diff
self.st_diff = diff.to_hash if diff
end
def diff
@diff ||= Gitlab::Git::Diff.new(st_diff) if st_diff.respond_to?(:map)
end
def active?
# TODO: determine if discussion is outdated
# according to recent MR diff or not
true
end
2012-10-29 14:49:37 +00:00
def diff_file_index
2013-01-15 09:12:17 +00:00
line_code.split('_')[0]
2012-10-29 14:49:37 +00:00
end
def diff_file_name
diff.new_path if diff
2012-10-29 14:49:37 +00:00
end
def diff_old_line
line_code.split('_')[1].to_i
2012-10-29 14:49:37 +00:00
end
def diff_new_line
line_code.split('_')[2].to_i
end
def diff_line
return @diff_line if @diff_line
if diff
Gitlab::DiffParser.new(diff).each do |full_line, type, line_code, line_new, line_old|
@diff_line = full_line if line_code == self.line_code
end
end
@diff_line
end
2012-10-29 14:49:37 +00:00
def discussion_id
@discussion_id ||= [:discussion, noteable_type.try(:underscore), noteable_id || commit_id, line_code].join("-").to_sym
2012-10-29 14:49:37 +00:00
end
# Returns true if this is a downvote note,
# otherwise false is returned
def downvote?
2012-10-30 02:27:36 +00:00
votable? && (note.start_with?('-1') ||
note.start_with?(':-1:')
)
2012-10-29 14:49:37 +00:00
end
def for_commit?
noteable_type == "Commit"
end
def for_commit_diff_line?
for_commit? && for_diff_line?
end
def for_diff_line?
line_code.present?
end
2012-10-30 02:27:36 +00:00
def for_issue?
noteable_type == "Issue"
end
2012-10-29 14:49:37 +00:00
def for_merge_request?
noteable_type == "MergeRequest"
end
def for_merge_request_diff_line?
for_merge_request? && for_diff_line?
end
2012-01-04 20:19:41 +00:00
2012-11-22 01:57:22 +00:00
def for_wall?
noteable_type.blank?
end
2012-10-13 14:23:12 +00:00
# override to return commits, which are not active record
def noteable
if for_commit?
project.repository.commit(commit_id)
2012-03-14 13:31:31 +00:00
else
2012-10-13 14:23:12 +00:00
super
2012-01-04 20:19:41 +00:00
end
# Temp fix to prevent app crash
# if note commit id doesn't exist
2012-03-14 13:31:31 +00:00
rescue
2012-01-20 07:51:48 +00:00
nil
2012-01-04 20:19:41 +00:00
end
2012-02-10 02:59:39 +00:00
2012-03-14 13:31:31 +00:00
# Returns true if this is an upvote note,
# otherwise false is returned
def upvote?
2012-10-30 02:27:36 +00:00
votable? && (note.start_with?('+1') ||
note.start_with?(':+1:')
)
2012-10-30 02:27:36 +00:00
end
def votable?
for_issue? || (for_merge_request? && !for_diff_line?)
2012-03-14 13:31:31 +00:00
end
def noteable_type_name
if noteable_type.present?
noteable_type.downcase
else
"wall"
end
end
2013-03-25 11:58:09 +00:00
# FIXME: Hack for polymorphic associations with STI
# For more information wisit http://api.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html#label-Polymorphic+Associations
def noteable_type=(sType)
super(sType.to_s.classify.constantize.base_class.to_s)
end
2011-10-08 21:36:38 +00:00
end