From 000087abd5a11442a7e34b0e5f3bf86cb40fa8e4 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 16 Jul 2020 06:09:33 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- app/assets/javascripts/awards_handler.js | 5 - .../batch_comments/components/draft_note.vue | 7 +- .../diffs/components/diff_line_note_form.vue | 5 +- .../components/inline_diff_table_row.vue | 10 +- .../diffs/components/inline_diff_view.vue | 14 +- .../components/parallel_diff_table_row.vue | 7 + .../diffs/components/parallel_diff_view.vue | 14 +- .../fragments/user.fragment.graphql | 7 + .../notes/components/discussion_notes.vue | 8 +- .../components/multiline_comment_form.vue | 16 ++ .../components/multiline_comment_utils.js | 19 ++ .../notes/components/noteable_note.vue | 6 +- .../javascripts/notes/stores/actions.js | 8 + .../javascripts/notes/stores/modules/index.js | 9 + .../notes/stores/mutation_types.js | 2 + .../javascripts/notes/stores/mutations.js | 8 + .../repository/components/table/index.vue | 1 + .../repository/components/table/row.vue | 6 + .../vue_shared/components/file_icon.vue | 24 +- .../javascripts/vue_shared/constants.js | 2 + .../components/design_management/design.scss | 5 +- app/graphql/resolvers/issues_resolver.rb | 2 + app/graphql/types/issue_connection_type.rb | 13 + app/graphql/types/issue_type.rb | 2 + .../issuable/_bulk_update_sidebar.html.haml | 2 +- .../design-management-transitions.yml | 5 + .../jdb-highlight-commented-rows.yml | 5 + changelogs/unreleased/symlink-icon-ui.yml | 5 + doc/.vale/gitlab/AlertBoxStyle.yml | 5 +- doc/administration/auth/jwt.md | 3 +- .../auth/ldap/google_secure_ldap.md | 3 +- .../auth/ldap/ldap-troubleshooting.md | 4 +- .../disaster_recovery/bring_primary_back.md | 6 +- .../geo/replication/database.md | 6 +- .../geo/replication/datatypes.md | 2 +- .../geo/replication/external_database.md | 3 +- .../geo/replication/multiple_servers.md | 9 +- .../geo/replication/troubleshooting.md | 7 +- .../geo/replication/updating_the_geo_nodes.md | 3 +- doc/administration/gitaly/praefect.md | 18 +- .../high_availability/consul.md | 4 +- .../high_availability/gitlab.md | 18 +- doc/administration/high_availability/nfs.md | 9 +- .../high_availability/sidekiq.md | 3 +- doc/administration/instance_limits.md | 15 +- doc/administration/integration/plantuml.md | 3 +- doc/administration/integration/terminal.md | 3 +- doc/administration/job_artifacts.md | 13 +- doc/administration/job_logs.md | 2 +- doc/administration/lfs/index.md | 3 +- doc/administration/logs.md | 3 +- doc/administration/merge_request_diffs.md | 3 +- doc/administration/object_storage.md | 15 +- .../operations/fast_ssh_key_lookup.md | 12 +- .../operations/filesystem_benchmarking.md | 3 +- .../packages/container_registry.md | 6 +- .../packages/dependency_proxy.md | 3 +- doc/administration/packages/index.md | 3 +- .../postgresql/replication_and_failover.md | 9 +- doc/administration/postgresql/standalone.md | 3 +- doc/administration/raketasks/ldap.md | 2 +- doc/administration/raketasks/maintenance.md | 2 +- .../redis/replication_and_failover.md | 3 +- .../reference_architectures/2k_users.md | 3 +- .../reference_architectures/3k_users.md | 3 +- .../reference_architectures/index.md | 3 +- .../repository_storage_paths.md | 3 +- doc/administration/smime_signing_email.md | 9 +- .../gitlab_rails_cheat_sheet.md | 4 +- .../troubleshooting/linux_cheat_sheet.md | 2 +- .../navigating_gitlab_via_rails_console.md | 2 +- .../troubleshooting/postgresql.md | 6 +- doc/administration/troubleshooting/sidekiq.md | 3 +- doc/administration/uploads.md | 3 +- doc/api/epics.md | 2 +- doc/api/feature_flag_specs.md | 2 +- doc/api/feature_flags_legacy.md | 2 +- .../graphql/reference/gitlab_schema.graphql | 25 ++ doc/api/graphql/reference/gitlab_schema.json | 78 +++++ doc/api/group_labels.md | 6 +- doc/api/issues.md | 2 +- doc/api/labels.md | 9 +- doc/api/merge_requests.md | 2 +- doc/api/namespaces.md | 3 +- doc/api/packages.md | 4 +- doc/api/projects.md | 9 +- doc/api/users.md | 6 +- doc/ci/docker/using_docker_images.md | 9 +- doc/ci/environments/index.md | 2 +- .../index.md | 4 +- doc/ci/interactive_web_terminal/index.md | 6 +- doc/ci/pipelines/job_artifacts.md | 2 +- doc/ci/yaml/README.md | 7 +- doc/development/api_graphql_styleguide.md | 3 +- doc/development/application_limits.md | 12 +- doc/development/chatops_on_gitlabcom.md | 3 +- doc/development/cicd/index.md | 6 +- .../add_foreign_key_to_existing_column.md | 3 +- doc/development/database_review.md | 3 +- .../site_architecture/global_nav.md | 4 +- .../documentation/site_architecture/index.md | 2 +- doc/development/geo/framework.md | 6 +- doc/development/gitaly.md | 3 +- doc/development/i18n/externalization.md | 3 +- doc/development/import_export.md | 3 +- doc/development/import_project.md | 3 +- doc/development/migration_style_guide.md | 3 +- doc/development/packages.md | 3 +- doc/development/performance.md | 3 +- doc/development/profiling.md | 3 +- doc/development/sidekiq_style_guide.md | 3 +- .../testing_guide/best_practices.md | 3 +- .../end_to_end/environment_selection.md | 9 +- .../end_to_end/rspec_metadata_tests.md | 2 +- doc/development/what_requires_downtime.md | 3 +- doc/install/aws/index.md | 15 +- doc/install/openshift_and_gitlab/index.md | 3 +- doc/install/requirements.md | 12 +- doc/integration/elasticsearch.md | 9 +- doc/policy/maintenance.md | 3 +- doc/raketasks/backup_restore.md | 3 +- doc/security/rack_attack.md | 6 +- doc/topics/autodevops/customize.md | 4 +- doc/topics/autodevops/stages.md | 8 +- doc/topics/autodevops/upgrading_postgresql.md | 9 +- doc/update/README.md | 6 +- doc/update/upgrading_from_ce_to_ee.md | 3 +- .../configuration/index.md | 3 +- doc/user/application_security/dast/index.md | 17 +- doc/user/application_security/sast/index.md | 3 +- .../secret_detection/index.md | 3 +- doc/user/group/index.md | 2 +- doc/user/group/saml_sso/index.md | 3 +- doc/user/group/saml_sso/scim_setup.md | 6 +- doc/user/markdown.md | 18 +- doc/user/packages/npm_registry/index.md | 3 +- doc/user/profile/account/delete_account.md | 3 +- .../project/clusters/add_remove_clusters.md | 3 +- doc/user/project/clusters/index.md | 5 +- .../prometheus_library/nginx_ingress.md | 3 +- .../prometheus_library/nginx_ingress_vts.md | 3 +- .../project/issues/crosslinking_issues.md | 3 +- doc/user/project/issues/csv_import.md | 3 +- doc/user/project/labels.md | 2 +- .../repository/x509_signed_commits/index.md | 6 +- doc/user/project/web_ide/index.md | 6 +- locale/gitlab.pot | 19 ++ .../non_devops/performance_bar_spec.rb | 2 +- qa/qa/specs/helpers/quarantine.rb | 32 ++- qa/spec/specs/helpers/quarantine_spec.rb | 33 ++- spec/frontend/awards_handler_spec.js | 269 +++++++----------- .../blob_header_filepath_spec.js.snap | 1 + .../components/inline_diff_table_row_spec.js | 53 ++-- .../parallel_diff_table_row_spec.js | 28 +- .../helpers/fake_request_animation_frame.js | 13 + .../multiline_comment_utils_spec.js | 27 ++ .../notes/components/noteable_note_spec.js | 1 + spec/frontend/notes/stores/actions_spec.js | 13 + spec/frontend/notes/stores/mutation_spec.js | 20 ++ .../table/__snapshots__/row_spec.js.snap | 55 ++++ .../repository/components/table/index_spec.js | 15 +- .../repository/components/table/row_spec.js | 16 ++ .../vue_shared/components/file_icon_spec.js | 27 +- .../types/issue_connection_type_spec.rb | 11 + spec/graphql/types/issue_type_spec.rb | 98 +++++++ ...rpolation_format_in_common_metrics_spec.rb | 11 +- 166 files changed, 1201 insertions(+), 452 deletions(-) create mode 100644 app/assets/javascripts/graphql_shared/fragments/user.fragment.graphql create mode 100644 app/graphql/types/issue_connection_type.rb create mode 100644 changelogs/unreleased/design-management-transitions.yml create mode 100644 changelogs/unreleased/jdb-highlight-commented-rows.yml create mode 100644 changelogs/unreleased/symlink-icon-ui.yml create mode 100644 spec/frontend/helpers/fake_request_animation_frame.js create mode 100644 spec/graphql/types/issue_connection_type_spec.rb diff --git a/app/assets/javascripts/awards_handler.js b/app/assets/javascripts/awards_handler.js index 217577de7cb..0e83ba3d528 100644 --- a/app/assets/javascripts/awards_handler.js +++ b/app/assets/javascripts/awards_handler.js @@ -13,11 +13,6 @@ import * as Emoji from '~/emoji'; const animationEndEventString = 'animationend webkitAnimationEnd MSAnimationEnd oAnimationEnd'; const transitionEndEventString = 'transitionend webkitTransitionEnd oTransitionEnd MSTransitionEnd'; -const requestAnimationFrame = - window.requestAnimationFrame || - window.webkitRequestAnimationFrame || - window.mozRequestAnimationFrame || - window.setTimeout; const FROM_SENTENCE_REGEX = /(?:, and | and |, )/; // For separating lists produced by ruby's Array#toSentence diff --git a/app/assets/javascripts/batch_comments/components/draft_note.vue b/app/assets/javascripts/batch_comments/components/draft_note.vue index db5516b7b93..4c100ec7335 100644 --- a/app/assets/javascripts/batch_comments/components/draft_note.vue +++ b/app/assets/javascripts/batch_comments/components/draft_note.vue @@ -51,6 +51,7 @@ export default { 'scrollToDraft', 'toggleResolveDiscussion', ]), + ...mapActions(['setSelectedCommentPositionHover']), update(data) { this.updateDraft(data); }, @@ -67,7 +68,11 @@ export default { };