Suppress warning about missing `.gitlab-ci.yml` if builds are disabled

When user disables GitLab Ci Service in project's settings then warning
about missing `.gitlab-ci.yml` file should be supressed. This a matter
of user experience as stated in #3761 (closes #3761).
This commit is contained in:
Grzegorz Bizon 2015-12-08 11:02:13 +01:00
parent c80f34257d
commit 00155b6c69
1 changed files with 21 additions and 7 deletions

View File

@ -60,15 +60,29 @@ describe "Commits" do
end
describe ".gitlab-ci.yml not found warning" do
it "does not show warning" do
visit ci_status_path(@commit)
expect(page).not_to have_content ".gitlab-ci.yml not found in this commit"
context 'ci service enabled' do
it "does not show warning" do
visit ci_status_path(@commit)
expect(page).not_to have_content ".gitlab-ci.yml not found in this commit"
end
it "shows warning" do
stub_ci_commit_yaml_file(nil)
visit ci_status_path(@commit)
expect(page).to have_content ".gitlab-ci.yml not found in this commit"
end
end
it "shows warning" do
stub_ci_commit_yaml_file(nil)
visit ci_status_path(@commit)
expect(page).to have_content ".gitlab-ci.yml not found in this commit"
context 'ci service disabled' do
before do
allow_any_instance_of(GitlabCiService).to receive(:active).and_return(false)
stub_ci_commit_yaml_file(nil)
visit ci_status_path(@commit)
end
it 'does not show warning' do
expect(page).not_to have_content '.gitlab-ci.yml not found in this commit'
end
end
end
end