References for the issues the guide addresses.

This commit is contained in:
dosire 2014-03-24 12:04:43 +01:00
parent 0aa389b491
commit 00487d455a

View file

@ -1,5 +1,11 @@
# Guidelines for shell commands in the GitLab codebase # Guidelines for shell commands in the GitLab codebase
## References
- [Google Ruby Security Reviewer's Guide](https://code.google.com/p/ruby-security/wiki/Guide)
- [OWASP Command Injection](https://www.owasp.org/index.php/Command_Injection)
- [Ruby on Rails Security Guide](http://guides.rubyonrails.org/security.html) section 7.7
## Use File and FileUtils instead of shell commands ## Use File and FileUtils instead of shell commands
Sometimes we invoke basic Unix commands via the shell when there is also a Ruby API for doing it. Sometimes we invoke basic Unix commands via the shell when there is also a Ruby API for doing it.