BB importer: Fixed after code review[ci skip]
This commit is contained in:
parent
a2be395401
commit
0057ed1e69
3 changed files with 7 additions and 1 deletions
|
@ -29,7 +29,7 @@ module Bitbucket
|
|||
end
|
||||
|
||||
def fetch_next_page
|
||||
parsed_response = connection.get(next_url, { pagelen: PAGE_LENGTH, sort: :created_on })
|
||||
parsed_response = connection.get(next_url, pagelen: PAGE_LENGTH, sort: :created_on)
|
||||
Page.new(parsed_response, type)
|
||||
end
|
||||
end
|
||||
|
|
|
@ -18,6 +18,7 @@ end
|
|||
describe Bitbucket::Collection do
|
||||
it "iterates paginator" do
|
||||
collection = described_class.new(TestPaginator.new)
|
||||
|
||||
expect(collection.to_a).to match(["result_1_page_1", "result_2_page_1", "result_1_page_2", "result_2_page_2"])
|
||||
end
|
||||
end
|
||||
|
|
|
@ -4,7 +4,9 @@ describe Bitbucket::Connection do
|
|||
describe '#get' do
|
||||
it 'calls OAuth2::AccessToken::get' do
|
||||
expect_any_instance_of(OAuth2::AccessToken).to receive(:get).and_return(double(parsed: true))
|
||||
|
||||
connection = described_class.new({})
|
||||
|
||||
connection.get('/users')
|
||||
end
|
||||
end
|
||||
|
@ -12,6 +14,7 @@ describe Bitbucket::Connection do
|
|||
describe '#expired?' do
|
||||
it 'calls connection.expired?' do
|
||||
expect_any_instance_of(OAuth2::AccessToken).to receive(:expired?).and_return(true)
|
||||
|
||||
expect(described_class.new({}).expired?).to be_truthy
|
||||
end
|
||||
end
|
||||
|
@ -19,7 +22,9 @@ describe Bitbucket::Connection do
|
|||
describe '#refresh!' do
|
||||
it 'calls connection.refresh!' do
|
||||
response = double(token: nil, expires_at: nil, expires_in: nil, refresh_token: nil)
|
||||
|
||||
expect_any_instance_of(OAuth2::AccessToken).to receive(:refresh!).and_return(response)
|
||||
|
||||
described_class.new({}).refresh!
|
||||
end
|
||||
end
|
||||
|
|
Loading…
Reference in a new issue