From 00b2e9ba3565505fb10a36331e6e07e636c03424 Mon Sep 17 00:00:00 2001 From: Paul Slaughter Date: Tue, 7 May 2019 14:05:59 -0500 Subject: [PATCH] Fix subpixel border issue **What?** In some browsers subpixel heights are rounded in tables. This was causing the discussion border to be hidden because the content overflowed. Adding `padding-bottom: 1px` basically overrides this rounding. https://gitlab.com/gitlab-org/gitlab-ce/issues/53973 --- app/assets/stylesheets/pages/notes.scss | 5 +++++ changelogs/unreleased/53973-fix-subpixel-border-issue.yml | 5 +++++ 2 files changed, 10 insertions(+) create mode 100644 changelogs/unreleased/53973-fix-subpixel-border-issue.yml diff --git a/app/assets/stylesheets/pages/notes.scss b/app/assets/stylesheets/pages/notes.scss index 09f75cd827f..f2b67a693c3 100644 --- a/app/assets/stylesheets/pages/notes.scss +++ b/app/assets/stylesheets/pages/notes.scss @@ -471,6 +471,11 @@ $note-form-margin-left: 72px; vertical-align: top; white-space: normal; + // Fixes subpixel rounding issue https://gitlab.com/gitlab-org/gitlab-ce/issues/53973 + // background-color is needed for dark code preference + padding-bottom: 1px; + background-color: $white-light; + &.parallel { border-width: 1px; diff --git a/changelogs/unreleased/53973-fix-subpixel-border-issue.yml b/changelogs/unreleased/53973-fix-subpixel-border-issue.yml new file mode 100644 index 00000000000..0dae7047236 --- /dev/null +++ b/changelogs/unreleased/53973-fix-subpixel-border-issue.yml @@ -0,0 +1,5 @@ +--- +title: Fix MR discussion border missing in chrome sometimes +merge_request: 28185 +author: +type: fixed