kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Enable Gitaly FindCommit caching for TreeController

Browse source 
Accessing /namespace/project/tree/master appears to query
FindCommit 5 times with identical parameters. This reduces
the number of FindCommit queries to 1.
This commit is contained in:
Stan Hu 2019-04-07 20:55:29 -07:00
parent b416555411
commit 021e8790c6
3 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/controllers/projects/tree_controller.rb
View file

@ -6,6 +6,8 @@ class Projects::TreeController < Projects::ApplicationController
include CreatesCommit include CreatesCommit
include ActionView::Helpers::SanitizeHelper include ActionView::Helpers::SanitizeHelper
around_action :allow_gitaly_ref_name_caching, only: [:show]
before_action :require_non_empty_project, except: [:new, :create] before_action :require_non_empty_project, except: [:new, :create]
before_action :assign_ref_vars before_action :assign_ref_vars
before_action :assign_dir_vars, only: [:create_dir] before_action :assign_dir_vars, only: [:create_dir]

5
changelogs/unreleased/sh-add-gitaly-ref-name-caching-tree-controller.yml Normal file
View file

@ -0,0 +1,5 @@
---
title: Enable Gitaly FindCommit caching for TreeController
merge_request: 27100
author:
type: performance

2
spec/controllers/projects/tree_controller_spec.rb
View file

@ -16,6 +16,8 @@ describe Projects::TreeController do
render_views render_views
before do before do
expect(::Gitlab::GitalyClient).to receive(:allow_ref_name_caching).and_call_original
get(:show, get(:show,
params: { params: {
namespace_id: project.namespace.to_param, namespace_id: project.namespace.to_param,