From 023e050d82ed11d9060ce5bdaec99c3871b98164 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 5 May 2021 12:10:33 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- Dangerfile | 8 +- Gemfile | 2 +- Gemfile.lock | 4 +- .../components/date/sidebar_date_widget.vue | 2 + app/helpers/analytics/navbar_helper.rb | 41 ----- app/helpers/appearances_helper.rb | 3 +- app/helpers/application_helper.rb | 3 +- app/services/ci/create_pipeline_service.rb | 1 + .../ci/create_web_ide_terminal_service.rb | 7 + .../nav/sidebar/_project_menus.html.haml | 3 - ...997-enable-ci_workflow_rules_variables.yml | 5 + ...-due-date-changes-without-user-input-2.yml | 5 + .../ab-ci-builds-pending-partial-covering.yml | 5 + .../unreleased/fix-danger-changelog-bug.yml | 5 + .../unreleased/issue-327906-issue-type.yml | 5 + .../ci_pipeline_ensure_iid_on_save.yml | 8 + .../ci_pipeline_ensure_iid_on_skip.yml | 8 + .../ci_workflow_rules_variables.yml | 2 +- .../development/escalation_policies_mvc.yml | 8 + .../0_inject_enterprise_edition_module.rb | 82 +++++++--- danger/changelog/Dangerfile | 7 +- danger/changes_size/Dangerfile | 19 --- danger/database/Dangerfile | 2 +- danger/feature_flag/Dangerfile | 2 +- ...rtial_covering_index_for_pending_builds.rb | 21 +++ db/schema_migrations/20210505092746 | 1 + db/structure.sql | 2 +- doc/api/issues.md | 10 ++ doc/ci/yaml/README.md | 22 +-- doc/development/jh_features_review.md | 80 ++++++++++ doc/user/project/issues/managing_issues.md | 15 +- lib/api/entities/issue_basic.rb | 8 + lib/gitlab.rb | 10 ++ lib/gitlab/ci/pipeline/chain/skip.rb | 11 +- .../validate/security_orchestration_policy.rb | 25 ++++ lib/gitlab/import_export.rb | 18 ++- lib/gitlab/subscription_portal.rb | 2 +- lib/sidebars/projects/menus/analytics_menu.rb | 89 +++++++++++ lib/sidebars/projects/panel.rb | 1 + locale/gitlab.pot | 36 ++++- qa/qa/page/admin/menu.rb | 2 +- qa/qa/page/admin/overview/groups/edit.rb | 2 +- qa/qa/page/component/issue_board/show.rb | 2 +- qa/qa/page/dashboard/projects.rb | 2 +- qa/qa/page/file/show.rb | 2 +- qa/qa/page/group/menu.rb | 2 +- qa/qa/page/group/settings/general.rb | 2 +- qa/qa/page/main/menu.rb | 2 +- qa/qa/page/merge_request/new.rb | 2 +- qa/qa/page/merge_request/show.rb | 2 +- qa/qa/page/milestone/show.rb | 2 +- qa/qa/page/profile/menu.rb | 2 +- qa/qa/page/project/issue/index.rb | 2 +- qa/qa/page/project/issue/show.rb | 2 +- qa/qa/page/project/job/show.rb | 2 +- qa/qa/page/project/menu.rb | 2 +- qa/qa/page/project/new.rb | 2 +- qa/qa/page/project/operations/metrics/show.rb | 2 +- qa/qa/page/project/packages/index.rb | 2 +- qa/qa/page/project/pipeline/index.rb | 2 +- qa/qa/page/project/pipeline/show.rb | 2 +- qa/qa/page/project/settings/ci_cd.rb | 2 +- qa/qa/page/project/settings/integrations.rb | 2 +- qa/qa/page/project/settings/main.rb | 2 +- qa/qa/page/project/settings/merge_request.rb | 2 +- .../settings/mirroring_repositories.rb | 2 +- .../project/settings/protected_branches.rb | 2 +- qa/qa/page/project/settings/protected_tags.rb | 2 +- qa/qa/page/project/settings/repository.rb | 2 +- qa/qa/page/project/show.rb | 2 +- qa/qa/page/project/snippet/index.rb | 2 +- qa/qa/page/project/web_ide/edit.rb | 2 +- qa/qa/page/project/wiki/show.rb | 2 +- qa/qa/page/registration/welcome.rb | 2 +- qa/qa/runtime/env.rb | 2 +- qa/qa/scenario/test/sanity/selectors.rb | 2 +- scripts/sync-reports | 96 ------------ .../inject_enterprise_edition_module_spec.rb | 141 ++++++++++++++++++ spec/features/issues/issue_sidebar_spec.rb | 53 +++++-- spec/features/issues/user_edits_issue_spec.rb | 6 + spec/features/projects/navbar_spec.rb | 2 +- spec/fixtures/api/schemas/issue.json | 1 + .../date/sidebar_date_widget_spec.js | 17 ++- .../lib/gitlab/ci/pipeline/chain/skip_spec.rb | 24 ++- .../projects/menus/analytics_menu_spec.rb | 120 +++++++++++++++ .../create_web_ide_terminal_service_spec.rb | 17 +++ spec/tooling/danger/project_helper_spec.rb | 2 +- .../nav/sidebar/_project.html.haml_spec.rb | 88 +++++++---- tooling/danger/project_helper.rb | 15 -- workhorse/internal/upstream/routes.go | 3 + workhorse/upload_test.go | 1 + 91 files changed, 919 insertions(+), 327 deletions(-) create mode 100644 changelogs/unreleased/300997-enable-ci_workflow_rules_variables.yml create mode 100644 changelogs/unreleased/329614-issue-due-date-changes-without-user-input-2.yml create mode 100644 changelogs/unreleased/ab-ci-builds-pending-partial-covering.yml create mode 100644 changelogs/unreleased/fix-danger-changelog-bug.yml create mode 100644 changelogs/unreleased/issue-327906-issue-type.yml create mode 100644 config/feature_flags/development/ci_pipeline_ensure_iid_on_save.yml create mode 100644 config/feature_flags/development/ci_pipeline_ensure_iid_on_skip.yml create mode 100644 config/feature_flags/development/escalation_policies_mvc.yml delete mode 100644 danger/changes_size/Dangerfile create mode 100644 db/post_migrate/20210505092746_create_partial_covering_index_for_pending_builds.rb create mode 100644 db/schema_migrations/20210505092746 create mode 100644 doc/development/jh_features_review.md create mode 100644 lib/gitlab/ci/pipeline/chain/validate/security_orchestration_policy.rb create mode 100644 lib/sidebars/projects/menus/analytics_menu.rb delete mode 100755 scripts/sync-reports create mode 100644 spec/config/inject_enterprise_edition_module_spec.rb create mode 100644 spec/lib/sidebars/projects/menus/analytics_menu_spec.rb diff --git a/Dangerfile b/Dangerfile index 699be613f2d..37a45674e16 100644 --- a/Dangerfile +++ b/Dangerfile @@ -2,11 +2,15 @@ require 'gitlab-dangerfiles' -Gitlab::Dangerfiles.import_plugins(danger) -danger.import_plugin('danger/plugins/*.rb') +gitlab_dangerfiles = Gitlab::Dangerfiles::Engine.new(self) +gitlab_dangerfiles.import_plugins return if helper.release_automation? +danger.import_plugin('danger/plugins/*.rb') + +gitlab_dangerfiles.import_dangerfiles + project_helper.rule_names.each do |rule| danger.import_dangerfile(path: File.join('danger', rule)) end diff --git a/Gemfile b/Gemfile index cbbdfd14296..9cd928d5fd8 100644 --- a/Gemfile +++ b/Gemfile @@ -403,7 +403,7 @@ group :development, :test do end group :development, :test, :danger do - gem 'gitlab-dangerfiles', '~> 1.1.1', require: false + gem 'gitlab-dangerfiles', '~> 2.0.0', require: false end group :development, :test, :coverage do diff --git a/Gemfile.lock b/Gemfile.lock index 1cee984d59b..8111ff597e7 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -447,7 +447,7 @@ GEM terminal-table (~> 1.5, >= 1.5.1) gitlab-chronic (0.10.5) numerizer (~> 0.2) - gitlab-dangerfiles (1.1.1) + gitlab-dangerfiles (2.0.0) danger-gitlab gitlab-experiment (0.5.3) activesupport (>= 3.0) @@ -1449,7 +1449,7 @@ DEPENDENCIES gitaly (~> 13.11.0.pre.rc1) github-markup (~> 1.7.0) gitlab-chronic (~> 0.10.5) - gitlab-dangerfiles (~> 1.1.1) + gitlab-dangerfiles (~> 2.0.0) gitlab-experiment (~> 0.5.3) gitlab-fog-azure-rm (~> 1.0.1) gitlab-fog-google (~> 1.13) diff --git a/app/assets/javascripts/sidebar/components/date/sidebar_date_widget.vue b/app/assets/javascripts/sidebar/components/date/sidebar_date_widget.vue index 584f794752d..6a68e914b84 100644 --- a/app/assets/javascripts/sidebar/components/date/sidebar_date_widget.vue +++ b/app/assets/javascripts/sidebar/components/date/sidebar_date_widget.vue @@ -282,10 +282,12 @@ export default {