kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Update the MR template for security MRs

Browse source 
This makes two changes to the template:

1. EE MRs are now always required (see
   https://gitlab.com/gitlab-org/release/framework/issues/256 for a
   backstory).

2. We clarify that a release manager is not a suitable reviewer for
   security merge requests.
This commit is contained in:
Yorick Peterse 2019-03-27 13:35:28 +01:00
parent a9194b60d7
commit 02412a5040
No known key found for this signature in database
GPG key ID: EDD30D2BEB691AC9
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
.gitlab/merge_request_templates/Security Release.md
View file

@ -7,6 +7,10 @@ See [the general developer security release guidelines](https://gitlab.com/gitla
This merge request _must not_ close the corresponding security issue _unless_ it
targets master.
When submitting a merge request for CE, a corresponding EE merge request is
always required. This makes it easier to merge security merge requests, as
manually merging CE into EE is no longer required.
-->
## Related issues
@ -20,8 +24,8 @@ targets master.
- [ ] Title of this MR is the same as for all backports
- [ ] A [CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html) is added without a `merge_request` value, with `type` set to `security`
- [ ] Add a link to this MR in the `links` section of related issue
- [ ] Add a link to an EE MR if required
- [ ] Assign to a reviewer
- [ ] Set up an EE MR (always required for CE merge requests): EE_MR_LINK_HERE
- [ ] Assign to a reviewer (that is not a release manager)
## Reviewer checklist