Sort environments folders when opening them

Fixes gitlab-org/gitlab-ce#30814

app/controllers/projects/environments_controller.rb

@@ -31,6 +31,7 @@ class Projects::EnvironmentsController < Projects::ApplicationController
   def folder
     folder_environments = project.environments.where(environment_type: params[:id])
     @environments = folder_environments.with_state(params[:scope] || :available)
+      .order(:name)
 
     respond_to do |format|
       format.html

changelogs/unreleased/zj-sort-env-folders.yml

@@ -0,0 +1,4 @@
+---
+title: Sort folder for environments
+merge_request:
+author:

spec/controllers/projects/environments_controller_spec.rb

@@ -84,6 +84,9 @@ describe Projects::EnvironmentsController do
       create(:environment, project: project,
                            name: 'staging-1.0/review',
                            state: :available)
+      create(:environment, project: project,
+                           name: 'staging-1.0/preview',
+                           state: :available)
     end
 
     context 'when using default format' do
@@ -107,6 +110,8 @@ describe Projects::EnvironmentsController do
         expect(response).to be_ok
         expect(response).not_to render_template 'folder'
         expect(json_response['environments'][0])
+          .to include('name' => 'staging-1.0/preview')
+        expect(json_response['environments'][1])
           .to include('name' => 'staging-1.0/review')
       end
     end