From 05373c2490da3c1bad1a7b7f45ffd0fa11558c1c Mon Sep 17 00:00:00 2001 From: Pawel Chojnacki Date: Mon, 22 Jan 2018 14:18:34 +0100 Subject: [PATCH] Fix wrong histograam buckets --- lib/gitlab/metrics/subscribers/action_view.rb | 2 +- lib/gitlab/metrics/subscribers/active_record.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/gitlab/metrics/subscribers/action_view.rb b/lib/gitlab/metrics/subscribers/action_view.rb index 86bd56ff7eb..ce724040bc5 100644 --- a/lib/gitlab/metrics/subscribers/action_view.rb +++ b/lib/gitlab/metrics/subscribers/action_view.rb @@ -7,7 +7,7 @@ module Gitlab define_histogram :gitlab_view_rendering_duration_seconds do docstring 'View rendering time' base_labels Transaction::BASE_LABELS.merge({ path: nil }) - buckets [0.001, 0.01, 0.1, 10.0] + buckets [0.001, 0.01, 0.1, 1, 10.0] with_feature :prometheus_metrics_view_instrumentation end diff --git a/lib/gitlab/metrics/subscribers/active_record.rb b/lib/gitlab/metrics/subscribers/active_record.rb index bdcbd873001..ff6542f6e00 100644 --- a/lib/gitlab/metrics/subscribers/active_record.rb +++ b/lib/gitlab/metrics/subscribers/active_record.rb @@ -20,7 +20,7 @@ module Gitlab define_histogram :gitlab_sql_duration_seconds do docstring 'SQL time' base_labels Transaction::BASE_LABELS - buckets [0.001, 0.01, 0.1, 10.0] + buckets [0.001, 0.01, 0.1, 1.0, 10.0] end def current_transaction