Display empty files properly on MR diffs

This commit is contained in:
Sean Nichols 2018-12-08 00:50:56 -05:00
parent e7a6b84168
commit 05dcb2dd76
4 changed files with 13 additions and 0 deletions

View File

@ -176,6 +176,9 @@ export default {
{{ __('This source diff could not be displayed because it is too large.') }}
<span v-html="viewBlobLink"></span>
</div>
<div v-if="file.empty" class="nothing-here-block">
{{ __('Empty file') }}
</div>
</div>
</template>

View File

@ -5,6 +5,7 @@ class DiffFileEntity < DiffFileBaseEntity
include IconsHelper
expose :too_large?, as: :too_large
expose :empty?, as: :empty
expose :added_lines
expose :removed_lines

View File

@ -0,0 +1,5 @@
---
title: Display empty files properly on MR diffs
merge_request:
author: Sean Nichols
type: fixed

View File

@ -245,6 +245,10 @@ module Gitlab
end
# rubocop: enable CodeReuse/ActiveRecord
def empty?
valid_blobs.map(&:empty?).all?
end
def raw_binary?
try_blobs(:raw_binary?)
end