diff --git a/.gitignore b/.gitignore index 46cb0ac6c23..2a07963eecc 100644 --- a/.gitignore +++ b/.gitignore @@ -94,5 +94,6 @@ webpack-dev-server.json .solargraph.yml apollo.config.js /tmp/matching_foss_tests.txt +/tmp/matching_tests.txt ee/changelogs/unreleased-ee diff --git a/.gitlab/ci/rails.gitlab-ci.yml b/.gitlab/ci/rails.gitlab-ci.yml index 6acd52382cf..057c2b3a510 100644 --- a/.gitlab/ci/rails.gitlab-ci.yml +++ b/.gitlab/ci/rails.gitlab-ci.yml @@ -493,19 +493,17 @@ rspec-ee system pg12 geo: rspec foss-impact: extends: - .rspec-base-pg11-as-if-foss - - .rails:rules:ee-mr-only + - .rails:rules:rspec-foss-impact + needs: ["setup-test-env", "retrieve-tests-metadata", "compile-test-assets as-if-foss", "detect-tests as-if-foss"] script: - - install_gitlab_gem - - install_tff_gem - run_timed_command "scripts/gitaly-test-build" - run_timed_command "scripts/gitaly-test-spawn" - source scripts/rspec_helpers.sh - - tooling/bin/find_foss_tests tmp/matching_foss_tests.txt - rspec_matched_foss_tests tmp/matching_foss_tests.txt "--tag ~quarantine" artifacts: expire_in: 7d paths: - - tmp/matching_foss_tests.txt - tmp/capybara/ + # EE: Canonical MR pipelines ################################################## diff --git a/.gitlab/ci/rules.gitlab-ci.yml b/.gitlab/ci/rules.gitlab-ci.yml index 16193f2b1b0..71cfa856032 100644 --- a/.gitlab/ci/rules.gitlab-ci.yml +++ b/.gitlab/ci/rules.gitlab-ci.yml @@ -555,7 +555,16 @@ - <<: *if-master-refs changes: *code-backstage-patterns -.rails:rules:ee-mr-only: +.rails:rules:detect-tests: + rules: + - <<: *if-not-ee + when: never + - <<: *if-security-merge-request + changes: *code-backstage-patterns + - <<: *if-dot-com-gitlab-org-merge-request + changes: *code-backstage-patterns + +.rails:rules:rspec-foss-impact: rules: - <<: *if-not-ee when: never diff --git a/.gitlab/ci/setup.gitlab-ci.yml b/.gitlab/ci/setup.gitlab-ci.yml index b2b64700b18..d42c83a6d0f 100644 --- a/.gitlab/ci/setup.gitlab-ci.yml +++ b/.gitlab/ci/setup.gitlab-ci.yml @@ -59,3 +59,34 @@ verify-tests-yml: - source scripts/utils.sh - install_tff_gem - scripts/verify-tff-mapping + +.detect-test-base: + image: ruby:2.6-alpine + needs: [] + stage: prepare + script: + - source scripts/utils.sh + - install_gitlab_gem + - install_tff_gem + - tooling/bin/find_foss_tests ${MATCHED_TESTS_FILE} + artifacts: + expire_in: 7d + paths: + - ${MATCHED_TESTS_FILE} + +detect-tests: + extends: + - .detect-test-base + - .rails:rules:detect-tests + variables: + MATCHED_TESTS_FILE: tmp/matching_tests.txt + +detect-tests as-if-foss: + extends: + - .detect-test-base + - .rails:rules:detect-tests + - .as-if-foss + variables: + MATCHED_TESTS_FILE: tmp/matching_foss_tests.txt + before_script: + - '[ "$FOSS_ONLY" = "1" ] && rm -rf ee/ qa/spec/ee/ qa/qa/specs/features/ee/ qa/qa/ee/ qa/qa/ee.rb' diff --git a/.haml-lint_todo.yml b/.haml-lint_todo.yml index 13edc1f024e..4163c7bacd1 100644 --- a/.haml-lint_todo.yml +++ b/.haml-lint_todo.yml @@ -116,10 +116,12 @@ linters: - "app/views/import/bitbucket/status.html.haml" - "app/views/import/bitbucket_server/status.html.haml" - "app/views/invites/show.html.haml" + - "app/views/jira_connect/subscriptions/index.html.haml" - "app/views/layouts/_mailer.html.haml" - "app/views/layouts/experiment_mailer.html.haml" - "app/views/layouts/header/_default.html.haml" - "app/views/layouts/header/_new_dropdown.haml" + - "app/views/layouts/jira_connect.html.haml" - "app/views/layouts/notify.html.haml" - "app/views/notify/_failed_builds.html.haml" - "app/views/notify/_reassigned_issuable_email.html.haml" @@ -333,8 +335,6 @@ linters: - "ee/app/views/groups/group_members/_sync_button.html.haml" - "ee/app/views/groups/hooks/edit.html.haml" - "ee/app/views/groups/ldap_group_links/index.html.haml" - - "ee/app/views/jira_connect/subscriptions/index.html.haml" - - "ee/app/views/layouts/jira_connect.html.haml" - "ee/app/views/layouts/nav/ee/admin/_new_monitoring_sidebar.html.haml" - "ee/app/views/layouts/service_desk.html.haml" - "ee/app/views/ldap_group_links/_form.html.haml" diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index a0b7d19d05c..71ea80cf54f 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -e9860f7988a2c87638abf695d8613e3096312857 +851da3925944b969da7f87057ba8da8274d5c18d diff --git a/app/assets/javascripts/integrations/edit/components/override_dropdown.vue b/app/assets/javascripts/integrations/edit/components/override_dropdown.vue index 3c00cf84d1a..ea6d1892dfc 100644 --- a/app/assets/javascripts/integrations/edit/components/override_dropdown.vue +++ b/app/assets/javascripts/integrations/edit/components/override_dropdown.vue @@ -1,6 +1,8 @@