Fix specs to pass a project when creating subscriptions

This commit is contained in:
Douglas Barbosa Alexandre 2016-11-01 00:14:53 -02:00
parent 48d851d201
commit 091efb3152
3 changed files with 9 additions and 7 deletions

View File

@ -7,7 +7,7 @@ describe SentNotificationsController, type: :controller do
let(:issue) do
create(:issue, project: project, author: user) do |issue|
issue.subscriptions.create(user: user, subscribed: true)
issue.subscriptions.create(user: user, project: project, subscribed: true)
end
end
@ -85,7 +85,7 @@ describe SentNotificationsController, type: :controller do
context 'when the force param is not passed' do
let(:merge_request) do
create(:merge_request, source_project: project, author: user) do |merge_request|
merge_request.subscriptions.create(user: user, subscribed: true)
merge_request.subscriptions.create(user: user, project: project, subscribed: true)
end
end
let(:sent_notification) { create(:sent_notification, noteable: merge_request, recipient: user) }

View File

@ -176,6 +176,8 @@ describe Issue, "Issuable" do
end
describe '#subscribed?' do
let(:project) { issue.project }
context 'user is not a participant in the issue' do
before { allow(issue).to receive(:participants).with(user).and_return([]) }
@ -184,13 +186,13 @@ describe Issue, "Issuable" do
end
it 'returns true when a subcription exists and subscribed is true' do
issue.subscriptions.create(user: user, subscribed: true)
issue.subscriptions.create(user: user, project: project, subscribed: true)
expect(issue.subscribed?(user)).to be_truthy
end
it 'returns false when a subcription exists and subscribed is false' do
issue.subscriptions.create(user: user, subscribed: false)
issue.subscriptions.create(user: user, project: project, subscribed: false)
expect(issue.subscribed?(user)).to be_falsey
end
@ -204,13 +206,13 @@ describe Issue, "Issuable" do
end
it 'returns true when a subcription exists and subscribed is true' do
issue.subscriptions.create(user: user, subscribed: true)
issue.subscriptions.create(user: user, project: project, subscribed: true)
expect(issue.subscribed?(user)).to be_truthy
end
it 'returns false when a subcription exists and subscribed is false' do
issue.subscriptions.create(user: user, subscribed: false)
issue.subscriptions.create(user: user, project: project, subscribed: false)
expect(issue.subscribed?(user)).to be_falsey
end

View File

@ -267,7 +267,7 @@ describe Issuable::BulkUpdateService, services: true do
describe 'unsubscribe from issues' do
let(:issues) do
create_list(:closed_issue, 2, project: project) do |issue|
issue.subscriptions.create(user: user, subscribed: true)
issue.subscriptions.create(user: user, project: project, subscribed: true)
end
end