From 0956d0b8ee0e68a2723540a1e37446069d46ffb6 Mon Sep 17 00:00:00 2001 From: Rajat Jain Date: Wed, 6 Feb 2019 13:46:59 +0530 Subject: [PATCH] Use export-import svg from gitlab-svgs Use SVG assets from @gitlab/svgs instead of using svg illustrations from project folder --- app/assets/stylesheets/framework/modal.scss | 7 ++++--- app/views/projects/issues/_import_export.svg | 1 - app/views/projects/issues/import_csv/_modal.html.haml | 4 ++-- changelogs/unreleased/55312-svg.yml | 5 +++++ locale/gitlab.pot | 3 +++ 5 files changed, 14 insertions(+), 6 deletions(-) delete mode 100644 app/views/projects/issues/_import_export.svg create mode 100644 changelogs/unreleased/55312-svg.yml diff --git a/app/assets/stylesheets/framework/modal.scss b/app/assets/stylesheets/framework/modal.scss index ace46e32b18..3703b7568c8 100644 --- a/app/assets/stylesheets/framework/modal.scss +++ b/app/assets/stylesheets/framework/modal.scss @@ -111,10 +111,11 @@ body.modal-open { flex-grow: 1; height: 56px; padding: $gl-btn-padding $gl-btn-padding 0; + text-align: right; - > svg { - float: right; - height: 100%; + .illustration { + height: inherit; + width: initial; } } } diff --git a/app/views/projects/issues/_import_export.svg b/app/views/projects/issues/_import_export.svg deleted file mode 100644 index 53c35d12f57..00000000000 --- a/app/views/projects/issues/_import_export.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/app/views/projects/issues/import_csv/_modal.html.haml b/app/views/projects/issues/import_csv/_modal.html.haml index 5339c4325b9..86bc54786ad 100644 --- a/app/views/projects/issues/import_csv/_modal.html.haml +++ b/app/views/projects/issues/import_csv/_modal.html.haml @@ -5,8 +5,8 @@ .modal-header %h3 = _('Import issues') - .import-export-svg-container - = render 'projects/issues/import_export.svg' + .svg-content.import-export-svg-container + = image_tag 'illustrations/export-import.svg', alt: _('Import/Export illustration'), class: 'illustration' %a.close{ href: '#', 'data-dismiss' => 'modal' } × .modal-body .modal-text diff --git a/changelogs/unreleased/55312-svg.yml b/changelogs/unreleased/55312-svg.yml new file mode 100644 index 00000000000..a6260aeaf2a --- /dev/null +++ b/changelogs/unreleased/55312-svg.yml @@ -0,0 +1,5 @@ +--- +title: Use export-import svgs from gitlab-svgs +merge_request: 24954 +author: +type: other diff --git a/locale/gitlab.pot b/locale/gitlab.pot index 5ac9d7c8bd4..778a19c4d5b 100644 --- a/locale/gitlab.pot +++ b/locale/gitlab.pot @@ -3953,6 +3953,9 @@ msgstr "" msgid "Import timed out. Import took longer than %{import_jobs_expiration} seconds" msgstr "" +msgid "Import/Export illustration" +msgstr "" + msgid "ImportProjects|Importing the project failed" msgstr ""