Prefer extend self over module_function, feedback:

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5620#note_13672004 https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5620#note_13810498
2016-08-12 15:33:28 +08:00 · 2016-08-12 15:33:28 +08:00 · 0a20897bbe
parent abd3ac4a03
commit 0a20897bbe
4 changed files with 4 additions and 4 deletions
--- a/lib/gitlab/data_builder/build_data_builder.rb
+++ b/lib/gitlab/data_builder/build_data_builder.rb
@ -1,7 +1,7 @@
 module Gitlab
  module DataBuilder
    module BuildDataBuilder
-      module_function
+      extend self

      def build(build)
        project = build.project
--- a/lib/gitlab/data_builder/note_data_builder.rb
+++ b/lib/gitlab/data_builder/note_data_builder.rb
@ -1,7 +1,7 @@
 module Gitlab
  module DataBuilder
    module NoteDataBuilder
-      module_function
+      extend self

      # Produce a hash of post-receive data
      #
--- a/lib/gitlab/data_builder/pipeline_data_builder.rb
+++ b/lib/gitlab/data_builder/pipeline_data_builder.rb
@ -1,7 +1,7 @@
 module Gitlab
  module DataBuilder
    module PipelineDataBuilder
-      module_function
+      extend self

      def build(pipeline)
        {
--- a/lib/gitlab/data_builder/push_data_builder.rb
+++ b/lib/gitlab/data_builder/push_data_builder.rb
@ -1,7 +1,7 @@
 module Gitlab
  module DataBuilder
    module PushDataBuilder
-      module_function
+      extend self

      # Produce a hash of post-receive data
      #