From 0aa20f3dac8e19cc10b62e08a5c84df105a648c2 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 3 Feb 2022 18:17:34 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/test-metadata.gitlab-ci.yml | 1 + .gitlab/issue_templates/Deprecations.md | 2 +- .../components/avatars/user_avatar.vue | 14 +- .../components/blob_content_viewer.vue | 88 +++----- .../blob_viewers/download_viewer.vue | 20 +- .../components/blob_viewers/image_viewer.vue | 14 +- .../components/blob_viewers/index.js | 31 --- .../components/blob_viewers/lfs_viewer.vue | 14 +- .../components/blob_viewers/pdf_viewer.vue | 14 +- .../components/blob_viewers/video_viewer.vue | 9 +- .../javascripts/repository/constants.js | 51 +++++ .../vue_shared/components/source_viewer.vue | 14 +- app/models/commit.rb | 4 +- app/models/concerns/issuable.rb | 2 +- app/models/merge_request.rb | 35 ++-- app/serializers/member_user_entity.rb | 1 - .../issuable/common_system_notes_service.rb | 2 +- .../layouts/nav/sidebar/_admin.html.haml | 4 +- app/views/shared/web_hooks/_hook.html.haml | 2 +- config/application.rb | 10 + .../track_application_boot_time.yml | 8 + config/initializers/console_message.rb | 22 -- doc/administration/clusters/kas.md | 17 +- .../monitoring/prometheus/gitlab_metrics.md | 1 + doc/user/clusters/agent/index.md | 189 +---------------- doc/user/clusters/agent/troubleshooting.md | 193 ++++++++++++++++++ doc/user/infrastructure/iac/index.md | 37 ++-- doc/user/infrastructure/iac/mr_integration.md | 2 +- .../infrastructure/iac/terraform_state.md | 12 +- lib/gitlab/console.rb | 41 ++++ lib/gitlab/metrics/boot_time_tracker.rb | 34 +++ lib/gitlab/metrics/system.rb | 69 +++++-- lib/gitlab/runtime.rb | 6 + locale/gitlab.pot | 6 + package.json | 20 +- scripts/rspec_helpers.sh | 49 +++-- spec/crystalball_env.rb | 2 +- .../api/schemas/entities/member_user.json | 5 +- spec/frontend/content_editor/test_utils.js | 2 +- .../components/avatars/user_avatar_spec.js | 63 +++++- spec/frontend/members/mock_data.js | 2 + .../components/blob_content_viewer_spec.js | 64 +++--- .../blob_viewers/download_viewer_spec.js | 37 ++-- .../blob_viewers/image_viewer_spec.js | 12 +- .../blob_viewers/lfs_viewer_spec.js | 14 +- .../blob_viewers/pdf_viewer_spec.js | 10 +- .../blob_viewers/video_viewer_spec.js | 6 +- .../components/source_viewer_spec.js | 9 +- spec/lib/gitlab/console_spec.rb | 51 +++++ .../gitlab/metrics/boot_time_tracker_spec.rb | 98 +++++++++ spec/lib/gitlab/metrics/system_spec.rb | 34 ++- spec/lib/gitlab/runtime_spec.rb | 24 ++- spec/models/commit_spec.rb | 16 +- .../lib/tooling/test_map_generator_spec.rb | 16 ++ tooling/lib/tooling/test_map_generator.rb | 7 +- yarn.lock | 152 +++++++------- 56 files changed, 1029 insertions(+), 633 deletions(-) create mode 100644 config/feature_flags/development/track_application_boot_time.yml create mode 100644 doc/user/clusters/agent/troubleshooting.md create mode 100644 lib/gitlab/console.rb create mode 100644 lib/gitlab/metrics/boot_time_tracker.rb create mode 100644 spec/lib/gitlab/console_spec.rb create mode 100644 spec/lib/gitlab/metrics/boot_time_tracker_spec.rb diff --git a/.gitlab/ci/test-metadata.gitlab-ci.yml b/.gitlab/ci/test-metadata.gitlab-ci.yml index 8f4aca730e7..20cbd759ac6 100644 --- a/.gitlab/ci/test-metadata.gitlab-ci.yml +++ b/.gitlab/ci/test-metadata.gitlab-ci.yml @@ -8,6 +8,7 @@ - knapsack/ - rspec/ - crystalball/ + when: always retrieve-tests-metadata: extends: diff --git a/.gitlab/issue_templates/Deprecations.md b/.gitlab/issue_templates/Deprecations.md index 1de64088ca6..dd9b4faacd7 100644 --- a/.gitlab/issue_templates/Deprecations.md +++ b/.gitlab/issue_templates/Deprecations.md @@ -40,7 +40,7 @@ Which tier is this feature available in? - To see who the stable counterparts are for a product team visit [product categories](https://about.gitlab.com/handbook/product/categories/) - If there is no stable counterpart listed for Sales/CS please mention `@timtams` - If there is no stable counterpart listed for Support please @mention `@gitlab-com/support/managers` - - If there is no stable counterpart listed for Marketing please mention `@williamchia` + - If there is no stable counterpart listed for Marketing please mention `@cfoster3` - [ ] @mention your GPM so that they are aware of planned deprecations. The goal is to have reviews happen at least two releases before the final removal of the feature or introduction of a breaking change. diff --git a/app/assets/javascripts/members/components/avatars/user_avatar.vue b/app/assets/javascripts/members/components/avatars/user_avatar.vue index 9687eacb036..ec59f0f681c 100644 --- a/app/assets/javascripts/members/components/avatars/user_avatar.vue +++ b/app/assets/javascripts/members/components/avatars/user_avatar.vue @@ -8,10 +8,14 @@ import { import { generateBadges } from 'ee_else_ce/members/utils'; import { glEmojiTag } from '~/emoji'; import { __ } from '~/locale'; +import { isUserBusy } from '~/set_status_modal/utils'; import { AVATAR_SIZE } from '../../constants'; export default { name: 'UserAvatar', + i18n: { + busy: __('Busy'), + }, avatarSize: AVATAR_SIZE, orphanedUserLabel: __('Orphaned member'), safeHtmlConfig: { ADD_TAGS: ['gl-emoji'] }, @@ -46,7 +50,10 @@ export default { }).filter((badge) => badge.show); }, statusEmoji() { - return this.user?.status?.emoji; + return this.user?.showStatus && this.user?.status?.emoji; + }, + isUserBusy() { + return isUserBusy(this.user?.availability || ''); }, }, methods: { @@ -73,6 +80,11 @@ export default { :entity-id="user.id" > diff --git a/app/assets/javascripts/repository/components/blob_viewers/download_viewer.vue b/app/assets/javascripts/repository/components/blob_viewers/download_viewer.vue index 48fa33eb558..f7b318c64d9 100644 --- a/app/assets/javascripts/repository/components/blob_viewers/download_viewer.vue +++ b/app/assets/javascripts/repository/components/blob_viewers/download_viewer.vue @@ -9,19 +9,17 @@ export default { GlLink, }, props: { - fileName: { - type: String, + blob: { + type: Object, required: true, }, - filePath: { - type: String, - required: true, - }, - fileSize: { - type: Number, - required: false, - default: 0, - }, + }, + data() { + return { + fileName: this.blob.name, + filePath: this.blob.rawPath, + fileSize: this.blob.rawSize || 0, + }; }, computed: { downloadFileSize() { diff --git a/app/assets/javascripts/repository/components/blob_viewers/image_viewer.vue b/app/assets/javascripts/repository/components/blob_viewers/image_viewer.vue index 83d36209bb3..5027f7877aa 100644 --- a/app/assets/javascripts/repository/components/blob_viewers/image_viewer.vue +++ b/app/assets/javascripts/repository/components/blob_viewers/image_viewer.vue @@ -1,15 +1,17 @@