From 0ab17699c88587c5872f9517b29be5f43224a8ea Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Mon, 16 Nov 2020 06:09:20 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../components/alerts_integrations_list.vue | 6 +- .../components/alerts_settings_form_new.vue | 396 +++++++++++------- .../components/alerts_settings_wrapper.vue | 29 ++ .../javascripts/alerts_settings/constants.js | 1 + .../boards/components/board_column.vue | 43 +- .../boards/components/board_column_new.vue | 94 +++++ .../boards/components/board_content.vue | 5 +- .../boards/components/board_list_header.vue | 15 +- .../components/board_list_header_new.vue | 358 ++++++++++++++++ .../components/board_promotion_state.js | 1 + app/assets/javascripts/boards/index.js | 2 + .../javascripts/boards/stores/actions.js | 5 +- locale/gitlab.pot | 9 + qa/qa/page/base.rb | 7 + .../alerts_settings_form_new_spec.js.snap | 116 ++--- .../alerts_integrations_list_spec.js | 3 + .../alerts_settings_form_new_spec.js | 1 + .../alerts_settings_wrapper_spec.js | 40 +- .../components/board_column_new_spec.js | 72 ++++ .../boards/components/board_column_spec.js | 2 +- .../components/board_list_header_new_spec.js | 169 ++++++++ .../sentry_errors_request_spec.rb | 10 +- 22 files changed, 1113 insertions(+), 271 deletions(-) create mode 100644 app/assets/javascripts/boards/components/board_column_new.vue create mode 100644 app/assets/javascripts/boards/components/board_list_header_new.vue create mode 100644 app/assets/javascripts/boards/components/board_promotion_state.js create mode 100644 spec/frontend/boards/components/board_column_new_spec.js create mode 100644 spec/frontend/boards/components/board_list_header_new_spec.js diff --git a/app/assets/javascripts/alerts_settings/components/alerts_integrations_list.vue b/app/assets/javascripts/alerts_settings/components/alerts_integrations_list.vue index 2e66a1196a4..e17ce022403 100644 --- a/app/assets/javascripts/alerts_settings/components/alerts_integrations_list.vue +++ b/app/assets/javascripts/alerts_settings/components/alerts_integrations_list.vue @@ -11,6 +11,7 @@ import { GlSprintf, } from '@gitlab/ui'; import { s__, __ } from '~/locale'; +import glFeatureFlagsMixin from '~/vue_shared/mixins/gl_feature_flags_mixin'; import Tracking from '~/tracking'; import { trackAlertIntegrationsViewsOptions, integrationToDeleteDefault } from '../constants'; import getCurrentIntegrationQuery from '../graphql/queries/get_current_integration.query.graphql'; @@ -48,6 +49,7 @@ export default { GlTooltip: GlTooltipDirective, GlModal: GlModalDirective, }, + mixins: [glFeatureFlagsMixin()], props: { integrations: { type: Array, @@ -96,7 +98,7 @@ export default { tbodyTrClass(item) { return { [bodyTrClass]: this.integrations.length, - 'gl-bg-blue-50': item?.id === this.currentIntegration?.id, + 'gl-bg-blue-50': (item !== null && item.id) === this.currentIntegration?.id, }; }, trackPageViews() { @@ -150,7 +152,7 @@ export default {