From 0bc6d001650023d2552ea5f30ffee18033c39d3a Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 10 Jul 2020 18:09:45 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/CODEOWNERS | 1 + Gemfile | 4 +- Gemfile.lock | 6 +- .../javascripts/monitoring/stores/actions.js | 2 +- .../wikis/components/delete_wiki_modal.vue | 15 +- app/controllers/concerns/snippets_actions.rb | 1 + app/controllers/concerns/snippets_sort.rb | 9 + .../dashboard/snippets_controller.rb | 3 +- .../projects/snippets_controller.rb | 2 +- app/controllers/snippets_controller.rb | 2 +- app/finders/snippets_finder.rb | 10 +- app/policies/merge_request_policy.rb | 4 + app/services/members/destroy_service.rb | 4 +- .../merge_requests/approval_service.rb | 10 +- .../merge_requests/remove_approval_service.rb | 8 + .../push_to_merge_request_email.text.haml | 4 +- ...2-move-plan-stage-usage-activity-to-ce.yml | 5 + .../223159-fix-dahsboard-warning-logic.yml | 5 + .../fj-default-order-snippet-lists.yml | 5 + ...ds-java-version-in-dependency-scanning.yml | 5 + .../tc-fix-plain-text-commit-mails.yml | 5 + doc/README.md | 2 +- doc/administration/feature_flags.md | 18 ++ .../packages/container_registry.md | 2 +- doc/development/fe_guide/tooling.md | 38 +++ doc/development/telemetry/usage_ping.md | 17 +- doc/operations/index.md | 1 + .../metrics/dashboards/panel_types.md | 261 ++++++++++++++++++ doc/operations/metrics/dashboards/yaml.md | 2 +- doc/user/permissions.md | 1 + doc/user/project/integrations/prometheus.md | 256 ----------------- .../Dependency-Scanning.gitlab-ci.yml | 1 + lib/gitlab/usage_data.rb | 9 +- package.json | 4 +- qa/qa.rb | 4 + qa/qa/page/modal/delete_wiki.rb | 17 ++ qa/qa/page/project/wiki/edit.rb | 9 + qa/qa/page/project/wiki/show.rb | 4 + .../2_plan/issue/jira_issue_import_spec.rb | 2 + .../wiki/project_based_page_deletion_spec.rb | 26 ++ scripts/lint-doc.sh | 3 +- .../concerns/renders_commits_spec.rb | 2 +- .../dashboard/snippets_controller_spec.rb | 4 +- .../projects/snippets_controller_spec.rb | 28 +- spec/controllers/snippets_controller_spec.rb | 6 + spec/finders/snippets_finder_spec.rb | 16 ++ .../frontend/monitoring/store/actions_spec.js | 19 ++ spec/lib/gitlab/usage_data_spec.rb | 25 ++ spec/policies/merge_request_policy_spec.rb | 1 + .../merge_requests/approval_service_spec.rb | 14 + .../remove_approval_service_spec.rb | 9 + .../snippets_sort_order_shared_examples.rb | 41 +++ .../shared_examples/views/plain_text_email.rb | 9 + ...h_to_merge_request_email.text.haml_spec.rb | 19 ++ yarn.lock | 8 +- 55 files changed, 688 insertions(+), 300 deletions(-) create mode 100644 app/controllers/concerns/snippets_sort.rb create mode 100644 changelogs/unreleased/217362-move-plan-stage-usage-activity-to-ce.yml create mode 100644 changelogs/unreleased/223159-fix-dahsboard-warning-logic.yml create mode 100644 changelogs/unreleased/fj-default-order-snippet-lists.yml create mode 100644 changelogs/unreleased/propagate-ds-java-version-in-dependency-scanning.yml create mode 100644 changelogs/unreleased/tc-fix-plain-text-commit-mails.yml create mode 100644 doc/operations/metrics/dashboards/panel_types.md create mode 100644 qa/qa/page/modal/delete_wiki.rb create mode 100644 qa/qa/specs/features/browser_ui/3_create/wiki/project_based_page_deletion_spec.rb create mode 100644 spec/support/shared_examples/controllers/snippets_sort_order_shared_examples.rb create mode 100644 spec/support/shared_examples/views/plain_text_email.rb create mode 100644 spec/views/notify/push_to_merge_request_email.text.haml_spec.rb diff --git a/.gitlab/CODEOWNERS b/.gitlab/CODEOWNERS index 2c5169dc921..79e4d4925f1 100644 --- a/.gitlab/CODEOWNERS +++ b/.gitlab/CODEOWNERS @@ -13,6 +13,7 @@ /doc/development/ @marcia @mjang1 /doc/development/documentation/ @mikelewis /doc/ci @marcel.amirault @sselhorn +/doc/operations @aqualls @eread /doc/user/clusters @aqualls /doc/user/infrastructure @aqualls /doc/user/project/clusters @aqualls diff --git a/Gemfile b/Gemfile index 62d6d3767ed..c1f93c78932 100644 --- a/Gemfile +++ b/Gemfile @@ -244,7 +244,9 @@ gem 'slack-messenger', '~> 2.3.3' gem 'hangouts-chat', '~> 0.0.5' # Asana integration -gem 'asana', '~> 0.9' +# asana 0.10.1 needs faraday 1.0 +# https://gitlab.com/gitlab-org/gitlab/-/issues/224296 +gem 'asana', '0.10.0' # FogBugz integration gem 'ruby-fogbugz', '~> 0.2.1' diff --git a/Gemfile.lock b/Gemfile.lock index f68fd455352..03c213333df 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -76,7 +76,7 @@ GEM apollo_upload_server (2.0.0.beta.3) graphql (>= 1.8) rails (>= 4.2) - asana (0.9.3) + asana (0.10.0) faraday (~> 0.9) faraday_middleware (~> 0.9) faraday_middleware-multi_json (~> 0.0) @@ -304,7 +304,7 @@ GEM multipart-post (>= 1.2, < 3) faraday-http-cache (2.0.0) faraday (~> 0.8) - faraday_middleware (0.12.2) + faraday_middleware (0.14.0) faraday (>= 0.7.4, < 1.0) faraday_middleware-aws-signers-v4 (0.1.7) aws-sdk-resources (~> 2) @@ -1175,7 +1175,7 @@ DEPENDENCIES addressable (~> 2.7) akismet (~> 3.0) apollo_upload_server (~> 2.0.0.beta3) - asana (~> 0.9) + asana (= 0.10.0) asciidoctor (~> 2.0.10) asciidoctor-include-ext (~> 0.3.1) asciidoctor-plantuml (~> 0.0.12) diff --git a/app/assets/javascripts/monitoring/stores/actions.js b/app/assets/javascripts/monitoring/stores/actions.js index d74e0887c9b..cac04faae98 100644 --- a/app/assets/javascripts/monitoring/stores/actions.js +++ b/app/assets/javascripts/monitoring/stores/actions.js @@ -375,7 +375,7 @@ export const fetchDashboardValidationWarnings = ({ state, dispatch }) => { }) .then(resp => resp.data?.project?.environments?.nodes?.[0]?.metricsDashboard) .then(({ schemaValidationWarnings } = {}) => { - const hasWarnings = schemaValidationWarnings?.length !== 0; + const hasWarnings = schemaValidationWarnings && schemaValidationWarnings.length !== 0; /** * The payload of the dispatch is a boolean, because at the moment a standard * warning message is shown instead of the warnings the BE returns diff --git a/app/assets/javascripts/pages/shared/wikis/components/delete_wiki_modal.vue b/app/assets/javascripts/pages/shared/wikis/components/delete_wiki_modal.vue index 580cca49b5e..a7b7d597fb7 100644 --- a/app/assets/javascripts/pages/shared/wikis/components/delete_wiki_modal.vue +++ b/app/assets/javascripts/pages/shared/wikis/components/delete_wiki_modal.vue @@ -55,13 +55,22 @@ export default {