kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Use keyword arguments for boolean values and use span instead of a for clone "button"

Browse source
This commit is contained in:
Patricio Cano 2016-07-05 16:48:48 -05:00
parent be221a30ac
commit 0bdf6fe4ba
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/helpers/application_settings_helper.rb
View file

@ -47,9 +47,9 @@ module ApplicationSettingsHelper
def enabled_project_button(project, protocol)
case protocol
when 'ssh'
ssh_clone_button(project, 'bottom', false)
ssh_clone_button(project, 'bottom', append_link: false)
else
http_clone_button(project, 'bottom', false)
http_clone_button(project, 'bottom', append_link: false)
end
end

8
app/helpers/button_helper.rb
View file

@ -40,13 +40,13 @@ module ButtonHelper
type: :button
end
def http_clone_button(project, placement = 'right', append_link = true)
def http_clone_button(project, placement = 'right', append_link: true)
klass = 'http-selector'
klass << ' has-tooltip' if current_user.try(:require_password?)
protocol = gitlab_config.protocol.upcase
content_tag :a, protocol,
content_tag (append_link ? :a : :span), protocol,
class: klass,
href: (project.http_url_to_repo if append_link),
data: {
@ -57,11 +57,11 @@ module ButtonHelper
}
end
def ssh_clone_button(project, placement = 'right', append_link = true)
def ssh_clone_button(project, placement = 'right', append_link: true)
klass = 'ssh-selector'
klass << ' has-tooltip' if current_user.try(:require_ssh_key?)
content_tag :a, 'SSH',
content_tag (append_link ? :a : :span), 'SSH',
class: klass,
href: (project.ssh_url_to_repo if append_link),
data: {