Converted integration_settings_form to axios

app/assets/javascripts/integrations/integration_settings_form.js

@@ -1,4 +1,5 @@
-import Flash from '../flash';
+import axios from '../lib/utils/axios_utils';
+import flash from '../flash';
 
 export default class IntegrationSettingsForm {
   constructor(formSelector) {
@@ -95,29 +96,26 @@ export default class IntegrationSettingsForm {
    */
   testSettings(formData) {
     this.toggleSubmitBtnState(true);
-    $.ajax({
+
-      type: 'PUT',
+    return axios.put(this.testEndPoint, formData)
-      url: this.testEndPoint,
+      .then(({ data }) => {
-      data: formData,
+        if (data.error) {
-    })
+          flash(`${data.message} ${data.service_response}`, 'alert', document, {
-    .done((res) => {
+            title: 'Save anyway',
-      if (res.error) {
+            clickHandler: (e) => {
-        new Flash(`${res.message} ${res.service_response}`, 'alert', document, {
+              e.preventDefault();
-          title: 'Save anyway',
+              this.$form.submit();
-          clickHandler: (e) => {
+            },
-            e.preventDefault();
+          });
-            this.$form.submit();
+        } else {
-          },
+          this.$form.submit();
-        });
+        }
-      } else {
+
-        this.$form.submit();
+        this.toggleSubmitBtnState(false);
-      }
+      })
-    })
+      .catch(() => {
-    .fail(() => {
+        flash('Something went wrong on our end.');
-      new Flash('Something went wrong on our end.');
+        this.toggleSubmitBtnState(false);
-    })
+      });
-    .always(() => {
-      this.toggleSubmitBtnState(false);
-    });
   }
 }

spec/javascripts/integrations/integration_settings_form_spec.js

@@ -1,3 +1,5 @@
+import MockAdaptor from 'axios-mock-adapter';
+import axios from '~/lib/utils/axios_utils';
 import IntegrationSettingsForm from '~/integrations/integration_settings_form';
 
 describe('IntegrationSettingsForm', () => {
@@ -109,91 +111,117 @@ describe('IntegrationSettingsForm', () => {
   describe('testSettings', () => {
     let integrationSettingsForm;
     let formData;
+    let mock;
 
     beforeEach(() => {
+      mock = new MockAdaptor(axios);
+
+      spyOn(axios, 'put').and.callThrough();
+
       integrationSettingsForm = new IntegrationSettingsForm('.js-integration-settings-form');
       formData = integrationSettingsForm.$form.serialize();
     });
 
-    it('should make an ajax request with provided `formData`', () => {
+    afterEach(() => {
-      const deferred = $.Deferred();
+      mock.restore();
-      spyOn($, 'ajax').and.returnValue(deferred.promise());
+    });
 
-      integrationSettingsForm.testSettings(formData);
+    it('should make an ajax request with provided `formData`', (done) => {
+      integrationSettingsForm.testSettings(formData)
+        .then(() => {
+          expect(axios.put).toHaveBeenCalledWith(integrationSettingsForm.testEndPoint, formData);
 
-      expect($.ajax).toHaveBeenCalledWith({
+          done();
-        type: 'PUT',
+        })
-        url: integrationSettingsForm.testEndPoint,
+        .catch(done.fail);
-        data: formData,
+    });
+
+    it('should show error Flash with `Save anyway` action if ajax request responds with error in test', (done) => {
+      const errorMessage = 'Test failed.';
+      mock.onPut(integrationSettingsForm.testEndPoint).reply(200, {
+        error: true,
+        message: errorMessage,
+        service_response: 'some error',
       });
+
+      integrationSettingsForm.testSettings(formData)
+        .then(() => {
+          const $flashContainer = $('.flash-container');
+          expect($flashContainer.find('.flash-text').text().trim()).toEqual('Test failed. some error');
+          expect($flashContainer.find('.flash-action')).toBeDefined();
+          expect($flashContainer.find('.flash-action').text().trim()).toEqual('Save anyway');
+
+          done();
+        })
+        .catch(done.fail);
     });
 
-    it('should show error Flash with `Save anyway` action if ajax request responds with error in test', () => {
+    it('should submit form if ajax request responds without any error in test', (done) => {
-      const errorMessage = 'Test failed.';
-      const deferred = $.Deferred();
-      spyOn($, 'ajax').and.returnValue(deferred.promise());
-
-      integrationSettingsForm.testSettings(formData);
-
-      deferred.resolve({ error: true, message: errorMessage, service_response: 'some error' });
-
-      const $flashContainer = $('.flash-container');
-      expect($flashContainer.find('.flash-text').text().trim()).toEqual('Test failed. some error');
-      expect($flashContainer.find('.flash-action')).toBeDefined();
-      expect($flashContainer.find('.flash-action').text().trim()).toEqual('Save anyway');
-    });
-
-    it('should submit form if ajax request responds without any error in test', () => {
-      const deferred = $.Deferred();
-      spyOn($, 'ajax').and.returnValue(deferred.promise());
-
-      integrationSettingsForm.testSettings(formData);
-
       spyOn(integrationSettingsForm.$form, 'submit');
-      deferred.resolve({ error: false });
 
-      expect(integrationSettingsForm.$form.submit).toHaveBeenCalled();
+      mock.onPut(integrationSettingsForm.testEndPoint).reply(200, {
+        error: false,
+      });
+
+      integrationSettingsForm.testSettings(formData)
+        .then(() => {
+          expect(integrationSettingsForm.$form.submit).toHaveBeenCalled();
+
+          done();
+        })
+        .catch(done.fail);
     });
 
-    it('should submit form when clicked on `Save anyway` action of error Flash', () => {
+    it('should submit form when clicked on `Save anyway` action of error Flash', (done) => {
-      const errorMessage = 'Test failed.';
-      const deferred = $.Deferred();
-      spyOn($, 'ajax').and.returnValue(deferred.promise());
-
-      integrationSettingsForm.testSettings(formData);
-
-      deferred.resolve({ error: true, message: errorMessage });
-
-      const $flashAction = $('.flash-container .flash-action');
-      expect($flashAction).toBeDefined();
-
       spyOn(integrationSettingsForm.$form, 'submit');
-      $flashAction.get(0).click();
+
-      expect(integrationSettingsForm.$form.submit).toHaveBeenCalled();
+      const errorMessage = 'Test failed.';
+      mock.onPut(integrationSettingsForm.testEndPoint).reply(200, {
+        error: true,
+        message: errorMessage,
+      });
+
+      integrationSettingsForm.testSettings(formData)
+        .then(() => {
+          const $flashAction = $('.flash-container .flash-action');
+          expect($flashAction).toBeDefined();
+
+          $flashAction.get(0).click();
+        })
+        .then(() => {
+          expect(integrationSettingsForm.$form.submit).toHaveBeenCalled();
+
+          done();
+        })
+        .catch(done.fail);
     });
 
-    it('should show error Flash if ajax request failed', () => {
+    it('should show error Flash if ajax request failed', (done) => {
       const errorMessage = 'Something went wrong on our end.';
-      const deferred = $.Deferred();
-      spyOn($, 'ajax').and.returnValue(deferred.promise());
 
-      integrationSettingsForm.testSettings(formData);
+      mock.onPut(integrationSettingsForm.testEndPoint).networkError();
 
-      deferred.reject();
+      integrationSettingsForm.testSettings(formData)
+        .then(() => {
+          expect($('.flash-container .flash-text').text().trim()).toEqual(errorMessage);
 
-      expect($('.flash-container .flash-text').text().trim()).toEqual(errorMessage);
+          done();
+        })
+        .catch(done.fail);
     });
 
-    it('should always call `toggleSubmitBtnState` with `false` once request is completed', () => {
+    it('should always call `toggleSubmitBtnState` with `false` once request is completed', (done) => {
-      const deferred = $.Deferred();
+      mock.onPut(integrationSettingsForm.testEndPoint).networkError();
-      spyOn($, 'ajax').and.returnValue(deferred.promise());
-
-      integrationSettingsForm.testSettings(formData);
 
       spyOn(integrationSettingsForm, 'toggleSubmitBtnState');
-      deferred.reject();
 
-      expect(integrationSettingsForm.toggleSubmitBtnState).toHaveBeenCalledWith(false);
+      integrationSettingsForm.testSettings(formData)
+        .then(() => {
+          expect(integrationSettingsForm.toggleSubmitBtnState).toHaveBeenCalledWith(false);
+
+          done();
+        })
+        .catch(done.fail);
     });
   });
 });