kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Enable Performance/TimesMap Rubocop cop 

Use Array.new with a block instead of `.times.collect` / `.times.map`.

See #17478
This commit is contained in:
Grzegorz Bizon 2016-05-30 14:21:26 +02:00
parent 43c35b0f20
commit 0c6f04427b
2 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.rubocop.yml
View File

@ -1027,10 +1027,9 @@ Performance/StartWith:
Performance/StringReplacement: Performance/StringReplacement:
Enabled: true Enabled: true
# TODO: Enable TimesMap Cop.
# Checks for `.times.map` calls. # Checks for `.times.map` calls.
Performance/TimesMap: Performance/TimesMap:
Enabled: false Enabled: true
##################### Rails ################################## ##################### Rails ##################################

9
spec/services/issues/bulk_update_service_spec.rb
View File

@ -15,9 +15,7 @@ describe Issues::BulkUpdateService, services: true do
describe :close_issue do describe :close_issue do
before do before do
@issues = 5.times.collect do @issues = create_list(:issue, 5, project: @project)
create(:issue, project: @project)
end
@params = { @params = {
state_event: 'close', state_event: 'close',
issues_ids: @issues.map(&:id) issues_ids: @issues.map(&:id)
@ -36,11 +34,8 @@ describe Issues::BulkUpdateService, services: true do
end end
describe :reopen_issues do describe :reopen_issues do
before do before do
@issues = 5.times.collect do @issues = create_list(:closed_issue, 5, project: @project)
create(:closed_issue, project: @project)
end
@params = { @params = {
state_event: 'reopen', state_event: 'reopen',
issues_ids: @issues.map(&:id) issues_ids: @issues.map(&:id)