Enable Performance/TimesMap Rubocop cop
Use Array.new with a block instead of `.times.collect` / `.times.map`. See #17478
This commit is contained in:
parent
43c35b0f20
commit
0c6f04427b
|
@ -1027,10 +1027,9 @@ Performance/StartWith:
|
|||
Performance/StringReplacement:
|
||||
Enabled: true
|
||||
|
||||
# TODO: Enable TimesMap Cop.
|
||||
# Checks for `.times.map` calls.
|
||||
Performance/TimesMap:
|
||||
Enabled: false
|
||||
Enabled: true
|
||||
|
||||
|
||||
##################### Rails ##################################
|
||||
|
|
|
@ -15,9 +15,7 @@ describe Issues::BulkUpdateService, services: true do
|
|||
describe :close_issue do
|
||||
|
||||
before do
|
||||
@issues = 5.times.collect do
|
||||
create(:issue, project: @project)
|
||||
end
|
||||
@issues = create_list(:issue, 5, project: @project)
|
||||
@params = {
|
||||
state_event: 'close',
|
||||
issues_ids: @issues.map(&:id)
|
||||
|
@ -36,11 +34,8 @@ describe Issues::BulkUpdateService, services: true do
|
|||
end
|
||||
|
||||
describe :reopen_issues do
|
||||
|
||||
before do
|
||||
@issues = 5.times.collect do
|
||||
create(:closed_issue, project: @project)
|
||||
end
|
||||
@issues = create_list(:closed_issue, 5, project: @project)
|
||||
@params = {
|
||||
state_event: 'reopen',
|
||||
issues_ids: @issues.map(&:id)
|
||||
|
|
Loading…
Reference in New Issue