Merge branch '38877-disable-autocomplete-in-filtered-search' into 'master'

Disables autocomplete in filtered search

Closes #38877

See merge request gitlab-org/gitlab-ce!15477
This commit is contained in:
Clement Ho 2017-11-22 17:24:31 +00:00
commit 0c972f56b8
3 changed files with 11 additions and 1 deletions

View File

@ -140,7 +140,8 @@ module SearchHelper
placeholder: 'Search or filter results...',
data: {
'username-params' => @users.to_json(only: [:id, :username])
}
},
autocomplete: 'off'
}
if @project.present?

View File

@ -0,0 +1,5 @@
---
title: Disables autocomplete in filtered searc
merge_request: 15477
author: Jacopo Beschi @jacopo-beschi
type: added

View File

@ -102,6 +102,10 @@ describe SearchHelper do
it 'includes project base-endpoint' do
expect(search_filter_input_options('')[:data]['base-endpoint']).to eq(project_path(@project))
end
it 'includes autocomplete=off flag' do
expect(search_filter_input_options('')[:autocomplete]).to eq('off')
end
end
context 'group' do