Move group_dropdown_label to ce helper
This commit is contained in:
parent
a81fd22f4e
commit
0d11c4a8c7
2 changed files with 34 additions and 0 deletions
|
@ -131,6 +131,19 @@ module IssuablesHelper
|
|||
end
|
||||
end
|
||||
|
||||
def group_dropdown_label(group_id, default_label)
|
||||
return default_label if group_id.nil?
|
||||
return "Any group" if group_id == "0"
|
||||
|
||||
group = ::Group.find_by(id: group_id)
|
||||
|
||||
if group
|
||||
group.full_name
|
||||
else
|
||||
default_label
|
||||
end
|
||||
end
|
||||
|
||||
def milestone_dropdown_label(milestone_title, default_label = "Milestone")
|
||||
title =
|
||||
case milestone_title
|
||||
|
|
|
@ -21,6 +21,27 @@ describe IssuablesHelper do
|
|||
end
|
||||
end
|
||||
|
||||
describe '#group_dropdown_label' do
|
||||
let(:group) { create(:group) }
|
||||
let(:default) { 'default label' }
|
||||
|
||||
it 'returns default group label when group_id is nil' do
|
||||
expect(group_dropdown_label(nil, default)).to eq('default label')
|
||||
end
|
||||
|
||||
it 'returns "any group" when group_id is 0' do
|
||||
expect(group_dropdown_label('0', default)).to eq('Any group')
|
||||
end
|
||||
|
||||
it 'returns group full path when a group was found for the provided id' do
|
||||
expect(group_dropdown_label(group.id, default)).to eq(group.full_name)
|
||||
end
|
||||
|
||||
it 'returns default label when a group was not found for the provided id' do
|
||||
expect(group_dropdown_label(9999, default)).to eq('default label')
|
||||
end
|
||||
end
|
||||
|
||||
describe '#issuable_labels_tooltip' do
|
||||
it 'returns label text with no labels' do
|
||||
expect(issuable_labels_tooltip([])).to eq("Labels")
|
||||
|
|
Loading…
Reference in a new issue