diff --git a/.rubocop.yml b/.rubocop.yml index 21e2f8f2827..5d5d6094bad 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -785,3 +785,21 @@ Gemspec/AvoidExecutingGit: Lint/BinaryOperatorWithIdenticalOperands: Exclude: - '{,ee/,qa/}spec/**/*_{spec,shared_examples,shared_context}.rb' + +Cop/SidekiqRedisCall: + Enabled: true + Exclude: + - '{,ee/,jh/}spec/**/*' + - 'lib/gitlab/database/migration_helpers.rb' + - 'lib/gitlab/sidekiq_migrate_jobs.rb' + - 'lib/gitlab/sidekiq_versioning.rb' + +Cop/RedisQueueUsage: + Enabled: true + Exclude: + - '{,ee/,jh/}spec/**/*' + - 'config/initializers/sidekiq.rb' + - 'lib/gitlab/instrumentation/redis.rb' + - 'lib/gitlab/redis.rb' + - 'lib/system_check/app/redis_version_check.rb' + - 'lib/gitlab/mail_room.rb' diff --git a/app/assets/javascripts/milestones/milestone_select.js b/app/assets/javascripts/milestones/milestone_select.js index c95ec3dd10b..d4876c3dbe8 100644 --- a/app/assets/javascripts/milestones/milestone_select.js +++ b/app/assets/javascripts/milestones/milestone_select.js @@ -121,7 +121,7 @@ export default class MilestoneSelect { title: __('Started'), }); } - if (extraOptions.length) { + if (extraOptions.length && data.length) { extraOptions.push({ type: 'divider' }); } diff --git a/app/assets/javascripts/pages/admin/groups/show/index.js b/app/assets/javascripts/pages/admin/groups/show/index.js deleted file mode 100644 index 86b80a0ba5b..00000000000 --- a/app/assets/javascripts/pages/admin/groups/show/index.js +++ /dev/null @@ -1,3 +0,0 @@ -import UsersSelect from '~/users_select'; - -new UsersSelect(); // eslint-disable-line no-new diff --git a/app/assets/javascripts/runner/admin_runners/admin_runners_app.vue b/app/assets/javascripts/runner/admin_runners/admin_runners_app.vue index f5620876783..74656a4fcd8 100644 --- a/app/assets/javascripts/runner/admin_runners/admin_runners_app.vue +++ b/app/assets/javascripts/runner/admin_runners/admin_runners_app.vue @@ -30,7 +30,12 @@ import RunnerActionsCell from '../components/cells/runner_actions_cell.vue'; import { pausedTokenConfig } from '../components/search_tokens/paused_token_config'; import { statusTokenConfig } from '../components/search_tokens/status_token_config'; import { tagTokenConfig } from '../components/search_tokens/tag_token_config'; -import { ADMIN_FILTERED_SEARCH_NAMESPACE, INSTANCE_TYPE, I18N_FETCH_ERROR } from '../constants'; +import { + ADMIN_FILTERED_SEARCH_NAMESPACE, + INSTANCE_TYPE, + I18N_FETCH_ERROR, + FILTER_CSS_CLASSES, +} from '../constants'; import { captureException } from '../sentry_utils'; export default { @@ -167,6 +172,7 @@ export default { }, filteredSearchNamespace: ADMIN_FILTERED_SEARCH_NAMESPACE, INSTANCE_TYPE, + FILTER_CSS_CLASSES, };