From 0d8bcdf77d609b3624541de767a0129aa0b7e8d2 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Tue, 4 Oct 2022 09:09:18 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop.yml | 18 ++ .../milestones/milestone_select.js | 2 +- .../pages/admin/groups/show/index.js | 3 - .../admin_runners/admin_runners_app.vue | 9 +- .../components/runner_filtered_search_bar.vue | 1 - .../components/runner_membership_toggle.vue | 42 ++++ app/assets/javascripts/runner/constants.js | 12 + .../graphql/list/group_runners.query.graphql | 3 +- .../list/group_runners_count.query.graphql | 3 +- .../group_runners/group_runners_app.vue | 32 ++- .../javascripts/runner/runner_search_utils.js | 18 +- app/controllers/admin/groups_controller.rb | 11 - app/controllers/groups/runners_controller.rb | 4 + app/models/concerns/cache_markdown_field.rb | 2 + app/views/admin/groups/show.html.haml | 15 -- .../issuable/_milestone_dropdown.html.haml | 4 - app/views/shared/members/_requests.html.haml | 2 +- config/routes.rb | 5 - .../geo/setup/external_database.md | 3 +- doc/architecture/blueprints/pods/index.md | 2 +- .../blueprints/rate_limiting/index.md | 2 +- doc/development/audit_event_guide/index.md | 2 +- doc/development/ee_features.md | 2 +- doc/development/sidekiq/index.md | 6 + doc/integration/arkose.md | 2 +- doc/integration/mattermost/index.md | 2 +- .../application_security/dast/checks/16.5.md | 2 +- .../application_security/dast/checks/16.6.md | 2 +- .../group/saml_sso/troubleshooting_scim.md | 2 +- .../clusters/migrate_to_gitlab_agent.md | 2 +- .../merge_requests/reviews/data_usage.md | 14 +- doc/user/tasks.md | 2 +- doc/user/usage_quotas.md | 14 +- lib/gitlab/redis/duplicate_jobs.rb | 2 + lib/gitlab/redis/sidekiq_status.rb | 2 +- .../duplicate_jobs/duplicate_job.rb | 2 +- lib/gitlab/sidekiq_status.rb | 2 +- locale/gitlab.pot | 18 +- rubocop/cop/redis_queue_usage.rb | 38 +++ rubocop/cop/sidekiq_redis_call.rb | 18 ++ .../admin/groups_controller_spec.rb | 60 ----- spec/features/admin/admin_groups_spec.rb | 25 -- spec/features/admin/admin_settings_spec.rb | 2 +- .../components/promote_label_modal_spec.js | 120 ++++----- .../index/components/stop_jobs_modal_spec.js | 40 ++- spec/frontend/pdf/page_spec.js | 25 +- .../admin_runners/admin_runners_app_spec.js | 10 + .../runner_filtered_search_bar_spec.js | 33 ++- .../runner_membership_toggle_spec.js | 57 +++++ .../components/runner_type_tabs_spec.js | 16 +- .../group_runners/group_runners_app_spec.js | 76 +++++- spec/frontend/runner/mock_data.js | 96 +++++++- .../states/mr_widget_merged_spec.js | 228 +++++++++--------- spec/rubocop/cop/redis_queue_usage_spec.rb | 99 ++++++++ spec/rubocop/cop/sidekiq_redis_call_spec.rb | 30 +++ workhorse/go.mod | 2 +- workhorse/go.sum | 4 +- 57 files changed, 841 insertions(+), 409 deletions(-) delete mode 100644 app/assets/javascripts/pages/admin/groups/show/index.js create mode 100644 app/assets/javascripts/runner/components/runner_membership_toggle.vue create mode 100644 rubocop/cop/redis_queue_usage.rb create mode 100644 rubocop/cop/sidekiq_redis_call.rb create mode 100644 spec/frontend/runner/components/runner_membership_toggle_spec.js create mode 100644 spec/rubocop/cop/redis_queue_usage_spec.rb create mode 100644 spec/rubocop/cop/sidekiq_redis_call_spec.rb diff --git a/.rubocop.yml b/.rubocop.yml index 21e2f8f2827..5d5d6094bad 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -785,3 +785,21 @@ Gemspec/AvoidExecutingGit: Lint/BinaryOperatorWithIdenticalOperands: Exclude: - '{,ee/,qa/}spec/**/*_{spec,shared_examples,shared_context}.rb' + +Cop/SidekiqRedisCall: + Enabled: true + Exclude: + - '{,ee/,jh/}spec/**/*' + - 'lib/gitlab/database/migration_helpers.rb' + - 'lib/gitlab/sidekiq_migrate_jobs.rb' + - 'lib/gitlab/sidekiq_versioning.rb' + +Cop/RedisQueueUsage: + Enabled: true + Exclude: + - '{,ee/,jh/}spec/**/*' + - 'config/initializers/sidekiq.rb' + - 'lib/gitlab/instrumentation/redis.rb' + - 'lib/gitlab/redis.rb' + - 'lib/system_check/app/redis_version_check.rb' + - 'lib/gitlab/mail_room.rb' diff --git a/app/assets/javascripts/milestones/milestone_select.js b/app/assets/javascripts/milestones/milestone_select.js index c95ec3dd10b..d4876c3dbe8 100644 --- a/app/assets/javascripts/milestones/milestone_select.js +++ b/app/assets/javascripts/milestones/milestone_select.js @@ -121,7 +121,7 @@ export default class MilestoneSelect { title: __('Started'), }); } - if (extraOptions.length) { + if (extraOptions.length && data.length) { extraOptions.push({ type: 'divider' }); } diff --git a/app/assets/javascripts/pages/admin/groups/show/index.js b/app/assets/javascripts/pages/admin/groups/show/index.js deleted file mode 100644 index 86b80a0ba5b..00000000000 --- a/app/assets/javascripts/pages/admin/groups/show/index.js +++ /dev/null @@ -1,3 +0,0 @@ -import UsersSelect from '~/users_select'; - -new UsersSelect(); // eslint-disable-line no-new diff --git a/app/assets/javascripts/runner/admin_runners/admin_runners_app.vue b/app/assets/javascripts/runner/admin_runners/admin_runners_app.vue index f5620876783..74656a4fcd8 100644 --- a/app/assets/javascripts/runner/admin_runners/admin_runners_app.vue +++ b/app/assets/javascripts/runner/admin_runners/admin_runners_app.vue @@ -30,7 +30,12 @@ import RunnerActionsCell from '../components/cells/runner_actions_cell.vue'; import { pausedTokenConfig } from '../components/search_tokens/paused_token_config'; import { statusTokenConfig } from '../components/search_tokens/status_token_config'; import { tagTokenConfig } from '../components/search_tokens/tag_token_config'; -import { ADMIN_FILTERED_SEARCH_NAMESPACE, INSTANCE_TYPE, I18N_FETCH_ERROR } from '../constants'; +import { + ADMIN_FILTERED_SEARCH_NAMESPACE, + INSTANCE_TYPE, + I18N_FETCH_ERROR, + FILTER_CSS_CLASSES, +} from '../constants'; import { captureException } from '../sentry_utils'; export default { @@ -167,6 +172,7 @@ export default { }, filteredSearchNamespace: ADMIN_FILTERED_SEARCH_NAMESPACE, INSTANCE_TYPE, + FILTER_CSS_CLASSES, };